[Bug 8163] New: Click to populate XSLT preferences with "default" or empty values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Priority: P5 - low Change sponsored?: --- Bug ID: 8163 CC: gmcharlt@gmail.com Assignee: oleonard@myacpl.org Summary: Click to populate XSLT preferences with "default" or empty values Severity: enhancement Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: ASSIGNED Version: master Component: System Administration Product: Koha Now that there are several options for populating the XSLT system preferences it would make things easier if the user could click to populate the field with "default" or to empty the field. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9840&action=edit Bug 8163 - Click to populate XSLT preferences with "default" or empty values This patch adds markup and JavaScript to the system preferences interface so that the user can click "default" or "empty" to populate an XSLT-related pref with those vaules. To test, open system preferences for the OPAC or staff client. In the description for an XSLT-related preference click the "default" link to populate the field with "default." Click the "leave empty" link to empty the field. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- I wonder if we can make things more generic, like for example: <a href="#" class="set_syspref" data-syspref="OPACXSLTResultsDisplay" data-value="default">Set to default</a> <a href="#" class="set_syspref" data-syspref="OPACXSLTResultsDisplay" data-value="">Leave empty</a> with JS: $(".set_syspref").click(function() { var s = $(this).attr('data-syspref'); var v = $(this).attr('data-value'); $("#pref_"+s).val(v); }); or something like this. What do you think? This way we can provide default button for all 'Free' and 'Integer' sysprefs that have a default value. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9840|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11086&action=edit Bug 8163 [REVISED] Click to populate XSLT preferences with "default" or empty values This patch adds markup and JavaScript to the system preferences interface so that the user can click "default" or "empty" to populate an XSLT-related pref with those vaules. To test, open system preferences for the OPAC or staff client. In the description for an XSLT-related preference click the "default" link to populate the field with "default." Click the "leave empty" link to empty the field. Revised according to Julian Maurice's suggestion for a more generic, flexible way to implement it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- The patch doesn't apply on master because it relies on your previous patch. Can you resubmit a clean patch? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #4)
The patch doesn't apply on master because it relies on your previous patch. Can you resubmit a clean patch?
Sorry, that was careless of me. Revision coming up. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11086|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11107&action=edit Bug 8163 [REVISED] Click to populate XSLT preferences with "default" or empty values This patch adds markup and JavaScript to the system preferences interface so that the user can click "default" or "empty" to populate an XSLT-related pref with those vaules. To test, open system preferences for the OPAC or staff client. In the description for an XSLT-related preference click the "default" link to populate the field with "default." Click the "leave empty" link to empty the field. Revised according to Julian Maurice's suggestion for a more generic, flexible way to implement it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11107|0 |1 is obsolete| | --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 11109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11109&action=edit [SIGNED-OFF] Bug 8163 [REVISED] Click to populate XSLT preferences with "default" or empty values Works well. It's really easy to add similar links for other preferences. Great patch! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: It is a nice feature but a few comments for the new JS function are needed. Indeed, how a new developper can understand the utility of the css class set_syspref ? We can't find it using grep :-/ Marking as Passed QA but a followup is required. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |paul.poulain@biblibre.com --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- Hey, there's a tiny remaining problem with your patch: * open OPAC tab (or search XSLT, or whatever to reach one of the syspref updated by this patch) * click on "default", the "default" appears in the cell * go to the bottom : damned, the syspref can't be saved because the button is still grey & not clickable ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11109|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13181&action=edit Bug 8163 [REVISED] Click to populate XSLT preferences with "default" or empty values This patch adds markup and JavaScript to the system preferences interface so that the user can click "default" or "empty" to populate an XSLT-related pref with those vaules. To test, open system preferences for the OPAC or staff client. In the description for an XSLT-related preference click the "default" link to populate the field with "default." Click the "leave empty" link to empty the field. Revised according to Julian Maurice's suggestion for a more generic, flexible way to implement it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Sorry, commmit message should also note that the problem Paul describes in comment 9 is fixed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia@bywatersolutions.com --- Comment #12 from Melia Meggs <melia@bywatersolutions.com> --- I'm not sure about this revised patch. After I applied it, I could see the blue links on "Leave empty" and "default," but when I click on them, nothing happens. I tried changing an empty one to default and changing a default one to empty, but nothing changed. Is it working for anyone else? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #12)
I'm not sure about this revised patch. After I applied it, I could see the blue links on "Leave empty" and "default," but when I click on them, nothing happens.
Try clearing your browser cache (or doing shift-reload). The patch modifies a linked javascript file which is probably being cached by the browser. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13181|0 |1 is obsolete| | --- Comment #14 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 13319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13319&action=edit [Signed off] Bug 8163 [REVISED] Click to populate XSLT preferences with "default" or empty values This patch adds markup and JavaScript to the system preferences interface so that the user can click "default" or "empty" to populate an XSLT-related pref with those vaules. To test, open system preferences for the OPAC or staff client. In the description for an XSLT-related preference click the "default" link to populate the field with "default." Click the "leave empty" link to empty the field. Revised according to Julian Maurice's suggestion for a more generic, flexible way to implement it. Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #15 from Melia Meggs <melia@bywatersolutions.com> --- Ok, that did it! Clicking the "leave empty" and "default" links correctly fill in the cells, and I can save the sys prefs after I have modified them. I am signing off now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- The last patch fixes the Paul's remark. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.12 --- Comment #17 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Contains string changes. Will hold for 3.12. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #18 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz Version|3.12 |3.10 Severity|enhancement |trivial --- Comment #19 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushing to 3.10.x will be in 3.10.1 more of a bug fix than an enhancement, the current way to populate the xslt prefs is very error prone -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |3.8 --- Comment #20 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |liz@catalyst.net.nz Resolution|--- |FIXED --- Comment #21 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Patches do not apply to 3.6.x, please reopen and submit a patch for 3.6.x if necessary. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org