[Bug 8800] New: SpecifyDueDate && useDaysMode=Datedue wrong behaviour
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Priority: P5 - low Change sponsored?: --- Bug ID: 8800 CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: SpecifyDueDate && useDaysMode=Datedue wrong behaviour Severity: normal Classification: Unclassified OS: All Reporter: tomascohen@gmail.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha What should happen when a librarian specifies a due date that matches a holiday and useDaysMode=Datedue (Calculate the due date using the calendar to push the due date to the next open day)? My guess is that the due date should be fixed to match the next open day. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 12444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12444&action=edit Bug 8800 - useDaysMode=Datedue wrong behaviour useDaysMode=Datedue wasn't used as advertised in the docs. Added a next_open_day sub to Koha::Calendar and some tests for it. - AddIssue was fixed for the case $datedue was defined in circ/circulation.pl - CalcDateDue was modified to be consistent with the intended behaviour Regards To+ Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12444|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 12445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12445&action=edit Bug 8800 - useDaysMode=Datedue wrong behaviour useDaysMode=Datedue wasn't used as advertised in the docs. Added a next_open_day sub to Koha::Calendar and some tests for it. - AddIssue was fixed for the case $datedue was defined in circ/circulation.pl - CalcDateDue was modified to be consistent with the intended behaviour Regards To+ Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch needs two sysprefs set like this: useDaysMode=Datedue SpecifyDueDate=1 Test plan: - On circulation specify a due date that matches a holiday, the due day should be automatically set to the next open day. - Checkout an item so that the due date (without taking the calendar into account) matches a holiday, the final due date should be set to the next open day. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12445|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 12446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12446&action=edit Bug 8800 - useDaysMode=Datedue wrong behaviour Forgot to check availability of some variables. Fixed. Regards To+ Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12446|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 12448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12448&action=edit useDaysMode='Calendar' should make date due be the next open day too. Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12448|0 |1 is obsolete| | --- Comment #6 from Elliott Davis <elliott@bywatersolutions.com> --- Created attachment 12449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12449&action=edit Bug 8800 - useDaysMode=Datedue wrong behaviour useDaysMode=Datedue wasn't used as advertised in the docs. Added a next_open_day sub to Koha::Calendar and some tests for it. - AddIssue was fixed for the case $datedue was defined in circ/circulation.pl - CalcDateDue was modified to be consistent with the intended behaviour Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Elliott Davis <elliott@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 12527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12527&action=edit Bug 8800 - useDaysMode=Datedue wrong behaviour (3.8.x) useDaysMode=Datedue wasn't used as advertised in the docs. Added a next_open_day sub to Koha::Calendar and some tests for it. - AddIssue was fixed for the case $datedue was defined in circ/circulation.pl - CalcDateDue was modified to be consistent with the intended behaviour Regards To+ Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Federico Rinaudo <frinaudo@infocpt.com.ar> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12527|0 |1 is obsolete| | --- Comment #8 from Federico Rinaudo <frinaudo@infocpt.com.ar> --- Created attachment 12600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12600&action=edit Bug 8800 - useDaysMode=Datedue wrong behaviour (3.8.x) useDaysMode=Datedue wasn't used as advertised in the docs. Added a next_open_day sub to Koha::Calendar and some tests for it. - AddIssue was fixed for the case $datedue was defined in circ/circulation.pl - CalcDateDue was modified to be consistent with the intended behaviour Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Federico Rinaudo <frinaudo@infocpt.com.ar> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #6)
Created attachment 12449 [details] Bug 8800 - useDaysMode=Datedue wrong behaviour
Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Elliott Davis <elliott@bywatersolutions.com>
patch (applied on master) looks good, passing QA... $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit 6c18204) * a74b490 Bug 8800 - useDaysMode=Datedue wrong behaviour C4/Circulation.pm Koha/Calendar.pm t/Calendar.t * C4/Circulation.pm OK * Koha/Calendar.pm OK * t/Calendar.t OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |paul.poulain@biblibre.com --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- (additionnal QA comment, this patch could have a big side effect, i'll push it becase it's a bugfix, but I double check !) This patch fixes a problem in 2 different places: * in AddIssue, if the datedue is provided, Koha calculate the next open day (except if useDaysMode is set to Calendar). This sounds logical = the librarian entering a date may have forgotten that it's a closed date, and it's useful that Koha calculates the next open date (this part of the patch could be considered as an ENH) * in CalcDueDate, called if the datedue is not provided, the patch adds a sub to calculate the next open day if the syspref is set to Datedue. But, from a QA pov, i'm not sure this patch is written in the proper way: in Koha::Calendar.pm, the method addDate is here to calculate the datedue. The next_open_day added in this patch is a duplicate of what addDate is supposed to do. In fact, the addDate already includes calculation: } elsif ( $days_mode eq 'Calendar' ) { if ( $unit eq 'hours' ) { $base_date->add_duration($add_duration); while ( $self->is_holiday($base_date) ) { $base_date->add_duration($day_dur); } } else { my $days = abs $add_duration->in_units('days'); while ($days) { $base_date->add_duration($day_dur); if ( $self->is_holiday($base_date) ) { next; } else { --$days; } } } If it does not work, it should be fixed here. Overall, failing QA, sorry: the patch may fix the problem, but it's improperly coded. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 12919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12919&action=edit Bug 8800 - useDaysMode=Datedue wrong behaviour (revisited) useDaysMode=Datedue wasn't used as advertised in the docs. Added next_open_day and prev_open_day subs to Koha::Calendar and some tests for them. - CalcDateDue was modified to be consistent with the intended behaviour - Koha::Calendar->addDate was rewritten in a more sane way (also split into addHours and addDays for convenience). Regards To+ Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |elliott@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12449|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Elliott Davis <elliott@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12600|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |blocker -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- perl t/Calendar.t 2012-11-10 08:23:06 christopher pts/2 1..28 ok 1 - use Koha::Calendar; ok 2 - use C4::Calendar; ok 3 - Calendar class returned isa Koha::Calendar ok 4 - Sunday is a closed day ok 5 - Monday is not a closed day ok 6 - month/day closed day test ok 7 - special closed day test ok 8 - open day test ok 9 - addDate skips closed Sunday ok 10 - Negative call to addDate ok 11 - days_between calculates correctly ok 12 - Simple Single Day Add (Calendar) ok 13 - Add 7 days Calendar mode ok 14 - Add 7 days Datedue mode ok 15 - Add 7 days Days mode ok 16 - is holiday for the next test ok 17 - Date should be the same after is_holiday ok 18 - test larger intervals ok 19 - test positive intervals ok 20 - test parameter order not relevant ok 21 - days_between calculates correctly ok 22 - holiday correctly recognized ok 23 - multiple holidays correctly recognized ok 24 - Next open day correctly calculated ok 25 - Previous open day correctly calculated ok 1 - Single day add (Datedue, matches holiday, shift) ok 2 - Two days add, skips holiday (Datedue) 1..2 ok 26 - useDaysMode=Datedue ok 1 - Single day add (Calendar) 1..1 ok 27 - useDaysMode=Calendar ok 1 - Single day add (Days) 1..1 ok 28 - useDaysMode=Days -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12919|0 |1 is obsolete| | --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 13367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13367&action=edit Bug 8800 - useDaysMode=Datedue wrong behaviour (revisited) useDaysMode=Datedue wasn't used as advertised in the docs. Added next_open_day and prev_open_day subs to Koha::Calendar and some tests for them. - CalcDateDue was modified to be consistent with the intended behaviour - Koha::Calendar->addDate was rewritten in a more sane way (also split into addHours and addDays for convenience). Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Increased the number of tests to 28 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment * all tests passes, * koha-qa.pl is OK * looking at the code, it seems to properly fix the problem. Thanks a lot Tomas ! passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13367|0 |1 is obsolete| | --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 13402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13402&action=edit Bug 8800 - useDaysMode=Datedue wrong behaviour (revisited) useDaysMode=Datedue wasn't used as advertised in the docs. Added next_open_day and prev_open_day subs to Koha::Calendar and some tests for them. - CalcDateDue was modified to be consistent with the intended behaviour - Koha::Calendar->addDate was rewritten in a more sane way (also split into addHours and addDays for convenience). Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Increased the number of tests to 28 Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #16 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Could I please have a detailed test plan? As I understand it, I should be taking the following steps to test this: 1) Create a holiday, say on November 14. 2) Try to check out a book, manually setting the due date to November 14. 3) See that the book is due November 15. No matter what I said useDaysMode to, the book is due November 14. I also tried setting a 2-day loan rule, and the due date was still November 14. Am I doing something wrong? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I ommited the manual-date-auto-fix thing as Paul said it should have its own enh bug. This just makes usedaysmode=datedue work as expected. Automatic calculation. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 --- Comment #18 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Okay, that makes sense. What is the exact procedure I should use for testing the automatic calculation? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13402|0 |1 is obsolete| | --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 13447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13447&action=edit Bug 8800 - useDaysMode=Datedue wrong behaviour (revisited) useDaysMode=Datedue wasn't used as advertised in the docs. Added next_open_day and prev_open_day subs to Koha::Calendar and some tests for them. - Koha::Calendar->addDate was rewritten in a more sane way (also split into addHours and addDays for convenience). - Fixed a bug introduced in Bug 8966 regarding dt truncation and dtSets->contains - Minor docs typos - Use the passed Calendar mode or default to 'Calendar' in Koha::Calendar->_mockinit. - Tests I'm writing some db-dependent tests for is_holiday, and hopefully for CalcDateDue so any rewrite/followup doesn't break things. Regards To+ Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Testing: - Set useDaysMode = Datedue - Set circulation rules so the datedue matches a holiday (calculated in straight days) - Proceed to checkout: - Without the patch the due date matches the straight days calculation - With the patch the due date matches the next open day -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9074 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 13571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13571&action=edit test plan and results of testing Hi Tomas, in my tests your patch results in a great improvement. There is only one exception - the exceptions. Before your patch the functionality is totally broken and I think we need to fix this before release. I can't be trusted much around calendars and timezones, so I wrote all my test cases up in a PDF document - hope it's understandable and helpful. Note: I didn't test with hourly loans, because I am not totally sure how it should work. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- On bug 9074 I added some db-dependent tests that expose exceptions do not work. I also filled a bug for exceptions (bug 9078) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9078 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13591&action=edit Bug 8800 - useDaysMode=Datedue wrong behaviour (revisited) useDaysMode=Datedue wasn't used as advertised in the docs. Added next_open_day and prev_open_day subs to Koha::Calendar and some tests for them. - Koha::Calendar->addDate was rewritten in a more sane way (also split into addHours and addDays for convenience). - Fixed a bug introduced in Bug 8966 regarding dt truncation and dtSets->contains - Minor docs typos - Use the passed Calendar mode or default to 'Calendar' in Koha::Calendar->_mockinit. - Tests I'm writing some db-dependent tests for is_holiday, and hopefully for CalcDateDue so any rewrite/followup doesn't break things. Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13447|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |kyle@bywatersolutions.com --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Tested in conjunction with the patch for bug 9078. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13591|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13605&action=edit Bug 8800 - useDaysMode=Datedue wrong behaviour (revisited) useDaysMode=Datedue wasn't used as advertised in the docs. Added next_open_day and prev_open_day subs to Koha::Calendar and some tests for them. - Koha::Calendar->addDate was rewritten in a more sane way (also split into addHours and addDays for convenience). - Fixed a bug introduced in Bug 8966 regarding dt truncation and dtSets->contains - Minor docs typos - Use the passed Calendar mode or default to 'Calendar' in Koha::Calendar->_mockinit. - Tests I'm writing some db-dependent tests for is_holiday, and hopefully for CalcDateDue so any rewrite/followup doesn't break things. Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13571|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 13619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13619&action=edit test plan and testing results (2) The new patch scores full points in my tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13605|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 13620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13620&action=edit Bug 8800 - useDaysMode=Datedue wrong behaviour (revisited) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Version|master |3.10 --- Comment #28 from Paul Poulain <paul.poulain@biblibre.com> --- QA comments: * passes koha-qa.pl * t/Calendar.pm is successfull * very very good test plan & tests results, kf++++ * nothing spotted in the code quality itself passed QA ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #29 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 --- Comment #30 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to branch 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version|3.10 |3.8 --- Comment #31 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |liz@catalyst.net.nz Resolution|--- |FIXED --- Comment #32 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Patches do not apply to 3.6.x, please reopen and submit a patch for 3.6.x if necessary. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org