[Bug 20199] New: Letters.t does not pass with new SQL modes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20199 Bug ID: 20199 Summary: Letters.t does not pass with new SQL modes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org DBD::mysql::st execute failed: Incorrect date value: '2018-02-14 02:03 PM' for column 'entrydate' at row 1 [for Statement "INSERT INTO `aqorders` ( `basketno`, `biblionumber`, `budget_id`, `entrydate`, `ordernum ber`, `quantity`, `quantityreceived`) VALUES ( ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0='14', 1='454', 2='13', 3='2018-02-14 02:03 PM', 4=undef, 5=1, 6=0] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 183 2. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20199 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20178 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20199 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20199 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71623&action=edit Bug 20199: Add tests for Koha::Acq::Order->store -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20199 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71624&action=edit Bug 20199: Send a DateTime to DBIC instead of an iso formatted date We do not need to format the date, DBIC handles DateTime correctly. It fixes t/db_dependent/Letters.t with new SQL modes Test plan: prove t/db_dependent/Letters.t prove t/db_dependent/Koha/Acquisition/Order.t Must return green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20199 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20199 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71624|0 |1 is obsolete| | --- Comment #3 from Roch D'Amour <roch.damour@inlibro.com> --- Created attachment 72163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72163&action=edit Bug 20199: Send a DateTime to DBIC instead of an iso formatted date We do not need to format the date, DBIC handles DateTime correctly. It fixes t/db_dependent/Letters.t with new SQL modes Test plan: prove t/db_dependent/Letters.t prove t/db_dependent/Koha/Acquisition/Order.t Must return green Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20199 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roch.damour@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20199 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20199 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71623|0 |1 is obsolete| | Attachment #72163|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 72166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72166&action=edit Bug 20199: Add tests for Koha::Acq::Order->store Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20199 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 72167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72167&action=edit Bug 20199: Send a DateTime to DBIC instead of an iso formatted date We do not need to format the date, DBIC handles DateTime correctly. It fixes t/db_dependent/Letters.t with new SQL modes Test plan: prove t/db_dependent/Letters.t prove t/db_dependent/Koha/Acquisition/Order.t Must return green Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20199 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20199 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- I think this is not needed for 17.11, let me know if I am wrong -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org