https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 92066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92066&action=edit Bug 23354: Initial work on payment screen -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is now ready for testing.. I'd love some feedback on the UX and things before adding the necessary tests and things to get it through QA. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #3 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- (In reply to Martin Renvoize from comment #2)

This is now ready for testing.. I'd love some feedback on the UX and things before adding the necessary tests and things to get it through QA.

Hi Martin, Could you expand on the test plan a bit? Just want to make sure I don't miss anything :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23442 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 [Bug 23442] Add a 'refund' option to the 'Pay' screen -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 [Bug 23355] Add 'cashup' process to the accounts system -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 92431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92431&action=edit Bug 23354: Add a Point Of Sale 'pay' screen This patch adds a new Point Of Sale module to Koha's staff client front page. The module button leads directly to a 'Pay' page giving the staff user the ability to record anonymous payments for items that would not normally require a patron to be registered at the library. Test plan: 1) Enable `UseCashRegisters` via the system preferences. 2) Ensure your user has the 'manage_cash_registers' permission. 3) Add a cash register for your current branch. 4) Add at least one 'MANUAL_INV' authorized value. 5) Navigate to the new 'POS' pay page via the main menu. 6) Add an item to the 'sale' by clicking 'add' from the right side of the screen. 7) Note that said item was added to the table of items this sale on the left. 8) At this point you should be able to 'click to edit' the quantity or price of the item in the table on the left. 9) Enter an amount greater than the price of the item into the 'amount collected from patron' box. 10) Click 'Confirm' 11) Varify that the same change to give modal from the paycollect pages appears here. 12) Click 'Confirm' 13) Payment will have been recorded (check the database) and you will be back at a fresh 'Pay' page ready for the next transaction. 14) Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 92433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92433&action=edit Bug 23354: Add ability to remove items This patch adds the ability to remove items from a transactions on the new Point of Sale pay page. Test plan: 1) Populate a transaction with at least one item. 2) Note the new button to 'Remove item' on the items table. 3) Click the button and confirm the item is removed 4) Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Hayley Mapley from comment #3)

(In reply to Martin Renvoize from comment #2)

...

This is now ready for testing.. I'd love some feedback on the UX and things before adding the necessary tests and things to get it through QA.

Hi Martin,

Could you expand on the test plan a bit? Just want to make sure I don't miss anything :)

Hi Hayley, Thanks for showing interesting in this. I think the included test plans in the patches should now go some way towards a decent test plan for this, but do feel free to ask questions. Any feedback would be greatly appreciated. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Hi Martin, Thanks for the test plans! I get up to 7) on the first patch, and when I click the Add button it doesn't add the item to the This sale box. No plack-errors, but the console had some output which I've attached in the screenshot I attached. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92431|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 92830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92830&action=edit Bug 23354: Add a Point Of Sale 'pay' screen This patch adds a new Point Of Sale module to Koha's staff client front page. The module button leads directly to a 'Pay' page giving the staff user the ability to record anonymous payments for items that would not normally require a patron to be registered at the library. Test plan: 1) Enable `UseCashRegisters` via the system preferences. 2) Ensure your user has the 'manage_cash_registers' permission. 3) Add a cash register for your current branch. 4) Add at least one 'MANUAL_INV' authorized value. 5) Navigate to the new 'POS' pay page via the main menu. 6) Add an item to the 'sale' by clicking 'add' from the right side of the screen. 7) Note that said item was added to the table of items this sale on the left. 8) At this point you should be able to 'click to edit' the quantity or price of the item in the table on the left. 9) Enter an amount greater than the price of the item into the 'amount collected from patron' box. 10) Click 'Confirm' 11) Varify that the same change to give modal from the paycollect pages appears here. 12) Click 'Confirm' 13) Payment will have been recorded (check the database) and you will be back at a fresh 'Pay' page ready for the next transaction. 14) Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92433|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 92832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92832&action=edit Bug 23354: Add ability to remove items This patch adds the ability to remove items from a transactions on the new Point of Sale pay page. Test plan: 1) Populate a transaction with at least one item. 2) Note the new button to 'Remove item' on the items table. 3) Click the button and confirm the item is removed 4) Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 92834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92834&action=edit Bug 23354: Add permissions -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92831|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 92874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92874&action=edit Bug 23354: Add receipting to Pay page This patch adds receipt printing to the new Point of Sale pay page. Test plan: 1) Apply patch and run database update 2) Enable automatic receipt printing via the `` system preference. 3) Make a payment for an item via the new POS pay page. 4) Note that a receipt printing dialogue is shown automatically after payment. 5) Note that a new notice is available under tools where you can alter the content of the receipt. 6) Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92833|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 92876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92876&action=edit Bug 23354: (follow-up) Responses to feedback This patch impliments a number of refinements requested after the first round of feedback from the sponsors. 1) Fix padding on pay page 2) Switch 'items to add' from right to left on the page 3) Fix editable columns on pay page 4) Add explanitory text to pay page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 92878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92878&action=edit Bug 23354: Add tests for Koha::Charges::Sales Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92874|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 92891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92891&action=edit Bug 23354: Add receipting to Pay page This patch adds receipt printing to the new Point of Sale pay page. Test plan: 1) Apply patch and run database update 2) Enable automatic receipt printing via the `` system preference. 3) Make a payment for an item via the new POS pay page. 4) Note that a receipt printing dialogue is shown automatically after payment. 5) Note that a new notice is available under tools where you can alter the content of the receipt. 6) Signoff Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92876|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 92893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92893&action=edit Bug 23354: (follow-up) Responses to feedback This patch impliments a number of refinements requested after the first round of feedback from the sponsors. 1) Fix padding on pay page 2) Switch 'items to add' from right to left on the page 3) Fix editable columns on pay page 4) Add explanitory text to pay page Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92878|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 92895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92895&action=edit Bug 23354: Add tests for Koha::Charges::Sales Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Tomás Cohen Arazi from comment #28)

The feature works, and the code is pretty clean. I have a few remarks to be considered:

- We should really have a separate table and stop using MANUAL_INV. It feels really dirty to have a note field contain a decimal value to be used as a number. To start with. I think we agree on this, and there's even work from Josef that would do it.

Totally agree here.. I was taking the pragmatic approach of not letting that work hold this up as we already have the MANUAL_INV code in place.. I intend to switch to our own table as a further bug down the line as we have more sponsorship in the pipeline for adding features which would require that distinction.

- Things look misaligned to me (hidpi laptop).

Did you run the yarn build? I've tried to fix alignment once already, but perhaps there are some bits still needing a little work.

- 'Collected from patron' should reuse some patron searching things already exist in the codebase. Thinking of the dialog to pick a guarantor.

Not sure what you mean here? The 'Collected from patron' input is meant to be a monetary value. (Though I do also like the idea of enhancing the screen to allow a patron to be optionally linked to the transaction)

- Currency symbol is the pound one, no matter what the system is configured to use.

Oops.. I'll post a followup for that now.

- 'Click on the item cost' maybe instead of 'Click on the item'.

Good catch.

- Are you planning on having an inventory of things to sell? I think the use of authorised values is very limited, besides my criticism. I expect librarians wanting to just scan the barcode and get the price on the screen.

I very much do want to add such functionality, including things like barcodes, tax rates etc.. but I see that as part of a bigger piece to migrate MANUAL_INC outside of authorized values. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92890|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93116&action=edit Bug 23354: Add a Point Of Sale 'pay' screen This patch adds a new Point Of Sale module to Koha's staff client front page. The module button leads directly to a 'Pay' page giving the staff user the ability to record anonymous payments for items that would not normally require a patron to be registered at the library. Test plan: 1) Enable `UseCashRegisters` via the system preferences. 2) Ensure your user has the 'manage_cash_registers' permission. 3) Add a cash register for your current branch. 4) Add at least one 'MANUAL_INV' authorized value. 5) Navigate to the new 'POS' pay page via the main menu. 6) Add an item to the 'sale' by clicking 'add' from the right side of the screen. 7) Note that said item was added to the table of items this sale on the left. 8) At this point you should be able to 'click to edit' the quantity or price of the item in the table on the left. 9) Enter an amount greater than the price of the item into the 'amount collected from patron' box. 10) Click 'Confirm' 11) Varify that the same change to give modal from the paycollect pages appears here. 12) Click 'Confirm' 13) Payment will have been recorded (check the database) and you will be back at a fresh 'Pay' page ready for the next transaction. 14) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92892|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93118&action=edit Bug 23354: Add ability to remove items This patch adds the ability to remove items from a transactions on the new Point of Sale pay page. Test plan: 1) Populate a transaction with at least one item. 2) Note the new button to 'Remove item' on the items table. 3) Click the button and confirm the item is removed 4) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92894|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93120&action=edit Bug 23354: Add permissions Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93122&action=edit Bug 23354: (follow-up) Add till icon -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93124&action=edit Bug 23354: (follow-up) Use 'format_price' for totals Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23049 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93116|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93465&action=edit Bug 23354: Add a Point Of Sale 'pay' screen This patch adds a new Point Of Sale module to Koha's staff client front page. The module button leads directly to a 'Pay' page giving the staff user the ability to record anonymous payments for items that would not normally require a patron to be registered at the library. Test plan: 1) Enable `UseCashRegisters` via the system preferences. 2) Ensure your user has the 'manage_cash_registers' permission. 3) Add a cash register for your current branch. 4) Add at least one 'MANUAL_INV' authorized value. 5) Navigate to the new 'POS' pay page via the main menu. 6) Add an item to the 'sale' by clicking 'add' from the right side of the screen. 7) Note that said item was added to the table of items this sale on the left. 8) At this point you should be able to 'click to edit' the quantity or price of the item in the table on the left. 9) Enter an amount greater than the price of the item into the 'amount collected from patron' box. 10) Click 'Confirm' 11) Varify that the same change to give modal from the paycollect pages appears here. 12) Click 'Confirm' 13) Payment will have been recorded (check the database) and you will be back at a fresh 'Pay' page ready for the next transaction. 14) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93118|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93467&action=edit Bug 23354: Add ability to remove items This patch adds the ability to remove items from a transactions on the new Point of Sale pay page. Test plan: 1) Populate a transaction with at least one item. 2) Note the new button to 'Remove item' on the items table. 3) Click the button and confirm the item is removed 4) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93120|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93469&action=edit Bug 23354: Add permissions Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93122|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93471&action=edit Bug 23354: (follow-up) Add till icon -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93124|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93473&action=edit Bug 23354: (follow-up) Use 'format_price' for totals Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93466|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93605&action=edit Bug 23354: Add receipting to Pay page This patch adds receipt printing to the new Point of Sale pay page. Test plan: 1) Apply patch and run database update 2) Enable automatic receipt printing via the `` system preference. 3) Make a payment for an item via the new POS pay page. 4) Note that a receipt printing dialogue is shown automatically after payment. 5) Note that a new notice is available under tools where you can alter the content of the receipt. 6) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93468|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93607&action=edit Bug 23354: (follow-up) Responses to feedback This patch impliments a number of refinements requested after the first round of feedback from the sponsors. 1) Fix padding on pay page 2) Switch 'items to add' from right to left on the page 3) Fix editable columns on pay page 4) Add explanitory text to pay page Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93470|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93609&action=edit Bug 23354: Add tests for Koha::Charges::Sales Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93473|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93611&action=edit Bug 23354: (follow-up) Use 'format_price' for totals Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93471|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23049 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23049 |23805 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 [Bug 23805] Add a dedicated credit_types table -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93604|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94689&action=edit Bug 23354: Add a Point Of Sale 'pay' screen This patch adds a new Point Of Sale module to Koha's staff client front page. The module button leads directly to a 'Pay' page giving the staff user the ability to record anonymous payments for items that would not normally require a patron to be registered at the library. Test plan: 1) Enable `UseCashRegisters` via the system preferences. 2) Ensure your user has the 'manage_cash_registers' permission. 3) Add a cash register for your current branch. 4) Add at least one 'MANUAL_INV' authorized value. 5) Navigate to the new 'POS' pay page via the main menu. 6) Add an item to the 'sale' by clicking 'add' from the right side of the screen. 7) Note that said item was added to the table of items this sale on the left. 8) At this point you should be able to 'click to edit' the quantity or price of the item in the table on the left. 9) Enter an amount greater than the price of the item into the 'amount collected from patron' box. 10) Click 'Confirm' 11) Varify that the same change to give modal from the paycollect pages appears here. 12) Click 'Confirm' 13) Payment will have been recorded (check the database) and you will be back at a fresh 'Pay' page ready for the next transaction. 14) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93606|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94691&action=edit Bug 23354: Add ability to remove items This patch adds the ability to remove items from a transactions on the new Point of Sale pay page. Test plan: 1) Populate a transaction with at least one item. 2) Note the new button to 'Remove item' on the items table. 3) Click the button and confirm the item is removed 4) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93608|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94693&action=edit Bug 23354: Add permissions Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93610|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94695&action=edit Bug 23354: (follow-up) Input type on jEditable Update the jEditable plugin to a maintained version and use the new 'number' type to enable increment arrows on click and remap onblur event to submit. Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93612|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94697&action=edit Bug 23354: Add Icon for POS system -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #69 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94699&action=edit Bug 23354: (follow-up) Make display of debit types configurable This patch adds a the ability to define where a debit type will be available as a option for use. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23636 | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23805 |23442 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 [Bug 23442] Add a 'refund' process to accounts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 [Bug 23805] Add a dedicated credit_types table -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94690|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94692|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94694|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94696|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94698|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #70 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 95678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95678&action=edit Bug 23354: Add a Point Of Sale 'pay' screen This patch adds a new Point Of Sale module to Koha's staff client front page. The module button leads directly to a 'Pay' page giving the staff user the ability to record anonymous payments for items that would not normally require a patron to be registered at the library. Test plan: 1) Enable `UseCashRegisters` via the system preferences. 2) Ensure your user has the 'manage_cash_registers' permission. 3) Add a cash register for your current branch. 4) Add at least one 'MANUAL_INV' authorized value. 5) Navigate to the new 'POS' pay page via the main menu. 6) Add an item to the 'sale' by clicking 'add' from the right side of the screen. 7) Note that said item was added to the table of items this sale on the left. 8) At this point you should be able to 'click to edit' the quantity or price of the item in the table on the left. 9) Enter an amount greater than the price of the item into the 'amount collected from patron' box. 10) Click 'Confirm' 11) Varify that the same change to give modal from the paycollect pages appears here. 12) Click 'Confirm' 13) Payment will have been recorded (check the database) and you will be back at a fresh 'Pay' page ready for the next transaction. 14) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #72 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 95680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95680&action=edit Bug 23354: Add ability to remove items This patch adds the ability to remove items from a transactions on the new Point of Sale pay page. Test plan: 1) Populate a transaction with at least one item. 2) Note the new button to 'Remove item' on the items table. 3) Click the button and confirm the item is removed 4) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #74 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 95682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95682&action=edit Bug 23354: Add permissions Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #76 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 95684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95684&action=edit Bug 23354: (follow-up) Input type on jEditable Update the jEditable plugin to a maintained version and use the new 'number' type to enable increment arrows on click and remap onblur event to submit. Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #78 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 95686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95686&action=edit Bug 23354: Add Icon for POS system -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #80 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 95688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95688&action=edit Bug 23354: (follow-up) Make display of debit types configurable This patch adds a the ability to define where a debit type will be available as a option for use. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #82 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 95690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95690&action=edit Bug 23354: (follow-up) Update for bugs 23049 and 23805 Remove all mentions of accounttype and replace with debit_type_code and credit_type_code as appropriate. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #84 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 95692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95692&action=edit Bug 23354: Format price on item add -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95678|0 |1 is obsolete| | Attachment #95679|0 |1 is obsolete| | Attachment #95680|0 |1 is obsolete| | Attachment #95681|0 |1 is obsolete| | Attachment #95682|0 |1 is obsolete| | Attachment #95683|0 |1 is obsolete| | Attachment #95684|0 |1 is obsolete| | Attachment #95685|0 |1 is obsolete| | Attachment #95686|0 |1 is obsolete| | Attachment #95687|0 |1 is obsolete| | Attachment #95688|0 |1 is obsolete| | Attachment #95689|0 |1 is obsolete| | Attachment #95690|0 |1 is obsolete| | Attachment #95691|0 |1 is obsolete| | Attachment #95692|0 |1 is obsolete| | Attachment #95693|0 |1 is obsolete| | --- Comment #86 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 97013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97013&action=edit Bug 23354: Add a Point Of Sale 'pay' screen This patch adds a new Point Of Sale module to Koha's staff client front page. The module button leads directly to a 'Pay' page giving the staff user the ability to record anonymous payments for items that would not normally require a patron to be registered at the library. Test plan: 1) Enable `UseCashRegisters` via the system preferences. 2) Ensure your user has the 'manage_cash_registers' permission. 3) Add a cash register for your current branch. 4) Add at least one 'MANUAL_INV' authorized value. 5) Navigate to the new 'POS' pay page via the main menu. 6) Add an item to the 'sale' by clicking 'add' from the right side of the screen. 7) Note that said item was added to the table of items this sale on the left. 8) At this point you should be able to 'click to edit' the quantity or price of the item in the table on the left. 9) Enter an amount greater than the price of the item into the 'amount collected from patron' box. 10) Click 'Confirm' 11) Varify that the same change to give modal from the paycollect pages appears here. 12) Click 'Confirm' 13) Payment will have been recorded (check the database) and you will be back at a fresh 'Pay' page ready for the next transaction. 14) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #88 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 97015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97015&action=edit Bug 23354: Add receipting to Pay page This patch adds receipt printing to the new Point of Sale pay page. Test plan: 1) Apply patch and run database update 2) Enable automatic receipt printing via the `` system preference. 3) Make a payment for an item via the new POS pay page. 4) Note that a receipt printing dialogue is shown automatically after payment. 5) Note that a new notice is available under tools where you can alter the content of the receipt. 6) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #90 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 97017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97017&action=edit Bug 23354: (follow-up) Responses to feedback This patch impliments a number of refinements requested after the first round of feedback from the sponsors. 1) Fix padding on pay page 2) Switch 'items to add' from right to left on the page 3) Fix editable columns on pay page 4) Add explanitory text to pay page Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #92 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 97019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97019&action=edit Bug 23354: Add tests for Koha::Charges::Sales Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #94 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 97021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97021&action=edit Bug 23354: (follow-up) Use 'format_price' for totals Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #96 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 97023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97023&action=edit Bug 23354: Update to account for bug 23049 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #98 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 97025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97025&action=edit Bug 23354: (follow-up) Ensure 'CASH' payment type is present Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #100 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 97027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97027&action=edit Bug 23354: (follow-up) Fix for sending code instead of description Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #102 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 97029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97029&action=edit Bug 23354: Prevent negatives from being entered Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #103 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 97169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97169&action=edit Bug 23354: (QA follow-up) Mark boolean columns in schema -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #106 from Josef Moravec <josef.moravec@gmail.com> --- Hi Martin, looks good, I added to little follow-ups and spotted the problem in test (see my previous comment) I have only one concern about printing receipt: I would like to see ability to print receipt manually (maybe using modal which is implemented to confirm change return). With current patches it is possible to print receipt only if automatic printing is enabled. But it also enables automatic printing in patrons accounting. I do think that there should be possibility to print receipt from POS manually too. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #108 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for taking a look and the followups Josef :) Annoyed at myself for missing the filters.. this patchset was initially created long enough ago that they were not required... I aught to have updated it though by now :( As for the display issues, did you run the yarn build step? (I may have forgotten to include it in the test plan :( ). Finally, the reciept printing.. I'm not sure I can print it from the change modal (that doesn't always display depending on whether you actually need to receive change or not and also the transaction hasn't yet taken place at that point so we don't have any data to refer to. I'll try to come up with an alternative though, as I agree it's not great having it only tied to the preference as it stands (You do however get the ability to print receipts in the next patch in the series which adds a 'cashup' page of historical transactions). Followups incoming as I fix the receipting UX. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #110 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97189&action=edit Bug 23354: (QA follow-up) Rename test file Note to RM: Squash on push -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97015|0 |1 is obsolete| | --- Comment #112 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97201&action=edit Bug 23354: Add receipting to Pay page This patch adds receipt printing to the new Point of Sale pay page. Test plan: 1) Apply patch and run database update 2) Enable automatic receipt printing via the `` system preference. 3) Make a payment for an item via the new POS pay page. 4) Note that a receipt printing dialogue is shown automatically after payment. 5) Note that a new notice is available under tools where you can alter the content of the receipt. 6) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97017|0 |1 is obsolete| | --- Comment #114 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97203&action=edit Bug 23354: (follow-up) Responses to feedback This patch impliments a number of refinements requested after the first round of feedback from the sponsors. 1) Fix padding on pay page 2) Switch 'items to add' from right to left on the page 3) Fix editable columns on pay page 4) Add explanitory text to pay page Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97019|0 |1 is obsolete| | --- Comment #116 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97205&action=edit Bug 23354: Add tests for Koha::Charges::Sales Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97021|0 |1 is obsolete| | --- Comment #118 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97207&action=edit Bug 23354: (follow-up) Use 'format_price' for totals Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97023|0 |1 is obsolete| | --- Comment #120 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97209&action=edit Bug 23354: Update to account for bug 23049 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97025|0 |1 is obsolete| | --- Comment #122 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97211&action=edit Bug 23354: (follow-up) Ensure 'CASH' payment type is present Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97027|0 |1 is obsolete| | --- Comment #124 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97213&action=edit Bug 23354: (follow-up) Fix for sending code instead of description Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97029|0 |1 is obsolete| | --- Comment #126 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97215&action=edit Bug 23354: Prevent negatives from being entered Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97170|0 |1 is obsolete| | --- Comment #128 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97217&action=edit Bug 23354: (QA follow-up) Add missing filters, remove tab chars -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97189|0 |1 is obsolete| | --- Comment #130 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97219&action=edit Bug 23354: (QA follow-up) Rename test file Note to RM: Squash on push -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #133 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 97272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97272&action=edit Bug 23354: Add receipting to Pay page This patch adds receipt printing to the new Point of Sale pay page. Test plan: 1) Apply patch and run database update 2) Enable automatic receipt printing via the `` system preference. 3) Make a payment for an item via the new POS pay page. 4) Note that a receipt printing dialogue is shown automatically after payment. 5) Note that a new notice is available under tools where you can alter the content of the receipt. 6) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #135 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 97274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97274&action=edit Bug 23354: (follow-up) Responses to feedback This patch impliments a number of refinements requested after the first round of feedback from the sponsors. 1) Fix padding on pay page 2) Switch 'items to add' from right to left on the page 3) Fix editable columns on pay page 4) Add explanitory text to pay page Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #137 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 97276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97276&action=edit Bug 23354: Add tests for Koha::Charges::Sales Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #139 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 97278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97278&action=edit Bug 23354: (follow-up) Use 'format_price' for totals Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #141 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 97280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97280&action=edit Bug 23354: Update to account for bug 23049 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #143 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 97282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97282&action=edit Bug 23354: (follow-up) Ensure 'CASH' payment type is present Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #145 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 97284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97284&action=edit Bug 23354: (follow-up) Fix for sending code instead of description Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #147 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 97286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97286&action=edit Bug 23354: Prevent negatives from being entered Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #149 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 97288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97288&action=edit Bug 23354: (QA follow-up) Add missing filters, remove tab chars Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #151 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 97290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97290&action=edit Bug 23354: (QA follow-up) Rename test file Note to RM: Squash on push Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #153 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 97292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97292&action=edit Bug 23354: (QA follow-up) Fix spelling in templates Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #156 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Notice templates are missing in .sql files xt/sample_notices.t .. 1/? # Failed test 'No sample notice to add' # at xt/sample_notices.t line 83. # Sample notices to add in fr-FR/1-Obligatoire/sample_notices.sql: RECEIPT # Failed test 'No sample notice to add' # at xt/sample_notices.t line 83. # Sample notices to add in fr-CA/obligatoire/sample_notices.sql: RECEIPT # Failed test 'No sample notice to add' # at xt/sample_notices.t line 83. # Sample notices to add in de-DE/mandatory/sample_notices.sql: RECEIPT # Failed test 'No sample notice to add' # at xt/sample_notices.t line 83. # Sample notices to add in es-ES/mandatory/sample_notices.sql: RECEIPT # Failed test 'No sample notice to add' # at xt/sample_notices.t line 83. # Sample notices to add in it-IT/necessari/notices.sql: RECEIPT # Failed test 'No sample notice to add' # at xt/sample_notices.t line 83. # Sample notices to add in nb-NO/1-Obligatorisk/sample_notices.sql: RECEIPT # Failed test 'No sample notice to add' # at xt/sample_notices.t line 83. # Sample notices to add in pl-PL/mandatory/sample_notices.sql: RECEIPT # Failed test 'No sample notice to add' # at xt/sample_notices.t line 83. # Sample notices to add in ru-RU/mandatory/sample_notices.sql: RECEIPT # Failed test 'No sample notice to add' # at xt/sample_notices.t line 83. # Sample notices to add in uk-UA/mandatory/sample_notices.sql: RECEIPT # Looks like you failed 9 tests of 38. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #157 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- account_debit_types.can_be_added_manually - `can_be_added_manually` tinyint(4) NOT NULL DEFAULT 1, Is that expected? Test is failing because of that: t/db_dependent/Koha/Account/DebitType.t .. DBIx::Class::Row::store_column(): No such column 'can_be_added_manually' on Koha::Schema::Result::AccountDebitType at /kohadevbox/koha/Koha/Object.pm line 77 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #159 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Two followups pushed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |joy@bywatersolutions.com --- Comment #160 from Joy Nelson <joy@bywatersolutions.com> --- Not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24477 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477 [Bug 24477] No permissions check for POS feature -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24479 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479 [Bug 24479] New POS doesn't follow CurrencyFormat -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_target | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #163 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 97725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97725&action=edit Bug 23354: (QA follow-up) Add takepayment permission for new installs -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24481 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481 [Bug 24481] Incorrect permission in admin/cash_registers.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24491 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24491 [Bug 24491] Add filters to debit types interface -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|23355 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 [Bug 23355] Add 'cashup' process to the accounts system -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24525 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525 [Bug 24525] Hide SIP payment types from the Point of Sale page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Component|Staff Client |Fines and fees -- You are receiving this mail because: You are watching all bug changes.