[Bug 41956] New: Hold group/hyperhold modals should show hold_group_id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 Bug ID: 41956 Summary: Hold group/hyperhold modals should show hold_group_id Initiative type: --- Sponsorship --- status: Product: Koha Version: 25.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: sbrown@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: andrew@bywatersolutions.com, gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com It would be helpful if hyperholds' hold_group_id were more readily visible for staff who need to identify it in order to search logs/troubleshoot. Places it would help to have it visible: In the Holds tab of patron accounts in the staff interface (circulation.pl and moremember.pl), the modal generated by clicking on the number in the 'Hold group' column to see other titles/items in the hyperhold/hold group In a bib's hold tab (request.pl), the modal generated by clicking on the '(part of a hold group)' link in the hold's Details column -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41957 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov Depends on| |15516 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15516 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 [Bug 15516] Allow to place a hold on first available item from a group of titles -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Hi Sarah and Andrew, I understand the requirement but I believe implementing this whilst keeping the 'visual_group_id' implementation would cause confusion (or be redundant). The 'Visual_group_id' was implemented and designed to make it easier for staff members to identify which holds are part of which group, without showing an ever increasing database auto-increment number. My suggestion of implementation: - Abandon the visual_group_id implementation and always show the 'real' database Id hold_group_id - Add the hold_group_id to other areas where it is not currently shown (as per Sara's comment). Please let me know what you think. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Pedro Amorim from comment #1)
My suggestion of implementation: - Abandon the visual_group_id implementation and always show the 'real' database Id hold_group_id - Add the hold_group_id to other areas where it is not currently shown (as per Sara's comment).
This seems like the best course of action, yes. Thank you! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15516 |41983 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 [Bug 15516] Allow to place a hold on first available item from a group of titles https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41983 [Bug 41983] Holds Queue should show when holds are part of a group -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 --- Comment #3 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 198077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198077&action=edit Bug 41956: Remove visual_hold_group_id Patch from commit f81ccb8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 --- Comment #4 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 198078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198078&action=edit Bug 41956: Display hold_group_id Test plan: 1) Enable DisplayAddHoldGroups sys pref 2) Place two title-level holds for the same patron on two different biblios. 3) Group them via the patron's holds page. Note the hold_group_id shown in the table and the URL when you click through to the group page (e.g. hold_group_id=42). 4) Create a second hold group for the same patron with two more holds. Confirm the hold_group_id is shown instead of the previous visual_hold_group_id. 5) Go to Circulation > Holds to pull (/cgi-bin/koha/circ/pendingreserves.pl). Confirm each grouped hold shows 'Hold group 42' as a clickable link, not the old 'part of a hold group' text. 6) Go to Circulation > Holds queue (/cgi-bin/koha/circ/view_holdsqueue.pl). Confirm the same — 'Hold group 42' link visible beneath the title. 7) Log in to the OPAC as that patron, go to 'Your summary' > 'Holds' tab. Confirm the 'Hold group' column shows 42. 8) Cancel one hold from the group. Confirm the group still appears on the patron's 'Holds' tab (one hold remains). 9) Cancel the last hold in the group. Confirm the no holds of the group and the group no longer appear on the patron's 'Holds' tab. Check holds history on the Staff UI: (/cgi-bin/koha/members/holdshistory.pl?borrowernumber=NNN) — both cancelled holds should still show 42 in the 'Hold group ID' column. Run tests: prove t/db_dependent/Reserves/HoldGroup.t prove t/db_dependent/Koha/Hold.t prove t/db_dependent/Koha/Patron.t prove t/db_dependent/api/v1/patrons_hold_groups.t prove t/db_dependent/api/v1/holds.t prove t/db_dependent/api/v1/patrons_holds.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|25.11 |Main Severity|enhancement |minor Summary|Hold group/hyperhold modals |Show hold_group_id in |should show hold_group_id |patron holds table rather | |than visual_hold_group_id -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198077|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198078|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198107&action=edit Bug 41956: Remove visual_hold_group_id Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198108&action=edit Bug 41956: Display hold_group_id Test plan: 1) Enable DisplayAddHoldGroups sys pref 2) Place two title-level holds for the same patron on two different biblios. 3) Group them via the patron's holds page. Note the hold_group_id shown in the table and the URL when you click through to the group page (e.g. hold_group_id=42). 4) Create a second hold group for the same patron with two more holds. Confirm the hold_group_id is shown instead of the previous visual_hold_group_id. 5) Go to Circulation > Holds to pull (/cgi-bin/koha/circ/pendingreserves.pl). Confirm each grouped hold shows 'Hold group 42' as a clickable link, not the old 'part of a hold group' text. 6) Go to Circulation > Holds queue (/cgi-bin/koha/circ/view_holdsqueue.pl). Confirm the same — 'Hold group 42' link visible beneath the title. 7) Log in to the OPAC as that patron, go to 'Your summary' > 'Holds' tab. Confirm the 'Hold group' column shows 42. 8) Cancel one hold from the group. Confirm the group still appears on the patron's 'Holds' tab (one hold remains). 9) Cancel the last hold in the group. Confirm the no holds of the group and the group no longer appear on the patron's 'Holds' tab. Check holds history on the Staff UI: (/cgi-bin/koha/members/holdshistory.pl?borrowernumber=NNN) — both cancelled holds should still show 42 in the 'Hold group ID' column. Run tests: prove t/db_dependent/Reserves/HoldGroup.t prove t/db_dependent/Koha/Hold.t prove t/db_dependent/Koha/Patron.t prove t/db_dependent/api/v1/patrons_hold_groups.t prove t/db_dependent/api/v1/holds.t prove t/db_dependent/api/v1/patrons_holds.t Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198107|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198108|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198109&action=edit Bug 41956: Remove visual_hold_group_id Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198110&action=edit Bug 41956: Display hold_group_id Test plan: 1) Enable DisplayAddHoldGroups sys pref 2) Place two title-level holds for the same patron on two different biblios. 3) Group them via the patron's holds page. Note the hold_group_id shown in the table and the URL when you click through to the group page (e.g. hold_group_id=42). 4) Create a second hold group for the same patron with two more holds. Confirm the hold_group_id is shown instead of the previous visual_hold_group_id. 5) Go to Circulation > Holds to pull (/cgi-bin/koha/circ/pendingreserves.pl). Confirm each grouped hold shows 'Hold group 42' as a clickable link, not the old 'part of a hold group' text. 6) Go to Circulation > Holds queue (/cgi-bin/koha/circ/view_holdsqueue.pl). Confirm the same — 'Hold group 42' link visible beneath the title. 7) Log in to the OPAC as that patron, go to 'Your summary' > 'Holds' tab. Confirm the 'Hold group' column shows 42. 8) Cancel one hold from the group. Confirm the group still appears on the patron's 'Holds' tab (one hold remains). 9) Cancel the last hold in the group. Confirm the no holds of the group and the group no longer appear on the patron's 'Holds' tab. Check holds history on the Staff UI: (/cgi-bin/koha/members/holdshistory.pl?borrowernumber=NNN) — both cancelled holds should still show 42 in the 'Hold group ID' column. Run tests: prove t/db_dependent/Reserves/HoldGroup.t prove t/db_dependent/Koha/Hold.t prove t/db_dependent/Koha/Patron.t prove t/db_dependent/api/v1/patrons_hold_groups.t prove t/db_dependent/api/v1/holds.t prove t/db_dependent/api/v1/patrons_holds.t Signed-off-by: Bob Bennhoff <bbennhoff@clicweb.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Passed QA |BLOCKED --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- BLOCKED by Bug 41983 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- DEV atomic update /usr/share/koha/installer/data/mysql/atomicupdate/bug_41956.pl [10:52:48]: Bug d41956 - Remove visual_hold_group_id column from hold_groups Removed column 'visual_hold_group_id' from hold_groups File is not moved to db_revs ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #11)
DEV atomic update /usr/share/koha/installer/data/mysql/atomicupdate/bug_41956.pl [10:52:48]: Bug d41956 - Remove visual_hold_group_id column from hold_groups Removed column 'visual_hold_group_id' from hold_groups
File is not moved to db_revs !
Oops, sorry about that. It is moved to db_revs now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #13 from David Cook <dcook@prosentient.com.au> --- It looks like 1 place was missed: svc/holds: visual_hold_group_id => $h->hold_group ? $h->hold_group->visual_hold_group_id : q{}, In main, holds can't be grouped together now. It just generates a 500 error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42570 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 --- Comment #14 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #13)
It looks like 1 place was missed:
svc/holds: visual_hold_group_id => $h->hold_group ? $h->hold_group->visual_hold_group_id : q{},
In main, holds can't be grouped together now. It just generates a 500 error.
Or rather bug 37762 re-introduced it. Probably just a rebase error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37762 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 --- Comment #15 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #14)
(In reply to David Cook from comment #13)
It looks like 1 place was missed:
svc/holds: visual_hold_group_id => $h->hold_group ? $h->hold_group->visual_hold_group_id : q{},
In main, holds can't be grouped together now. It just generates a 500 error.
Or rather bug 37762 re-introduced it. Probably just a rebase error.
Sorry folks. I should've said that I added a patch for the issue to bug 37762 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #16 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- + [% IF Koha.Preference('DisplayAddHoldGroups') %] + <th data-colname="hold_group_id">Hold group ID</th> + [% END %] We must stop doing this, see bug 42332. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org