https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- For testing purposes in koha-testing-docker I wrote this. Definitely DO NOT add this to a production server: $('body').append('<button id="makeSuggestions">Make 100 suggestions</button>'); $('#makeSuggestions').click( function() { for (let i = 0; i < 100; i++) { let branches = ["CPL", "FFL","FPL","FRL","IPT","LPL","MPL","PVL","RPL","SPL","TPL","UPL"]; let random_branch = Math.floor(Math.random() * branches.length); let statuses = ["ASKED", "ACCEPTED", "REJECTED"]; let random_status = Math.floor(Math.random() * statuses.length); let random_title = (Math.random() + 1).toString(36).substring(2); $.ajax({ url: '/api/v1/suggestions', method: 'POST', data: JSON.stringify({ "title": random_title, "item_type": "BK", "suggested_by": Math.floor(Math.random() * 51), "suggestion_date": "2023-04-06", "timestamp": "2023-04-06T17:59:26+00:00", "managed_by": 51, "library_id": branches[random_branch], "status": statuses[random_status], }), contentType: 'application/json', success: function(result) { console.log('suggestion added'); }, }); } }); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Felicity Brown <felicity.brown@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |felicity.brown@montgomeryco | |untymd.gov --- Comment #3 from Felicity Brown <felicity.brown@montgomerycountymd.gov> --- Would it be possible to have batch changes made by queuing them, like we have for batch item modification? So we could continue to work on other purchase suggestions while the last set of edits are updating? I find it grinds particularly badly when I'm trying to update several records from a page to assign a manager to them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Joe Askins <jaskins@faylib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jaskins@faylib.org --- Comment #5 from Joe Askins <jaskins@faylib.org> --- Fayetteville Public Library cosigning the need for this fix -- the slow load times are making it very difficult to work through these purchase suggestions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cj.lynce@westlakelibrary.or | |g --- Comment #7 from CJ Lynce <cj.lynce@westlakelibrary.org> --- We are experiencing this as well, with just over 400 items between the Accepted, Checked, and Rejected tabs. The pages can take 10+ seconds, and at times even longer to load. We also suspect this is related to an issue that, after modifying a suggestion, the page returns to the suggestions list, but never fully loads the table of suggestions (We cannot conclusively prove this is related at this point, but are trying to narrow this down) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Looks like Bug 27183 is a duplicate of this one. We load all the suggestions each time visiting the page. As Michal pointed out, API pagination can solve this. Not easy though. :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The move to REST is the ultimate fix, but could we improve performance otherwise too? How are we doing with indexes on the table and the like, are there some easy improvements we could make here? If not, I think marking as duplicate would be the next logical step. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Suggestions.pl with several |Use REST API for |hundred items causes a slow |suggestions tables |loading screen | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Juliet Heltibridle <jheltibridle@rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jheltibridle@rcplib.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 lthorrat@cuyahogalibrary.org <lthorrat@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lthorrat@cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 --- Comment #13 from Candice Hope <candiceh@payson.org> --- I second that Christopher! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 --- Comment #15 from Teresa Dahlgren <tdahlgren@waterloopubliclibrary.org> --- I third that! It takes FOREVER to load and edit these! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 --- Comment #17 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182147&action=edit Bug 33430: Update API specs to include required embeds -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 --- Comment #19 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182149&action=edit Bug 33430: Enable datatables for suggestion tabs Test plan: 1) Either add loads of suggestions to your KTD or use the script in the data script patch uploaded to the bug 2) Navigate to Acquisitions > Suggestions 3) Depending on how many suggestions you have loaded (the script does 2000), the page will load very slowly 4) Apply patches 5) yarn build && restart_all 6) Hard refresh the page, the page should load much faster and the first tab should load a paginated datatable 7) Click into another tab, the tab should also load a paginated datatable 8) Click back into the first tab, the original table should persist and should not reload 9) Use the edit tools at the bottom of the page, they should work as expected 10) Click on the links in various table cells, they should redirect as expected 11) Use the actions buttons in the far right column, then should work as expected -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182149|0 |1 is obsolete| | --- Comment #21 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182161&action=edit Bug 33430: Enable datatables for suggestion tabs Test plan: 1) Either add loads of suggestions to your KTD or use the script in the data script patch uploaded to the bug 2) Navigate to Acquisitions > Suggestions 3) Depending on how many suggestions you have loaded (the script does 2000), the page will load very slowly 4) Apply patches 5) yarn build && restart_all 6) Hard refresh the page, the page should load much faster and the first tab should load a paginated datatable 7) Click into another tab, the tab should also load a paginated datatable 8) Click back into the first tab, the original table should persist and should not reload 9) Use the edit tools at the bottom of the page, they should work as expected 10) Click on the links in various table cells, they should redirect as expected 11) Use the actions buttons in the far right column, then should work as expected -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182146|0 |1 is obsolete| | --- Comment #22 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 182196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182196&action=edit Bug 33430: Add strings_map method This patch adds a strings_map method to allow the API to return the required authorised values needed for table displays Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182148|0 |1 is obsolete| | --- Comment #24 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 182198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182198&action=edit Bug 33430: Pass search parameters to the template This patch removes the existing process intensive searches and moves the search logic to a single group query that returns the values that will be the counts in the tabs. It then formats the parameters for each type and passes them to the template for the datatables ajax requests Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182161|0 |1 is obsolete| | --- Comment #26 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 182200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182200&action=edit Bug 33430: Enable datatables for suggestion tabs Test plan: 1) Either add loads of suggestions to your KTD or use the script in the data script patch uploaded to the bug 2) Navigate to Acquisitions > Suggestions 3) Depending on how many suggestions you have loaded (the script does 2000), the page will load very slowly 4) Apply patches 5) yarn build && restart_all 6) Hard refresh the page, the page should load much faster and the first tab should load a paginated datatable 7) Click into another tab, the tab should also load a paginated datatable 8) Click back into the first tab, the original table should persist and should not reload 9) Use the edit tools at the bottom of the page, they should work as expected 10) Click on the links in various table cells, they should redirect as expected 11) Use the actions buttons in the far right column, then should work as expected Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182196|0 |1 is obsolete| | --- Comment #29 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 182203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182203&action=edit Bug 33430: Add strings_map method This patch adds a strings_map method to allow the API to return the required authorised values needed for table displays Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182198|0 |1 is obsolete| | --- Comment #31 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 182205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182205&action=edit Bug 33430: Pass search parameters to the template This patch removes the existing process intensive searches and moves the search logic to a single group query that returns the values that will be the counts in the tabs. It then formats the parameters for each type and passes them to the template for the datatables ajax requests Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182202|0 |1 is obsolete| | --- Comment #33 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 182207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182207&action=edit Bug 33430: DO NOT PUSH - data script Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Sponsored by: Montgomery County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182204|0 |1 is obsolete| | --- Comment #35 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 182209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182209&action=edit Bug 33430: Update API specs to include required embeds Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Sponsored by: Montgomery County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182206|0 |1 is obsolete| | --- Comment #37 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 182211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182211&action=edit Bug 33430: Enable datatables for suggestion tabs Test plan: 1) Either add loads of suggestions to your KTD or use the script in the data script patch uploaded to the bug 2) Navigate to Acquisitions > Suggestions 3) Depending on how many suggestions you have loaded (the script does 2000), the page will load very slowly 4) Apply patches 5) yarn build && restart_all 6) Hard refresh the page, the page should load much faster and the first tab should load a paginated datatable 7) Click into another tab, the tab should also load a paginated datatable 8) Click back into the first tab, the original table should persist and should not reload 9) Use the edit tools at the bottom of the page, they should work as expected 10) Click on the links in various table cells, they should redirect as expected 11) Use the actions buttons in the far right column, then should work as expected Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Sponsored by: Montgomery County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 --- Comment #38 from Lisette Scheer <lisette@bywatersolutions.com> --- Worked great, the only thing I noticed was that if you changed the page number and moved to a different tab, the page number was still changed. I believe this is a data tables bug not specific to this enhancement. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182208|0 |1 is obsolete| | --- Comment #40 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 182340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182340&action=edit Bug 33430: Add strings_map method This patch adds a strings_map method to allow the API to return the required authorised values needed for table displays Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: krimsonkharne <philip.orr@posteo.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182210|0 |1 is obsolete| | --- Comment #42 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 182342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182342&action=edit Bug 33430: Pass search parameters to the template This patch removes the existing process intensive searches and moves the search logic to a single group query that returns the values that will be the counts in the tabs. It then formats the parameters for each type and passes them to the template for the datatables ajax requests Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> Signed-off-by: krimsonkharne <philip.orr@posteo.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Status|Passed QA |Failed QA --- Comment #44 from Jonathan Druart <jonathan.druart@gmail.com> --- This is not working for me, I am getting 400 search, biblio, title="h" {"error":1,"error_code":"invalid_query"} -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182339|0 |1 is obsolete| | --- Comment #46 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182428&action=edit Bug 33430: DO NOT PUSH - data script -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182341|0 |1 is obsolete| | --- Comment #48 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182430&action=edit Bug 33430: Update API specs to include required embeds -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182343|0 |1 is obsolete| | --- Comment #50 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182432&action=edit Bug 33430: Enable datatables for suggestion tabs Test plan: 1) Either add loads of suggestions to your KTD or use the script in the data script patch uploaded to the bug 2) Navigate to Acquisitions > Suggestions 3) Depending on how many suggestions you have loaded (the script does 2000), the page will load very slowly 4) Apply patches 5) yarn build && restart_all 6) Hard refresh the page, the page should load much faster and the first tab should load a paginated datatable 7) Click into another tab, the tab should also load a paginated datatable 8) Click back into the first tab, the original table should persist and should not reload 9) Use the edit tools at the bottom of the page, they should work as expected 10) Click on the links in various table cells, they should redirect as expected 11) Use the actions buttons in the far right column, then should work as expected -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 --- Comment #52 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182434&action=edit Bug 33430: (follow-up) Fix the data filtering from the left menu -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 --- Comment #54 from Fridolin Somers <fridolin.somers@biblibre.com> --- Also : Create a suggestion from OPAC with only title Look at suggestions table in staff interface It crashes with : Uncaught TypeError: row.manager is null -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182429|0 |1 is obsolete| | --- Comment #57 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 182481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182481&action=edit Bug 33430: Add strings_map method This patch adds a strings_map method to allow the API to return the required authorised values needed for table displays Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182431|0 |1 is obsolete| | --- Comment #59 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 182483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182483&action=edit Bug 33430: Pass search parameters to the template This patch removes the existing process intensive searches and moves the search logic to a single group query that returns the values that will be the counts in the tabs. It then formats the parameters for each type and passes them to the template for the datatables ajax requests Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182433|0 |1 is obsolete| | --- Comment #61 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 182485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182485&action=edit Bug 33430: (follow-up) Restore sorting to table Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182478|0 |1 is obsolete| | --- Comment #63 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 182487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182487&action=edit Bug 33430: (follow-up) Handle undefined data in column renders Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182480|0 |1 is obsolete| | --- Comment #64 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 182493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182493&action=edit Bug 33430: DO NOT PUSH - data script Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182482|0 |1 is obsolete| | --- Comment #66 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 182495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182495&action=edit Bug 33430: Update API specs to include required embeds Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182484|0 |1 is obsolete| | --- Comment #68 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 182497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182497&action=edit Bug 33430: Enable datatables for suggestion tabs Test plan: 1) Either add loads of suggestions to your KTD or use the script in the data script patch uploaded to the bug 2) Navigate to Acquisitions > Suggestions 3) Depending on how many suggestions you have loaded (the script does 2000), the page will load very slowly 4) Apply patches 5) yarn build && restart_all 6) Hard refresh the page, the page should load much faster and the first tab should load a paginated datatable 7) Click into another tab, the tab should also load a paginated datatable 8) Click back into the first tab, the original table should persist and should not reload 9) Use the edit tools at the bottom of the page, they should work as expected 10) Click on the links in various table cells, they should redirect as expected 11) Use the actions buttons in the far right column, then should work as expected Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182486|0 |1 is obsolete| | --- Comment #70 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 182499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182499&action=edit Bug 33430: (follow-up) Fix the data filtering from the left menu Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #72 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) Terminology + description: last member to modify the suggestion + library: + type: + - object + - "null" + description: branch the suggestion belongs to last user/patron to... library the suggestion... I wanted to fix these in a follow-up, but then found a more severe issue: 2) Anonymous suggestions break things To test: AnonymousPatron = 2 AnonSuggestions = Allow Add a suggestion from the OPAC without being logged in. The table of suggestions won't load: Organize by: Status Tab: Pending Uncaught TypeError: row.suggester is null -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 --- Comment #74 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 3) Do dates sort correctly? I couldn't fully verify and I am not sure how the mark-up should like for datatables driven by API. I notice that before we had something like: <td data-order="2023-03-15" class="dt-type-date"> 15.03.2023 </td> Now we have just: <td>05.01.2025</td> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 --- Comment #75 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182577&action=edit Bug 33430: (follow-up) Fix API spec terminology -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 --- Comment #77 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- I've fixed points 1 and 2, as far as I can tell the dates are sorting correctly for point 3 as well. I created a range of suggestions with different dates and using the column sorting was correctly ordering the dates -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 --- Comment #79 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am tempted to promote this from Major to New feature for advertising. Thanks to everyone who helped to get this over the finish line with extra testing! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 --- Comment #80 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36155 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #82 from Fridolin Somers <fridolin.somers@biblibre.com> --- This is a big change, I prefer not impact 24.11.x LTS for stability -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Andrew Auld <andrew.auld@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |andrew.auld@openfifth.co.uk Status|Needs documenting |RESOLVED --- Comment #83 from Andrew Auld <andrew.auld@openfifth.co.uk> --- Architectural changes, no need for documentation. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41769 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41769 [Bug 41769] ", by" in suggestions is untranslatable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33430 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42471 -- You are receiving this mail because: You are watching all bug changes.