[Bug 35838] New: Use template wrapper for tabs: Curbside pickups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 Bug ID: 35838 Summary: Use template wrapper for tabs: Curbside pickups Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 32571 Continuing the work of Bug 32571, I would like to update the curbside pickups page in the staff client to use the new WRAPPER for tabs Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use template wrapper for |Use template wrapper for |tabs: Curbside pickups |tabs: Curbside pickups | |administration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 161143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161143&action=edit Bug 35838: Use template wrapper for tabs: Curbside pickups administration This patch updates the curbside pickups administration template so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and enable curbside pickups if necessary: Administration -> System preferences -> CurbsidePickup. - Go to Administration -> Curbside pickups. - Confirm that the tabs look correct and behave as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 Loïc <loic.vassaux-artur@epitech.eu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |loic.vassaux-artur@epitech. | |eu --- Comment #2 from Loïc <loic.vassaux-artur@epitech.eu> --- It works -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161143|0 |1 is obsolete| | --- Comment #3 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 161239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161239&action=edit Bug 35838: Use template wrapper for tabs: Curbside pickups administration This patch updates the curbside pickups administration template so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and enable curbside pickups if necessary: Administration -> System preferences -> CurbsidePickup. - Go to Administration -> Curbside pickups. - Confirm that the tabs look correct and behave as expected. Signed-off-by: Loïc Vassaux--Artur <loic.vassaux-artur@outlook.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161239|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 165264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165264&action=edit Bug 35838: Use template wrapper for tabs: Curbside pickups administration This patch updates the curbside pickups administration template so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and enable curbside pickups if necessary: Administration -> System preferences -> CurbsidePickup. - Go to Administration -> Curbside pickups. - Confirm that the tabs look correct and behave as expected. Signed-off-by: Loïc Vassaux--Artur <loic.vassaux-artur@outlook.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165264|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170341&action=edit Bug 35838: Use template wrapper for tabs: Curbside pickups administration This patch updates the curbside pickups administration template so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and enable curbside pickups if necessary: Administration -> System preferences -> CurbsidePickup. - Go to Administration -> Curbside pickups. - Confirm that the tabs look correct and behave as expected. Signed-off-by: Loïc Vassaux--Artur <loic.vassaux-artur@outlook.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170341|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170653&action=edit Bug 35838: Use template wrapper for tabs: Curbside pickups administration This patch updates the curbside pickups administration template so that it uses the new WRAPPER directive to build tabbed navigation. To test, apply the patch and enable curbside pickups if necessary: Administration -> System preferences -> CurbsidePickup. - Go to Administration -> Curbside pickups. - Confirm that the tabs look correct and behave as expected. Signed-off-by: Loïc Vassaux--Artur <loic.vassaux-artur@outlook.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 171022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171022&action=edit Bug 35838: Fix addition of new slots The "Add" button didn't add new slots. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37835 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37835 [Bug 37835] CurbSide pickup - Click on 'Add a new slot' button is not triggering any action -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucasmontoya@theke.io --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- *** Bug 37835 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed follow-up to main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Does this still need additional_work_needed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Owen Leonard from comment #11)
Does this still need additional_work_needed?
Nope, removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement makes release notes| |structural changes to the | |way the curbside pickups | |administration page is | |generated for more | |consistency and ease of | |upgrade to new Bootstrap | |versions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35838 Bug 35838 depends on bug 32571, which changed state. Bug 32571 Summary: Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org