[Bug 31960] New: Information on job detail view is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 Bug ID: 31960 Summary: Information on job detail view is misaligned Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 30952 Created attachment 142553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142553&action=edit Job detail for a staged MARC import Not sure if this applies to all different jobs, but it does to the stage MARC one. (see screneshot) The heading is floating to the right and the other information is too far on the left. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- It is likely happening with other jobs. The problem lines are these ones: <li><label for="job_data">Report: </label> [% IF job.status != 'new' %][% PROCESS 'report' %][% END %] </li> <li><label for="job_data">Detailed messages: </label> [% IF job.status != 'new' %][% PROCESS 'detail' %][% END %] </li> We are processing those blocks inside of a list element and those blocks contain a bunch of their own HTML, including h2 and h3. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142608&action=edit Bug 31960: Information on job detail view is misaligned This patch updates the structure of the background jobs template so that HTML processed in the report includes is well styled. The patch does this by breaking the report and detail includes out of the fieldset and putting them in a separate section. This patch also adds the page-section class to the table view of current and past background jobs. Note: The patch includes indentation changes, so please ignore whitespace when viewing the diff. To test, apply the patch and go to Administration -> Manage jobs. - The table of jobs (even if empty) should be contained in a page-section style white box. - Test various processes which trigger a backgroud job: - Batch item modification - Batch item deletion - Batch hold deletion - Batch record modification ... etc. - After each process has been started, view the details of the job. - The information about the job shold be displayed well, with separate sections for "Report" and "Detailed messages." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142608|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 142614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142614&action=edit Bug 31960: Information on job detail view is misaligned This patch updates the structure of the background jobs template so that HTML processed in the report includes is well styled. The patch does this by breaking the report and detail includes out of the fieldset and putting them in a separate section. This patch also adds the page-section class to the table view of current and past background jobs. Note: The patch includes indentation changes, so please ignore whitespace when viewing the diff. To test, apply the patch and go to Administration -> Manage jobs. - The table of jobs (even if empty) should be contained in a page-section style white box. - Test various processes which trigger a backgroud job: - Batch item modification - Batch item deletion - Batch hold deletion - Batch record modification ... etc. - After each process has been started, view the details of the job. - The information about the job shold be displayed well, with separate sections for "Report" and "Detailed messages." Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- "Report" is h2 and "Detailed messages: is h3, expected? https://snipboard.io/VYtawT.jpg As well as the : vs none? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am wondering the same as Jonathan actually. Also: Detailed Messages shows with nothing below. Could we maybe only display the block if there is something to display? I noticed this after staging an import. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142614|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142863&action=edit Bug 31960: Information on job detail view is misaligned This patch updates the structure of the background jobs template so that HTML processed in the report includes is well styled. The patch does this by breaking the report and detail includes out of the fieldset and putting them in a separate section. This patch also adds the page-section class to the table view of current and past background jobs. Note: The patch includes indentation changes, so please ignore whitespace when viewing the diff. To test, apply the patch and go to Administration -> Manage jobs. - The table of jobs (even if empty) should be contained in a page-section style white box. - Test various processes which trigger a backgroud job: - Batch item modification - Batch item deletion - Batch hold deletion - Batch record modification ... etc. - After each process has been started, view the details of the job. - The information about the job shold be displayed well, with separate sections for "Report" and "Detailed messages." Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142864&action=edit Bug 31960: (follow-up) Make headings match -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142863|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142891&action=edit Bug 31960: Information on job detail view is misaligned This patch updates the structure of the background jobs template so that HTML processed in the report includes is well styled. The patch does this by breaking the report and detail includes out of the fieldset and putting them in a separate section. This patch also adds the page-section class to the table view of current and past background jobs. Note: The patch includes indentation changes, so please ignore whitespace when viewing the diff. To test, apply the patch and go to Administration -> Manage jobs. - The table of jobs (even if empty) should be contained in a page-section style white box. - Test various processes which trigger a backgroud job: - Batch item modification - Batch item deletion - Batch hold deletion - Batch record modification ... etc. - After each process has been started, view the details of the job. - The information about the job shold be displayed well, with separate sections for "Report" and "Detailed messages." Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142864|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142892&action=edit Bug 31960: (follow-up) Make headings match Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31960 Bug 31960 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org