https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24619 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 98677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98677&action=edit Bug 23947: Phase out jquery.cookie.js: MARC Frameworks This patch removes the use of the jquery.cookie plugin on the MARC Frameworks page and replaces it with a call to the new js-cookie library. To test, apply the patch and go to Administration -> MARC bibliographic frameworks. - Choose the 'MARC structure' menu item for one of the frameworks listed. - On the page which lists the tags in the framework, check the box labeled "Display only used tags/subfields." The page should reload. - The checkbox should remain checked and the list of tags should now show only used tags. - Uncheck the checkbox and the page should reload again. You can also follow the changes to the cookie using the browser's developer console. Look for a cookie named 'marctagstructure_selectdisplay' and confirm that the value flips from 0 to 1 and back. https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector https://developers.google.com/web/tools/chrome-devtools/storage/cookies -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24619 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98677|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 98920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98920&action=edit Bug 23947: Phase out jquery.cookie.js: MARC Frameworks This patch removes the use of the jquery.cookie plugin on the MARC Frameworks page and replaces it with a call to the new js-cookie library. To test, apply the patch and go to Administration -> MARC bibliographic frameworks. - Choose the 'MARC structure' menu item for one of the frameworks listed. - On the page which lists the tags in the framework, check the box labeled "Display only used tags/subfields." The page should reload. - The checkbox should remain checked and the list of tags should now show only used tags. - Uncheck the checkbox and the page should reload again. You can also follow the changes to the cookie using the browser's developer console. Look for a cookie named 'marctagstructure_selectdisplay' and confirm that the value flips from 0 to 1 and back. https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector https://developers.google.com/web/tools/chrome-devtools/storage/cookies https://bugs.koha-community.org/show_bug.cgi?id=24619 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24619 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98920|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 98961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98961&action=edit Bug 23947: Phase out jquery.cookie.js: MARC Frameworks This patch removes the use of the jquery.cookie plugin on the MARC Frameworks page and replaces it with a call to the new js-cookie library. To test, apply the patch and go to Administration -> MARC bibliographic frameworks. - Choose the 'MARC structure' menu item for one of the frameworks listed. - On the page which lists the tags in the framework, check the box labeled "Display only used tags/subfields." The page should reload. - The checkbox should remain checked and the list of tags should now show only used tags. - Uncheck the checkbox and the page should reload again. You can also follow the changes to the cookie using the browser's developer console. Look for a cookie named 'marctagstructure_selectdisplay' and confirm that the value flips from 0 to 1 and back. https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector https://developers.google.com/web/tools/chrome-devtools/storage/cookies https://bugs.koha-community.org/show_bug.cgi?id=24619 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24619 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24619 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.04 |20.05.00, 19.11.04, released in| |19.05.09 CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.09 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24619 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27750 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27750 [Bug 27750] Remove jquery.cookie.js plugin -- You are receiving this mail because: You are watching all bug changes.