http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9078 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9074 Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9078 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 13583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13583&action=edit Bug 9078 - is_holiday should honour holiday exceptions Make is_holiday return 0 for holiday exceptions. Note: This patch makes several current ok tests fail. My first guess is test data is not constructed ok. More on this later. Sponsored-by: Universidad Nacional de Córdoba -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9078 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13583|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13588&action=edit Bug 9078 - is_holiday should honour holiday exceptions Make is_holiday return 0 for holiday exceptions. Note: This patch makes several current ok tests fail. My first guess is test data is not constructed ok. More on this later. Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9078 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9078 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9078 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13599|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13607&action=edit [SIGNED-OFF] Bug 9078 - fixing exceptions broke tests Fixing the holiday exceptions arised a problem with how the test data was constructed. This made several tests fail. This patch fixes the add_holiday function. Tests should pass now. Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9078 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13606|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 13621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13621&action=edit [SIGNED-OFF] Bug 9078 - is_holiday should honour holiday exceptions -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9078 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13607|Bug-9078---fixing-exception |3] [SIGNED-OFF] Bug 9078 - filename|s-broke-tests.patch |is_holiday should honour | |holiday -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9078 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13621|0002-SIGNED-OFF-Bug-9078-is |3] [SIGNED-OFF] Bug 9078 - filename|_holiday-should-honour-holi |is_holiday should honour |day.patch |holiday Attachment #13621|[SIGNED-OFF] Bug 9078 - |[PATCH 2/3] [SIGNED-OFF] description|is_holiday should honour |Bug 9078 - is_holiday |holiday exceptions |should honour holiday -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9078 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9078 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |liz@catalyst.net.nz Resolution|--- |FIXED --- Comment #11 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- Patches do not apply to 3.6.x, please reopen and submit a patch for 3.6.x if necessary. Thanks! -- You are receiving this mail because: You are watching all bug changes.