[Bug 27512] New: Block creation of invalid authorised values for LOST, NOTFORLOAN, DAMAGED, RESTRICTED, and WITHDRAWN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27512 Bug ID: 27512 Summary: Block creation of invalid authorised values for LOST, NOTFORLOAN, DAMAGED, RESTRICTED, and WITHDRAWN Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Several authorised value categories have inherent limits on what values can be used. Bug 24288 adds text to the screen to tell you about these limits, but doesn't enforce them. It'd be good to just stop a user from saving a value that won't work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27512 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov --- Comment #1 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27512 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Andrew Fuerste-Henry from comment #0)
Several authorised value categories have inherent limits on what values can be used. Bug 24288 adds text to the screen to tell you about these limits, but doesn't enforce them. It'd be good to just stop a user from saving a value that won't work.
It might be good to give specific cases here. On which form are you able to save values outside the range of an AV category? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27512 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- You can create the authorised values without issue, but you cannot use them in items. items.damaged linked to DAMAGED only takes numerical AV codes. (datatype) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27512 --- Comment #4 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Katrin Fischer from comment #3)
You can create the authorised values without issue, but you cannot use them in items. items.damaged linked to DAMAGED only takes numerical AV codes. (datatype)
Correct. I can create an authorized value in the DAMAGED category that has the value "TORN". Koha allows the creation of that authorized value, and then will show TORN as an option when editing items. However, it will never actually save TORN on an item and will never explain why it's failed to do so. The answer to that lies over in the schema, which tells us items.damaged only holds a bit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27512 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Andrew Fuerste-Henry from comment #4)
(In reply to Katrin Fischer from comment #3)
You can create the authorised values without issue, but you cannot use them in items. items.damaged linked to DAMAGED only takes numerical AV codes. (datatype)
Correct. I can create an authorized value in the DAMAGED category that has the value "TORN". Koha allows the creation of that authorized value, and then will show TORN as an option when editing items. However, it will never actually save TORN on an item and will never explain why it's failed to do so. The answer to that lies over in the schema, which tells us items.damaged only holds a bit.
Okay. How to proceed? We could move damaged to varchar() as expected by Authorised Values? Or we could intercept this in storing the item? Or even before building the combo, but that could be quite generic code, so a bit harder? Or when loading the form in javascript (hide options with a non-numeric value)? Another idea? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27512 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The code for NOT_LOAN checks for < > etc. and I think we do this for those other values too. So maybe it makes more sense to keep them numeric and make the differences clear in the GUI -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27512 --- Comment #7 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Katrin Fischer from comment #6)
The code for NOT_LOAN checks for < > etc. and I think we do this for those other values too. So maybe it makes more sense to keep them numeric and make the differences clear in the GUI
Agreed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27512 hebah@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27512 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27512 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laura@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27512 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marion.durand@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27512 Ray Delahunty <raymund.delahunty@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |raymund.delahunty@outlook.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27512 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40117 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27512 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35990 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35990 [Bug 35990] [OMNIBUS] Improvements for using tinyint authorised values -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27512 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43599 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43599 [Bug 43599] auth_val_cat.sql should be updated for is_integer_only column -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org