[Bug 38010] New: Migrate vendors to Vue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Bug ID: 38010 Summary: Migrate vendors to Vue Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: matt.blenkinsop@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@ptfs-europe.com | |, | |jonathan.field@ptfs-europe. | |com, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38011 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38011 [Bug 38011] Add a foreign key link between vendors and subscriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38204 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38204 [Bug 38204] Add an API endpoint to list baskets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38207 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38207 [Bug 38207] Add vendor payment methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38208 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38208 [Bug 38208] Provide a link to ERM agreements and licenses from a vendor record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38209 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38209 [Bug 38209] Add a vendor language field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 [Bug 35287] Add additional fields support to ERM Licenses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38256 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38256 [Bug 38256] Link vendors to ERM data providers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38262 [Bug 38262] Add additional fields to Vendors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|35287 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287 [Bug 35287] Add additional fields support to ERM licenses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38290 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38290 [Bug 38290] Add library group limits to vendors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Ohhh this would be cool. Might also be easier to find people to test this one. I don't have anyone using Preservation or ERM, but Acquisitions... for sure. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |roadmap_24_11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174119&action=edit Bug 38010: Add vue app and list component This patch adds the base vue app as well as the component to list vendors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174120&action=edit Bug 38010: Add the component to display a vendor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174121&action=edit Bug 38010: Add permissions This patch adds a permissions store and utility methods for implementing permissions checks in a Vue app -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174122&action=edit Bug 38010: Add authorised values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174123&action=edit Bug 38010: Rename routes to acquisitions This patch renames the app from vendors to acquisitions to allow further acquisitions pages to be migrated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #7 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174124&action=edit Bug 38010: Add the form to add a new vendor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174125&action=edit Bug 38010: Update navigation links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174126&action=edit Bug 38010: Add a nav link button component -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174128&action=edit Bug 38010: Allow external breadcrumbs This patch allows breadcrumbs to navigate to pages outside the Vue application -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #11 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174129&action=edit Bug 38010: Add a contracts table to the vendor show component -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174130&action=edit Bug 38010: Remove drawCallback from contracts table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #13 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174131&action=edit Bug 38010: Add permissions to action buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #14 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174132&action=edit Bug 38010: Make the delete button conditional on whether a vendor has baskets or subscriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #15 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174133&action=edit Bug 38010: Add cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #16 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174134&action=edit Bug 38010: Adjust vendor update logic This patch handles the embedded data that might also need updating when editing a vendor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #17 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174135&action=edit Bug 38010: Fix vendors search bar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #18 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174136&action=edit Bug 38010: Update links to vendor module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #19 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174137&action=edit Bug 38010: Rebase for Button component change -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #20 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174138&action=edit Bug 38010: Add basket page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #21 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174139&action=edit Bug 38010: Allow embedding for baskets table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #22 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174140&action=edit Bug 38010: Point basket action buttons to correct pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #23 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174141&action=edit Bug 38010: Fix null basket names -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #24 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174142&action=edit Bug 38010: Respect AcqViewBaskets syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #25 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174143&action=edit Bug 38010: Add delete contact button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #26 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174144&action=edit Bug 38010: Add menu components for vendor and acquisitions menus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #27 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174145&action=edit Bug 38010: Implement side menus in vendors app -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #28 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174146&action=edit Bug 38010: Fix rspack error in VendorShow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #29 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174147&action=edit Bug 38010: Allow searching by alias in the vendors table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #30 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174148&action=edit Bug 38010: Form fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174119|0 |1 is obsolete| | --- Comment #31 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174151&action=edit Bug 38010: Add vue app and list component This patch adds the base vue app as well as the component to list vendors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174120|0 |1 is obsolete| | --- Comment #32 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174152&action=edit Bug 38010: Add the component to display a vendor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174121|0 |1 is obsolete| | --- Comment #33 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174153&action=edit Bug 38010: Add permissions This patch adds a permissions store and utility methods for implementing permissions checks in a Vue app -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174122|0 |1 is obsolete| | --- Comment #34 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174154&action=edit Bug 38010: Add authorised values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174123|0 |1 is obsolete| | --- Comment #35 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174155&action=edit Bug 38010: Rename routes to acquisitions This patch renames the app from vendors to acquisitions to allow further acquisitions pages to be migrated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174124|0 |1 is obsolete| | --- Comment #36 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174156&action=edit Bug 38010: Add the form to add a new vendor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174125|0 |1 is obsolete| | --- Comment #37 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174157&action=edit Bug 38010: Update navigation links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174126|0 |1 is obsolete| | --- Comment #38 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174158&action=edit Bug 38010: Add a nav link button component -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174128|0 |1 is obsolete| | --- Comment #39 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174159&action=edit Bug 38010: Allow external breadcrumbs This patch allows breadcrumbs to navigate to pages outside the Vue application -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174129|0 |1 is obsolete| | --- Comment #40 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174160&action=edit Bug 38010: Add a contracts table to the vendor show component -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174130|0 |1 is obsolete| | --- Comment #41 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174161&action=edit Bug 38010: Remove drawCallback from contracts table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174131|0 |1 is obsolete| | --- Comment #42 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174162&action=edit Bug 38010: Add permissions to action buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174132|0 |1 is obsolete| | --- Comment #43 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174163&action=edit Bug 38010: Make the delete button conditional on whether a vendor has baskets or subscriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174133|0 |1 is obsolete| | --- Comment #44 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174164&action=edit Bug 38010: Add cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174134|0 |1 is obsolete| | --- Comment #45 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174165&action=edit Bug 38010: Adjust vendor update logic This patch handles the embedded data that might also need updating when editing a vendor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174135|0 |1 is obsolete| | --- Comment #46 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174166&action=edit Bug 38010: Fix vendors search bar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174136|0 |1 is obsolete| | --- Comment #47 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174167&action=edit Bug 38010: Update links to vendor module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174137|0 |1 is obsolete| | --- Comment #48 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174168&action=edit Bug 38010: Rebase for Button component change -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174138|0 |1 is obsolete| | --- Comment #49 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174169&action=edit Bug 38010: Add basket page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174139|0 |1 is obsolete| | --- Comment #50 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174170&action=edit Bug 38010: Allow embedding for baskets table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174140|0 |1 is obsolete| | --- Comment #51 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174171&action=edit Bug 38010: Point basket action buttons to correct pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174141|0 |1 is obsolete| | --- Comment #52 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174172&action=edit Bug 38010: Fix null basket names -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174142|0 |1 is obsolete| | --- Comment #53 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174173&action=edit Bug 38010: Respect AcqViewBaskets syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174143|0 |1 is obsolete| | --- Comment #54 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174174&action=edit Bug 38010: Add delete contact button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174144|0 |1 is obsolete| | --- Comment #55 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174175&action=edit Bug 38010: Add menu components for vendor and acquisitions menus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174145|0 |1 is obsolete| | --- Comment #56 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174176&action=edit Bug 38010: Implement side menus in vendors app -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174146|0 |1 is obsolete| | --- Comment #57 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174177&action=edit Bug 38010: Fix rspack error in VendorShow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174147|0 |1 is obsolete| | --- Comment #58 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174178&action=edit Bug 38010: Allow searching by alias in the vendors table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174148|0 |1 is obsolete| | --- Comment #59 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174179&action=edit Bug 38010: Form fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38389 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38389 [Bug 38389] Add 'subscriptions' embed to vendors endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38390 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38390 [Bug 38390] Add 'subscriptions+count' embed to vendors endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|38389 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38389 [Bug 38389] Add 'subscriptions' embed to vendors endpoint -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #60 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174194&action=edit Bug 38010: Rebase for bug 38390 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174151|0 |1 is obsolete| | --- Comment #61 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174196&action=edit Bug 38010: Add vue app and list component This patch adds the base vue app as well as the component to list vendors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174152|0 |1 is obsolete| | --- Comment #62 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174197&action=edit Bug 38010: Add the component to display a vendor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174153|0 |1 is obsolete| | --- Comment #63 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174198&action=edit Bug 38010: Add permissions This patch adds a permissions store and utility methods for implementing permissions checks in a Vue app -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174154|0 |1 is obsolete| | --- Comment #64 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174199&action=edit Bug 38010: Add authorised values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174155|0 |1 is obsolete| | --- Comment #65 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174200&action=edit Bug 38010: Rename routes to acquisitions This patch renames the app from vendors to acquisitions to allow further acquisitions pages to be migrated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174156|0 |1 is obsolete| | --- Comment #66 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174201&action=edit Bug 38010: Add the form to add a new vendor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174157|0 |1 is obsolete| | --- Comment #67 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174202&action=edit Bug 38010: Update navigation links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174158|0 |1 is obsolete| | --- Comment #68 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174203&action=edit Bug 38010: Add a nav link button component -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174159|0 |1 is obsolete| | --- Comment #69 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174204&action=edit Bug 38010: Allow external breadcrumbs This patch allows breadcrumbs to navigate to pages outside the Vue application -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174160|0 |1 is obsolete| | --- Comment #70 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174205&action=edit Bug 38010: Add a contracts table to the vendor show component -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174161|0 |1 is obsolete| | --- Comment #71 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174206&action=edit Bug 38010: Remove drawCallback from contracts table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174162|0 |1 is obsolete| | --- Comment #72 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174207&action=edit Bug 38010: Add permissions to action buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174163|0 |1 is obsolete| | --- Comment #73 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174208&action=edit Bug 38010: Make the delete button conditional on whether a vendor has baskets or subscriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174164|0 |1 is obsolete| | --- Comment #74 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174209&action=edit Bug 38010: Add cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174165|0 |1 is obsolete| | --- Comment #75 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174210&action=edit Bug 38010: Adjust vendor update logic This patch handles the embedded data that might also need updating when editing a vendor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174166|0 |1 is obsolete| | --- Comment #76 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174211&action=edit Bug 38010: Fix vendors search bar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174167|0 |1 is obsolete| | --- Comment #77 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174212&action=edit Bug 38010: Update links to vendor module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174168|0 |1 is obsolete| | --- Comment #78 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174213&action=edit Bug 38010: Rebase for Button component change -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174169|0 |1 is obsolete| | --- Comment #79 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174214&action=edit Bug 38010: Add basket page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174170|0 |1 is obsolete| | --- Comment #80 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174215&action=edit Bug 38010: Allow embedding for baskets table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174171|0 |1 is obsolete| | --- Comment #81 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174216&action=edit Bug 38010: Point basket action buttons to correct pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174172|0 |1 is obsolete| | --- Comment #82 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174217&action=edit Bug 38010: Fix null basket names -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174173|0 |1 is obsolete| | --- Comment #83 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174218&action=edit Bug 38010: Respect AcqViewBaskets syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174174|0 |1 is obsolete| | --- Comment #84 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174220&action=edit Bug 38010: Add delete contact button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174175|0 |1 is obsolete| | --- Comment #85 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174221&action=edit Bug 38010: Add menu components for vendor and acquisitions menus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174176|0 |1 is obsolete| | --- Comment #86 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174222&action=edit Bug 38010: Implement side menus in vendors app -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174177|0 |1 is obsolete| | --- Comment #87 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174223&action=edit Bug 38010: Fix rspack error in VendorShow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174178|0 |1 is obsolete| | --- Comment #88 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174224&action=edit Bug 38010: Allow searching by alias in the vendors table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174179|0 |1 is obsolete| | --- Comment #89 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174225&action=edit Bug 38010: Form fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174194|0 |1 is obsolete| | --- Comment #90 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174226&action=edit Bug 38010: Rebase for bug 38390 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clemens.tubach@kit.edu, | |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #91 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174248&action=edit Bug 38010: Add recevie shipments action to table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174248|0 |1 is obsolete| | --- Comment #92 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174266&action=edit Bug 38010: Add receive shipments action to table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #93 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174267&action=edit Bug 38010: Restore new basket/contract buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #94 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174269&action=edit Bug 38010: Add dropdown button component -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #95 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174270&action=edit Bug 38010: Reset basket view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174270|0 |1 is obsolete| | --- Comment #96 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174273&action=edit Bug 38010: Reset basket view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174196|0 |1 is obsolete| | --- Comment #97 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174327&action=edit Bug 38010: Add vue app and list component This patch adds the base vue app as well as the component to list vendors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174197|0 |1 is obsolete| | --- Comment #98 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174328&action=edit Bug 38010: Add the component to display a vendor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174198|0 |1 is obsolete| | --- Comment #99 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174329&action=edit Bug 38010: Add permissions This patch adds a permissions store and utility methods for implementing permissions checks in a Vue app -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174199|0 |1 is obsolete| | --- Comment #100 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174330&action=edit Bug 38010: Add authorised values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174200|0 |1 is obsolete| | --- Comment #101 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174331&action=edit Bug 38010: Rename routes to acquisitions This patch renames the app from vendors to acquisitions to allow further acquisitions pages to be migrated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174201|0 |1 is obsolete| | --- Comment #102 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174332&action=edit Bug 38010: Add the form to add a new vendor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174202|0 |1 is obsolete| | --- Comment #103 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174333&action=edit Bug 38010: Update navigation links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174203|0 |1 is obsolete| | --- Comment #104 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174334&action=edit Bug 38010: Add a nav link button component -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174204|0 |1 is obsolete| | --- Comment #105 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174335&action=edit Bug 38010: Allow external breadcrumbs This patch allows breadcrumbs to navigate to pages outside the Vue application -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174205|0 |1 is obsolete| | --- Comment #106 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174336&action=edit Bug 38010: Add a contracts table to the vendor show component -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174206|0 |1 is obsolete| | --- Comment #107 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174337&action=edit Bug 38010: Remove drawCallback from contracts table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174207|0 |1 is obsolete| | --- Comment #108 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174338&action=edit Bug 38010: Add permissions to action buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174208|0 |1 is obsolete| | --- Comment #109 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174339&action=edit Bug 38010: Make the delete button conditional on whether a vendor has baskets or subscriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174209|0 |1 is obsolete| | --- Comment #110 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174340&action=edit Bug 38010: Add cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174210|0 |1 is obsolete| | --- Comment #111 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174341&action=edit Bug 38010: Adjust vendor update logic This patch handles the embedded data that might also need updating when editing a vendor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174211|0 |1 is obsolete| | --- Comment #112 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174342&action=edit Bug 38010: Fix vendors search bar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174212|0 |1 is obsolete| | --- Comment #113 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174343&action=edit Bug 38010: Update links to vendor module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174213|0 |1 is obsolete| | --- Comment #114 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174344&action=edit Bug 38010: Rebase for Button component change -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174214|0 |1 is obsolete| | --- Comment #115 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174345&action=edit Bug 38010: Add basket page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174215|0 |1 is obsolete| | --- Comment #116 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174346&action=edit Bug 38010: Allow embedding for baskets table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174216|0 |1 is obsolete| | --- Comment #117 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174347&action=edit Bug 38010: Point basket action buttons to correct pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174217|0 |1 is obsolete| | --- Comment #118 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174348&action=edit Bug 38010: Fix null basket names -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174218|0 |1 is obsolete| | --- Comment #119 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174349&action=edit Bug 38010: Respect AcqViewBaskets syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174220|0 |1 is obsolete| | --- Comment #120 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174350&action=edit Bug 38010: Add delete contact button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174221|0 |1 is obsolete| | --- Comment #121 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174351&action=edit Bug 38010: Add menu components for vendor and acquisitions menus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174222|0 |1 is obsolete| | --- Comment #122 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174352&action=edit Bug 38010: Implement side menus in vendors app -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174223|0 |1 is obsolete| | --- Comment #123 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174353&action=edit Bug 38010: Fix rspack error in VendorShow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174224|0 |1 is obsolete| | --- Comment #124 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174354&action=edit Bug 38010: Allow searching by alias in the vendors table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174225|0 |1 is obsolete| | --- Comment #125 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174355&action=edit Bug 38010: Form fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174226|0 |1 is obsolete| | --- Comment #126 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174356&action=edit Bug 38010: Rebase for bug 38390 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174266|0 |1 is obsolete| | --- Comment #127 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174357&action=edit Bug 38010: Add receive shipments action to table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174267|0 |1 is obsolete| | --- Comment #128 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174358&action=edit Bug 38010: Restore new basket/contract buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174269|0 |1 is obsolete| | --- Comment #129 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174359&action=edit Bug 38010: Add dropdown button component -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174273|0 |1 is obsolete| | --- Comment #130 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174360&action=edit Bug 38010: Reset basket view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #131 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174603&action=edit Bug 38010: Remove unnecessary navigation check -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|roadmap_24_11 |roadmap_25_05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #132 from Owen Leonard <oleonard@myacpl.org> --- I get a 404 error when I try to search for a vendor or follow a link to a vendor. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #133 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Hi Matt, not sure if this is just a thing with the sandbox or not, but when I go to edit vendor Askews & Holt in the sandbox, the library group says NaN, 1, NaN https://staff-vendors.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/vendors/edit/... To get there : 1. Go to the sandbox https://staff-vendors.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/vendors 2. Click Askews & Holt (#4) 3. Click Edit vendor --> Library group visiblity: NaN, 1, NaN Also, is it normal that when we are in the vendors, the left side menu only lists vendors? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #134 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Caroline Cyr La Rose from comment #133)
Also, is it normal that when we are in the vendors, the left side menu only lists vendors?
To get there: 1. Go to the sandbox https://staff-vendors.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/vendors 2. Click Askews & Holt (#4) 3. Click Edit vendor --> The left side menu only contains Vendors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38446 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38446 [Bug 38446] Permission error for additional fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174327|0 |1 is obsolete| | --- Comment #135 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175098&action=edit Bug 38010: Add vue app and list component This patch adds the base vue app as well as the component to list vendors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174328|0 |1 is obsolete| | --- Comment #136 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175099&action=edit Bug 38010: Add the component to display a vendor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174329|0 |1 is obsolete| | --- Comment #137 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175100&action=edit Bug 38010: Add permissions This patch adds a permissions store and utility methods for implementing permissions checks in a Vue app -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174330|0 |1 is obsolete| | --- Comment #138 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175101&action=edit Bug 38010: Add authorised values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174331|0 |1 is obsolete| | --- Comment #139 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175102&action=edit Bug 38010: Rename routes to acquisitions This patch renames the app from vendors to acquisitions to allow further acquisitions pages to be migrated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174332|0 |1 is obsolete| | --- Comment #140 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175103&action=edit Bug 38010: Add the form to add a new vendor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174333|0 |1 is obsolete| | --- Comment #141 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175104&action=edit Bug 38010: Update navigation links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174335|0 |1 is obsolete| | --- Comment #142 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175105&action=edit Bug 38010: Allow external breadcrumbs This patch allows breadcrumbs to navigate to pages outside the Vue application -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174336|0 |1 is obsolete| | --- Comment #143 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175106&action=edit Bug 38010: Add a contracts table to the vendor show component -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174337|0 |1 is obsolete| | --- Comment #144 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175107&action=edit Bug 38010: Remove drawCallback from contracts table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174338|0 |1 is obsolete| | --- Comment #145 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175108&action=edit Bug 38010: Add permissions to action buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174339|0 |1 is obsolete| | --- Comment #146 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175109&action=edit Bug 38010: Make the delete button conditional on whether a vendor has baskets or subscriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174340|0 |1 is obsolete| | --- Comment #147 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175110&action=edit Bug 38010: Add cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174341|0 |1 is obsolete| | --- Comment #148 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175111&action=edit Bug 38010: Adjust vendor update logic This patch handles the embedded data that might also need updating when editing a vendor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174342|0 |1 is obsolete| | --- Comment #149 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175112&action=edit Bug 38010: Fix vendors search bar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174343|0 |1 is obsolete| | --- Comment #150 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175113&action=edit Bug 38010: Update links to vendor module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174344|0 |1 is obsolete| | --- Comment #151 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175114&action=edit Bug 38010: Rebase for Button component change -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174345|0 |1 is obsolete| | --- Comment #152 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175115&action=edit Bug 38010: Add basket page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174346|0 |1 is obsolete| | --- Comment #153 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175116&action=edit Bug 38010: Allow embedding for baskets table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174347|0 |1 is obsolete| | --- Comment #154 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175117&action=edit Bug 38010: Point basket action buttons to correct pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174348|0 |1 is obsolete| | --- Comment #155 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175118&action=edit Bug 38010: Fix null basket names -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174349|0 |1 is obsolete| | --- Comment #156 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175119&action=edit Bug 38010: Respect AcqViewBaskets syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174350|0 |1 is obsolete| | --- Comment #157 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175120&action=edit Bug 38010: Add delete contact button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174351|0 |1 is obsolete| | --- Comment #158 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175121&action=edit Bug 38010: Add menu components for vendor and acquisitions menus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174352|0 |1 is obsolete| | --- Comment #159 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175122&action=edit Bug 38010: Implement side menus in vendors app -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174353|0 |1 is obsolete| | --- Comment #160 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175123&action=edit Bug 38010: Fix rspack error in VendorShow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174354|0 |1 is obsolete| | --- Comment #161 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175124&action=edit Bug 38010: Allow searching by alias in the vendors table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174355|0 |1 is obsolete| | --- Comment #162 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175125&action=edit Bug 38010: Form fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174356|0 |1 is obsolete| | --- Comment #163 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175126&action=edit Bug 38010: Rebase for bug 38390 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174357|0 |1 is obsolete| | --- Comment #164 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175127&action=edit Bug 38010: Add receive shipments action to table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174358|0 |1 is obsolete| | --- Comment #165 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175128&action=edit Bug 38010: Restore new basket/contract buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174359|0 |1 is obsolete| | --- Comment #166 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175129&action=edit Bug 38010: Add dropdown button component -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174360|0 |1 is obsolete| | --- Comment #167 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175130&action=edit Bug 38010: Reset basket view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174603|0 |1 is obsolete| | --- Comment #168 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175131&action=edit Bug 38010: Remove unnecessary navigation check -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #169 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175133&action=edit Bug 38010: Rebase for bug 37301 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #170 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175134&action=edit Bug 38010: Fix tax rate display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #171 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175135&action=edit Bug 38010: Add callbacks to Toolbarbutton -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #172 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175136&action=edit Bug 38010: Fix acqui-home.pl breadcrumbs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #173 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175137&action=edit Bug 38010: Add permissions for additional fields (cherry picked from commit 0387e998a49b91a57c798504c28a097a011a9d77) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37301 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 [Bug 37301] Further improve how we build Vue components -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175137|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|38446 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38446 [Bug 38446] Permission error for additional fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23005 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23005 [Bug 23005] Specify notice language for vendors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38209 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38209 [Bug 38209] Add a vendor language field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #174 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175167&action=edit Bug 38010: Fix programmatic navigation id attribute -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #175 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- (In reply to Owen Leonard from comment #132)
I get a 404 error when I try to search for a vendor or follow a link to a vendor.
This sounds like an apache issue - you need to run reset_all after applying to get the apache redirect to activate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #176 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- (In reply to Caroline Cyr La Rose from comment #133)
Hi Matt, not sure if this is just a thing with the sandbox or not, but when I go to edit vendor Askews & Holt in the sandbox, the library group says NaN, 1, NaN
This is sandbox specific, that includes lots of further enhancements that aren't part of this bug
Also, is it normal that when we are in the vendors, the left side menu only lists vendors?
I've removed this so that there is no menu which is what we currently have in main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #177 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Matt Blenkinsop from comment #175)
(In reply to Owen Leonard from comment #132)
I get a 404 error when I try to search for a vendor or follow a link to a vendor.
This sounds like an apache issue - you need to run reset_all after applying to get the apache redirect to activate
Wondering (in general) how we handle this for updating installations - I believe we can't just add to the Apache files, but maybe I am mistaken. Hint on about? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174334|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #178 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175168&action=edit Bug 38010: Remove unnecessary test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #179 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175170&action=edit Bug 38010: Delete old code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #180 from Michaela Sieber <michaela.sieber@kit.edu> --- I started testing and found two bugs which you can recreate in this sandbox : 1.) Error "Something went wrong: Error: Expected integer - got string." Go to acq module search for vendors Go to record 1 = "My Vendor" Click on Baskets on the left Click on Button "Edit vendor" on the top. This leads you to the following URL: https://staff-vendorsvue.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/vendors/1&op=enter --> Error: "Something went wrong: Error: Expected integer - got string." 2.) Error 404 Go to acq module search for vendors Go to record 1 = "My Vendor" Click on Baskets on the left Go to the existing basket "My Basket" (basketno=1) Click on the link to the vendor "My Vendor" on the top. This leads you to the following URL: https://staff-vendorsvue.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/acqui/cgi-... --> Error 404 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #181 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175240&action=edit Bug 38010: Fix navigation links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #182 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175241&action=edit Bug 38010: Prevent vendor contacts from duplicating -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #183 from Michaela Sieber <michaela.sieber@kit.edu> --- Things I discovered that are new / different behavior as before: - New vendors are inactive (radio button default is inactive, before it was active) - There is a new Button "New basket", this opens a new browser tab (did not exist before) - The Button "Receive shipment" exists even if there is no basket for the vendor (before the botton was only there if there was at least one basket). This means you can enter an invoice, for example with invoice adjustments. That is ok, but then it should not be possible to delete the vendor. If you delete the vendor the invoice is deleted as well. This means your budget is not correct any more! If there are invoices in the database it should definitly not be possible to delete a vendor. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #184 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175242&action=edit Bug 38010: Check for baskets for receive shipments button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #185 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175243&action=edit Bug 38010: Check for invoices before allowing vendor deletion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #186 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175248&action=edit Bug 38010: Only allow one primary contact -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #187 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175249&action=edit Bug 38010: Remove unnecessary buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #188 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175266&action=edit Bug 38010: Apply format_date to vendor contracts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Bug 38010 depends on bug 38204, which changed state. Bug 38204 Summary: Add `GET /acquisitions/baskets` https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38204 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #189 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 175791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175791&action=edit Bug 38010: Change how interface details are displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175266|0 |1 is obsolete| | --- Comment #190 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 175799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175799&action=edit Bug 38010: Apply format_date to vendor contracts Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #191 from Michaela Sieber <michaela.sieber@kit.edu> --- Well done Matt! Ready for QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Ola Andersson <ola.andersson@ltu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ola.andersson@ltu.se --- Comment #192 from Ola Andersson <ola.andersson@ltu.se> --- I was asked to leave this comment confirming performance issues with the acquisition module searching for vendors with thousands of baskets. Hopefully it will be resolved with this work. "We have a 25 second waiting time when we search for a vendor in the acquisition module that had 5000+ baskets." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #193 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Ola Andersson from comment #192)
I was asked to leave this comment confirming performance issues with the acquisition module searching for vendors with thousands of baskets. Hopefully it will be resolved with this work.
"We have a 25 second waiting time when we search for a vendor in the acquisition module that had 5000+ baskets."
I thought it might make a good stress test for the new vendor search :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #194 from Jonathan Druart <jonathan.druart@gmail.com> --- Had a quick look at the UI, some notes: 1. "Save" => "Submit" 2. No more sticky toolbar 3. a. "Add vendor" => "New vendor" b. It's not h2 instead of h1 4. Alias a. can be added empty (was not possible before) b. "Remove" does not remove the correct alias 5. http://localhost:8081/cgi-bin/koha/acqui/booksellers.pl?booksellerid=2 "Edit" is http://localhost:8081/cgi-bin/koha/vendors/2 ("show" view) 6. Empty contact can be added (was not possible before) 7. "Delete contact" and "Remove this interface" is not consistent (in wording, in position, and in styling) 8. Discount and delivery time have type="number" https://wiki.koha-community.org/wiki/Coding_Guidelines#ACC2:_Input_type_.22n... 9. Delete not working http://localhost:8081/cgi-bin/koha/acqui/booksellers.pl?booksellerid=2 "Delete vendor", yes => 404 and vendor is not deleted. 10. Breadcrumb a. Small glitch in the breadcrumb (spacing difference before 'Vendors'?) https://snipboard.io/GQ5XRs.jpg vs https://snipboard.io/fubCc5.jpg b. http://localhost:8081/cgi-bin/koha/vendors 'Vendors' is a link (http://localhost:8081/cgi-bin/koha/vendors#) 11. Interfaces a. On the "show" view, "Type" is displayed when not filled (was not before) b. The name of the interface is now in a `legend` tag, was h3 before. I don't think you can use `legend` for something else than `fieldset`. 12. We are missing tests. You should have a look at bug 38461 and bug 38503. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #195 from Jonathan Druart <jonathan.druart@gmail.com> --- 13. The vendor search result is really different from what we have currently, and it's missing a lot of info and actions (basket list, "add to basket", "show all baskets", "show active vendors only", the ability to basket or contract for a vendor). Has this been discussed before already? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #196 from Jonathan Druart <jonathan.druart@gmail.com> --- The permissions store is a bit weird as you rely on a global JS variable. How could this be reusable from the ERM module for instance? It would really have been great to have such concepts/ideas isolated into their own bug instead of lost in this huge set... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #197 from Jonathan Druart <jonathan.druart@gmail.com> --- Should not we move js/vue/components/Vendors to js/vue/components/Acquisitions/Vendors? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #198 from Jonathan Druart <jonathan.druart@gmail.com> --- + `${(vendor.tax_rate * 100).toFixed(2)}` + "{enter}", + label: `${(gv.option * 100).toFixed(2)}%`, I don't think this is correct, you should use format_price (from format_price.inc) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #199 from Jonathan Druart <jonathan.druart@gmail.com> --- Wrong paste koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementResource.vue: //AgreementResource specific setup here koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue: //AgreementResource specific setup here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #200 from Jonathan Druart <jonathan.druart@gmail.com> --- What's the purpose of VendorDetails.vue? I don't see how it could be useful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #201 from Jonathan Druart <jonathan.druart@gmail.com> --- It seems that this file contains things that are not from this patch set. koha-tmpl/intranet-tmpl/prog/js/vue/components/Islands/AcquisitionsMenu.vue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #202 from Jonathan Druart <jonathan.druart@gmail.com> --- Code duplication, the acquisition menu is now in koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-menu.inc and koha-tmpl/intranet-tmpl/prog/js/vue/components/Islands/AcquisitionsMenu.vue This should be on its own bug really. Replace the left menu everywhere before this and don't duplicate the code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #203 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #194)
12. We are missing tests. You should have a look at bug 38461 and bug 38503.
Also missing tests for the pm changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #204 from Jonathan Druart <jonathan.druart@gmail.com> --- Koha/Acquisition/Bookseller.pm + $interface->password( $interface->plain_text_password ); Do we really want to expose the password? Maybe not something for now, but we should maybe have the "****" trick here with a "show" that will trigger a special route for plain text password (just for discussion as I am reading this code) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #205 from Jonathan Druart <jonathan.druart@gmail.com> --- Koha/Schema/Result/Aqbookseller.pm +__PACKAGE__->has_many( + "aliases", + "Koha::Schema::Result::AqbooksellerAlias", Why? We already have Koha::Acquisition::Bookseller->aliases, when is this used? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38899 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 [Bug 38899] Allow the Vue toolbar to be sticky -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38899 Depends on|38899 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38899 [Bug 38899] Allow the Vue toolbar to be sticky -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #206 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 176547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176547&action=edit Bug 38010: (QA follow-up) Template fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #207 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- First of a few follow-up patches, this one is needed to make 38899 work. More to follow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38941 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941 [Bug 38941] Convert the acquisitions menu to a Vue island -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|37301 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37301 [Bug 37301] Further improve how we build Vue components -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175098|0 |1 is obsolete| | --- Comment #208 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178182&action=edit Bug 38010: Add vue app and list component This patch adds the base vue app as well as the component to list vendors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175099|0 |1 is obsolete| | --- Comment #209 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178183&action=edit Bug 38010: Add the component to display a vendor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175100|0 |1 is obsolete| | --- Comment #210 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178184&action=edit Bug 38010: Add permissions This patch adds a permissions store and utility methods for implementing permissions checks in a Vue app -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175101|0 |1 is obsolete| | --- Comment #211 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178185&action=edit Bug 38010: Add authorised values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175102|0 |1 is obsolete| | --- Comment #212 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178186&action=edit Bug 38010: Rename routes to acquisitions This patch renames the app from vendors to acquisitions to allow further acquisitions pages to be migrated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175103|0 |1 is obsolete| | --- Comment #213 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178187&action=edit Bug 38010: Add the form to add a new vendor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175104|0 |1 is obsolete| | --- Comment #214 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178188&action=edit Bug 38010: Update navigation links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175105|0 |1 is obsolete| | --- Comment #215 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178189&action=edit Bug 38010: Allow external breadcrumbs This patch allows breadcrumbs to navigate to pages outside the Vue application -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175106|0 |1 is obsolete| | --- Comment #216 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178190&action=edit Bug 38010: Add a contracts table to the vendor show component -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175107|0 |1 is obsolete| | --- Comment #217 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178191&action=edit Bug 38010: Remove drawCallback from contracts table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175108|0 |1 is obsolete| | --- Comment #218 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178192&action=edit Bug 38010: Add permissions to action buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175109|0 |1 is obsolete| | --- Comment #219 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178193&action=edit Bug 38010: Make the delete button conditional on whether a vendor has baskets or subscriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175110|0 |1 is obsolete| | --- Comment #220 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178194&action=edit Bug 38010: Add cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175111|0 |1 is obsolete| | --- Comment #221 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178195&action=edit Bug 38010: Adjust vendor update logic This patch handles the embedded data that might also need updating when editing a vendor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175112|0 |1 is obsolete| | --- Comment #222 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178196&action=edit Bug 38010: Fix vendors search bar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175113|0 |1 is obsolete| | --- Comment #223 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178197&action=edit Bug 38010: Update links to vendor module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175114|0 |1 is obsolete| | --- Comment #224 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178198&action=edit Bug 38010: Rebase for Button component change -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175115|0 |1 is obsolete| | --- Comment #225 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178199&action=edit Bug 38010: Add basket page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175116|0 |1 is obsolete| | --- Comment #226 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178200&action=edit Bug 38010: Allow embedding for baskets table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175117|0 |1 is obsolete| | --- Comment #227 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178201&action=edit Bug 38010: Point basket action buttons to correct pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175118|0 |1 is obsolete| | --- Comment #228 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178202&action=edit Bug 38010: Fix null basket names -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175119|0 |1 is obsolete| | --- Comment #229 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178203&action=edit Bug 38010: Respect AcqViewBaskets syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175120|0 |1 is obsolete| | --- Comment #230 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178204&action=edit Bug 38010: Add delete contact button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175121|0 |1 is obsolete| | --- Comment #231 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178205&action=edit Bug 38010: Add menu components for vendor and acquisitions menus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175122|0 |1 is obsolete| | --- Comment #232 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178206&action=edit Bug 38010: Implement side menus in vendors app -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175123|0 |1 is obsolete| | --- Comment #233 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178207&action=edit Bug 38010: Fix rspack error in VendorShow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175124|0 |1 is obsolete| | --- Comment #234 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178208&action=edit Bug 38010: Allow searching by alias in the vendors table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175125|0 |1 is obsolete| | --- Comment #235 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178209&action=edit Bug 38010: Form fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175126|0 |1 is obsolete| | --- Comment #236 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178210&action=edit Bug 38010: Rebase for bug 38390 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175127|0 |1 is obsolete| | --- Comment #237 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178211&action=edit Bug 38010: Add receive shipments action to table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175128|0 |1 is obsolete| | --- Comment #238 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178212&action=edit Bug 38010: Restore new basket/contract buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175129|0 |1 is obsolete| | --- Comment #239 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178213&action=edit Bug 38010: Add dropdown button component -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175130|0 |1 is obsolete| | --- Comment #240 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178214&action=edit Bug 38010: Reset basket view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175131|0 |1 is obsolete| | --- Comment #241 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178215&action=edit Bug 38010: Remove unnecessary navigation check -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175134|0 |1 is obsolete| | --- Comment #242 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178216&action=edit Bug 38010: Fix tax rate display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175135|0 |1 is obsolete| | --- Comment #243 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178217&action=edit Bug 38010: Add callbacks to Toolbarbutton -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175136|0 |1 is obsolete| | --- Comment #244 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178218&action=edit Bug 38010: Fix acqui-home.pl breadcrumbs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175167|0 |1 is obsolete| | --- Comment #245 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178219&action=edit Bug 38010: Fix programmatic navigation id attribute -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175168|0 |1 is obsolete| | --- Comment #246 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178220&action=edit Bug 38010: Remove unnecessary test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175170|0 |1 is obsolete| | --- Comment #247 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178221&action=edit Bug 38010: Delete old code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175240|0 |1 is obsolete| | --- Comment #248 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178222&action=edit Bug 38010: Fix navigation links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175241|0 |1 is obsolete| | --- Comment #249 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178223&action=edit Bug 38010: Prevent vendor contacts from duplicating -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175242|0 |1 is obsolete| | --- Comment #250 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178224&action=edit Bug 38010: Check for baskets for receive shipments button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175243|0 |1 is obsolete| | --- Comment #251 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178225&action=edit Bug 38010: Check for invoices before allowing vendor deletion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175248|0 |1 is obsolete| | --- Comment #252 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178226&action=edit Bug 38010: Only allow one primary contact -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175249|0 |1 is obsolete| | --- Comment #253 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178227&action=edit Bug 38010: Remove unnecessary buttons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175799|0 |1 is obsolete| | --- Comment #254 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178228&action=edit Bug 38010: Apply format_date to vendor contracts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175791|0 |1 is obsolete| | --- Comment #255 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178229&action=edit Bug 38010: Change how interface details are displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176547|0 |1 is obsolete| | --- Comment #256 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178230&action=edit Bug 38010: (QA follow-up) Template fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #257 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178231&action=edit Bug 38010: (QA follow-up) Fix new vendor form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #258 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178232&action=edit Bug 38010: (QA follow-up) Restore navigation links This patch restores any links that previously pointed to booksellers.pl as this script is still in use. All references to supplier.pl remain pointed at the new Vue app -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #259 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178233&action=edit Bug 38010: (QA follow-up) Fix delete button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #260 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178234&action=edit Bug 38010: (QA follow-up) Fix vendor show component -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #261 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178235&action=edit Bug 38010: (QA follow-up) Use format_price -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #262 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178236&action=edit Bug 38010: (QA follow-up) Rebase acquisitions amd vendor menus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #263 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178237&action=edit Bug 38010: (QA follow-up) Remove unnecessary code from booksellers.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #264 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178238&action=edit Bug 38010: (QA follow-up) Rebase for bug 37930 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #265 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178239&action=edit Bug 38010: (QA follow-up) Rebase for bug 38854 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #266 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178240&action=edit Bug 38010: (QA follow-up) Convert vendor menu to Vue island -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #267 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178241&action=edit Bug 38010: (QA follow-up) Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #268 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 178242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178242&action=edit Bug 38010: (QA follow-up) Fix toolbar on VendorShow The delete button was missing from VendorShow and bug 37301 has been removed as a dependency so some small fixes were required for that -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175133|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #269 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #194)
Had a quick look at the UI, some notes: 1. "Save" => "Submit" 2. No more sticky toolbar 3. a. "Add vendor" => "New vendor" b. It's not h2 instead of h1 4. Alias a. can be added empty (was not possible before) b. "Remove" does not remove the correct alias 5. http://localhost:8081/cgi-bin/koha/acqui/booksellers.pl?booksellerid=2 "Edit" is http://localhost:8081/cgi-bin/koha/vendors/2 ("show" view) 6. Empty contact can be added (was not possible before) 7. "Delete contact" and "Remove this interface" is not consistent (in wording, in position, and in styling) 8. Discount and delivery time have type="number" https://wiki.koha-community.org/wiki/Coding_Guidelines#ACC2:_Input_type_. 22number.22_should_be_avoided 9. Delete not working http://localhost:8081/cgi-bin/koha/acqui/booksellers.pl?booksellerid=2 "Delete vendor", yes => 404 and vendor is not deleted. 10. Breadcrumb a. Small glitch in the breadcrumb (spacing difference before 'Vendors'?) https://snipboard.io/GQ5XRs.jpg vs https://snipboard.io/fubCc5.jpg b. http://localhost:8081/cgi-bin/koha/vendors 'Vendors' is a link (http://localhost:8081/cgi-bin/koha/vendors#) 11. Interfaces a. On the "show" view, "Type" is displayed when not filled (was not before) b. The name of the interface is now in a `legend` tag, was h3 before. I don't think you can use `legend` for something else than `fieldset`. 12. We are missing tests. You should have a look at bug 38461 and bug 38503.
I've addressed all of the above as best I can, the only one I'm not sure on is point 12 - what specifically do you want to see tests for? The main functions are CRUD which there are cypress tests for. I've also added more unit tests for the .pm methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #270 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #195)
13. The vendor search result is really different from what we have currently, and it's missing a lot of info and actions (basket list, "add to basket", "show all baskets", "show active vendors only", the ability to basket or contract for a vendor). Has this been discussed before already?
There were issues for libraries with large numbers of vendors and baskets - the vendor search could take a long time to load so the plan was to use the migration to make use of the new datatables work to allow pagination and search. The table filters allow for easy searching and filtering, with much faster load time (In reply to Jonathan Druart from comment #196)
The permissions store is a bit weird as you rely on a global JS variable. How could this be reusable from the ERM module for instance?
It would really have been great to have such concepts/ideas isolated into their own bug instead of lost in this huge set...
I've moved this to bug 38930 (In reply to Jonathan Druart from comment #198)
+ `${(vendor.tax_rate * 100).toFixed(2)}` + "{enter}",
+ label: `${(gv.option * 100).toFixed(2)}%`,
I don't think this is correct, you should use format_price (from format_price.inc)
Done (In reply to Jonathan Druart from comment #202)
Code duplication, the acquisition menu is now in koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-menu.inc and koha-tmpl/intranet-tmpl/prog/js/vue/components/Islands/AcquisitionsMenu.vue This should be on its own bug really. Replace the left menu everywhere before this and don't duplicate the code.
Bug 38941 (In reply to Jonathan Druart from comment #200)
What's the purpose of VendorDetails.vue? I don't see how it could be useful.
The vendor form component was so long and bloated, same with VendorShow. I wanted to make it more readable by splitting the html out into separate components (In reply to Jonathan Druart from comment #204)
Koha/Acquisition/Bookseller.pm + $interface->password( $interface->plain_text_password );
Do we really want to expose the password? Maybe not something for now, but we should maybe have the "****" trick here with a "show" that will trigger a special route for plain text password (just for discussion as I am reading this code)
This was discussed on Mattermost and we agreed this was the best way forward for now. The documentation has been updated to make it clear that Koha is not a password manager and that passwords will be visible through the API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #271 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Rebased onto the tidy work, same for dependencies. QA feedback comments above -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #272 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/js/vue/stores/vendors.js). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #273 from Michaela Sieber <michaela.sieber@kit.edu> --- Soft feature freeze for 25.05 : 2025-04-29 means 30 working days left... What about a session in Marseille for testing and QA? @joubu, Matt, cait? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #274 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Michaela Sieber from comment #273)
Soft feature freeze for 25.05 : 2025-04-29
means 30 working days left...
What about a session in Marseille for testing and QA?
@joubu, Matt, cait?
I'd be happy to. Maybe Monday/Tuesday? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #275 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Sounds like a plan to me, I need to try and get it fully rebased before then now that i'm back -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|23005 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23005 [Bug 23005] Specify notice language for vendors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|38290 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38290 [Bug 38290] Add library group limits to vendors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Amaury GAU <amaury.gau@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amaury.gau@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #276 from Jonathan Druart <jonathan.druart@gmail.com> --- Testing on top of: c0fc58efa3b (openfifth/bug_38010) Bug 38010: (QA follow-up) Fix toolbar on VendorShow 1. Should we provide more rewrite rule to not break existing bookmarks? For instance http://localhost:8081/cgi-bin/koha/acqui/supplier.pl?booksellerid=1 now returns 404 2. Why do we have /cgi-bin/koha/vendors instead of /cgi-bin/koha/acquisition/vendors ? 3. breadcrumb: http://localhost:8081/cgi-bin/koha/vendors?supplier=my+vendor Click "Vendors" in the breadcrumb: http://localhost:8081/cgi-bin/koha/vendors?supplier=my+vendor# Expected: see all vendors Not a regression, and not sure we can fix here. 4. Filtering: http://localhost:8081/cgi-bin/koha/vendors?supplier=my+vendor "Showing 1 to 1 of 1 entries (filtered from 3 total entries)" But you have no way to remove the filtering and see all vendors It is the current behaviour in main, but at least we had "Search for vendor my vendor" in the breadcrumb 5. http://localhost:8081/cgi-bin/koha/acqui/vendors.pl interestingly shows: https://snipboard.io/5Pmeq2.jpg 6. http://localhost:8081/cgi-bin/koha/vendors/2 Warning in the console: [Vue Router warn]: Discarded invalid param(s) "vendor_id" when navigating. 7. http://localhost:8081/cgi-bin/koha/acqui/booksellers.pl?booksellerid=2 Errors in the console: Uncaught (in promise) DOMException: CustomElementRegistry.define: 'vendor-menu' has already been defined as a custom element Uncaught (in promise) DOMException: CustomElementRegistry.define: 'acquisitions-menu' has already been defined as a custom element 8. show vendor view: a. website is a button: https://snipboard.io/16ZLPA.jpg (same for the interfaces) b. contact options does not display correctly: https://snipboard.io/UI8Ko6.jpg c. "New" menu: the entries does not have the dropdown-item class => incorrect styling on mouse over: https://snipboard.io/aiB8zw.jpg c. Entries in the "New" menu open in new tab (same for "Receive shipments") 9. edit vendor: a. hit enter when you add an alias: the form is submitted. This is a regression, we prevented that in the current code with: acqui/supplier.tt:596 nodes.append("<input id='new_alias' type='text' class='noEnterSubmit' />"); b. enter "foo" in discount: cannot save, no error on the UI, 400 in the response: {"errors":[{"message":"Expected number\/null - got string.","path":"\/body\/discount"}],"status":400} c. enter 111 in the discount, cannot save, no error on the UI, 500 in the response. Koha log has: Out of range value for column 'discount' d. delete an interface not working: "Uncaught TypeError: _ctx.deleteContact is not a function" 10. cannot edit from the list view: Uncaught Error: Missing required param "id" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #277 from Jonathan Druart <jonathan.druart@gmail.com> --- 11. We lost test on email and URI fields: Account email: Please enter a valid email address. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #278 from Jonathan Druart <jonathan.druart@gmail.com> --- QA review 1. We really should move C4::Contracts to Koha::Acquisition::Contract[s] before. It does not make sense to use C4::Contracts from Koha::Acquisition. The module is pretty trivial to replace. 2. I had the feeling there was something wrong in Koha::Acq::Bookseller::to_api, I think it causes this bug: Edit a vendor, add 2 interfaces, `select * from aqbookseller_interfaces` Edit again, don't change anything, save, select again MariaDB [koha_kohadev]> select interface_id, vendor_id, password from aqbookseller_interfaces\G *************************** 1. row *************************** interface_id: 8 vendor_id: 2 password: 53616c7465645f5fb2f929cb1abe15d15f9a6c54e9b38977a8055ece428f2c75 *************************** 2. row *************************** interface_id: 9 vendor_id: 2 password: 53616c7465645f5f2919e4566b6dacdaf29690ff2193f006bd55e843cb6ee0ae 2 rows in set (0.001 sec) MariaDB [koha_kohadev]> select interface_id, vendor_id, password from aqbookseller_interfaces\G *************************** 1. row *************************** interface_id: 10 vendor_id: 2 password: 53616c7465645f5f0b3f2ebce9124cd14317d4fe111dd0aeedaf9532460e9e43 *************************** 2. row *************************** interface_id: 11 vendor_id: 2 password: 53616c7465645f5ffd9ed9b565602e77db7510110fde8cfb43af971d46aefa3f No changes expected, we should not add another id. 3. We lost the "Show" password link + <p><span>Password: <span class="password"><a href="#" class="show_password" data-plain-text-password="[% i.plain_text_password | html %]">Show</a></span></span></p> We discussed it previously, but I actually didn't notice that this is something we have currently. Need to be re-discussed maybe. We also had bug 34778 since then. 4. (In reply to Jonathan Druart from comment #205)
Koha/Schema/Result/Aqbookseller.pm +__PACKAGE__->has_many( + "aliases", + "Koha::Schema::Result::AqbooksellerAlias",
Why?
We already have Koha::Acquisition::Bookseller->aliases, when is this used?
Still valid. 5. Koha/REST/V1/Acquisitions/Vendors.pm 92 my $subscriptions = delete $vendor->{subscriptions}; 93 my $baskets = delete $vendor->{baskets}; 94 my $contracts = delete $vendor->{contracts}; Why? 6. Manual link This needs to be adjusted Koha/Manual.pm: 'acqui/supplier' => '/acquisitions.html#vendors', 7. DELETE /vendors/:id should use apiclient (acq.js) 8. acqui/booksellers | supplier We pass the idea 118 supplier => $booksellerid, But consider it a vendor object in the template: 12 [% tx("Search for vendor {vendor}", { vendor = supplier }) | html %] 35 <span>Search for vendor [% supplier | $HtmlTags tag='em' %]</span> 8. vendors.tt a. +<div id="__vendors"> is this "__" to avoid conflict? b. I don't think we need that: + [% SET columns = ['cardnumber','name','category','branch','action'] %] + [% PROCESS patron_search_modal columns => columns, modal_title => t("Select user") %] + [% PROCESS patron_search_js columns => columns, filter => erm_users, actions => ["select"], preview_on_name_click => 1 %] 9. store/vendors has config.edifact = false But we actually have more in the config: userPermissions, marcOrderAutomation, currencies, gstValues I think this should be moved to the config route anyway (bug 38930) 10. Contracts table on the vendor show view is not correctly styled: https://snipboard.io/QHdc8N.jpg 11. i18n problems in VendorList: + escape_str( + `${row.baskets.length} basket(s)` + ) + + escape_str( + `${row.subscriptions_count} subscription(s)` + ) + and missing escape_str + row.name + 12: 2 QA failures: FAIL acqui/booksellers.pl FAIL critic # Variables::ProhibitUnusedVariables: Got 1 violation(s). FAIL acqui/vendors.pl FAIL file permissions File must have the exec flag -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #279 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #278)
QA review
2. I had the feeling there was something wrong in Koha::Acq::Bookseller::to_api, I think it causes this bug: Edit a vendor, add 2 interfaces, `select * from aqbookseller_interfaces` Edit again, don't change anything, save, select again
MariaDB [koha_kohadev]> select interface_id, vendor_id, password from aqbookseller_interfaces\G *************************** 1. row *************************** interface_id: 8 vendor_id: 2 password: 53616c7465645f5fb2f929cb1abe15d15f9a6c54e9b38977a8055ece428f2c75 *************************** 2. row *************************** interface_id: 9 vendor_id: 2 password: 53616c7465645f5f2919e4566b6dacdaf29690ff2193f006bd55e843cb6ee0ae 2 rows in set (0.001 sec)
MariaDB [koha_kohadev]> select interface_id, vendor_id, password from aqbookseller_interfaces\G *************************** 1. row *************************** interface_id: 10 vendor_id: 2 password: 53616c7465645f5f0b3f2ebce9124cd14317d4fe111dd0aeedaf9532460e9e43 *************************** 2. row *************************** interface_id: 11 vendor_id: 2 password: 53616c7465645f5ffd9ed9b565602e77db7510110fde8cfb43af971d46aefa3f
No changes expected, we should not add another id.
Hum, retested this on main and it's the current behaviour, not blocker! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #280 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- (In reply to Jonathan Druart from comment #278)
QA review
1. We really should move C4::Contracts to Koha::Acquisition::Contract[s] before. It does not make sense to use C4::Contracts from Koha::Acquisition. The module is pretty trivial to replace.
I can do this but I think it should be a separate follow-up bug so that the change isn't lost in this code
3. We lost the "Show" password link + <p><span>Password: <span class="password"><a href="#" class="show_password" data-plain-text-password="[% i.plain_text_password | html %]">Show</a></span></span></p>
We discussed it previously, but I actually didn't notice that this is something we have currently. Need to be re-discussed maybe. We also had bug 34778 since then.
I think we should have a Vue component for handling this - I can add one but again that should probably be a separate follow-up
4. (In reply to Jonathan Druart from comment #205)
Koha/Schema/Result/Aqbookseller.pm +__PACKAGE__->has_many( + "aliases", + "Koha::Schema::Result::AqbooksellerAlias",
Why?
We already have Koha::Acquisition::Bookseller->aliases, when is this used?
Still valid.
This was so that I could embed directly via the API - I couldn't seem to get it to work with just the method itself. Maybe I'm missing something?
5. Koha/REST/V1/Acquisitions/Vendors.pm 92 my $subscriptions = delete $vendor->{subscriptions}; 93 my $baskets = delete $vendor->{baskets}; 94 my $contracts = delete $vendor->{contracts}; Why?
They need to be deleted before we store otherwise the store operation fails - I've changed them to just be delete clauses with no variable declaration
6. Manual link This needs to be adjusted Koha/Manual.pm: 'acqui/supplier' => '/acquisitions.html#vendors',
Updated - we might need a new bug for an issue here as any url parameters in the Vue modules break the links - same happens in ERM, you just get the manual homepage
7. DELETE /vendors/:id should use apiclient (acq.js)
This feels like a follow-up as well, not directly related to the vendors code
8. acqui/booksellers | supplier We pass the idea 118 supplier => $booksellerid, But consider it a vendor object in the template: 12 [% tx("Search for vendor {vendor}", { vendor = supplier }) | html %] 35 <span>Search for vendor [% supplier | $HtmlTags tag='em' %]</span>
I've changed the variable to booksellerid - we don't use the supplier object now that it is just for baskets
8. vendors.tt a. +<div id="__vendors"> is this "__" to avoid conflict? b. I don't think we need that: + [% SET columns = ['cardnumber','name','category','branch','action'] %] + [% PROCESS patron_search_modal columns => columns, modal_title => t("Select user") %] + [% PROCESS patron_search_js columns => columns, filter => erm_users, actions => ["select"], preview_on_name_click => 1 %]
a. Changed to just be vendors b. Deleted these as they're redundant
9. store/vendors has config.edifact = false But we actually have more in the config: userPermissions, marcOrderAutomation, currencies, gstValues I think this should be moved to the config route anyway (bug 38930)
Will upload the config route for 38930 shortly and then rebase this
10. Contracts table on the vendor show view is not correctly styled: https://snipboard.io/QHdc8N.jpg
Pager removed to match main
11. i18n problems in VendorList: + escape_str( + `${row.baskets.length} basket(s)` + ) +
+ escape_str( + `${row.subscriptions_count} subscription(s)` + ) +
and missing escape_str + row.name +
Fixed
12: 2 QA failures: FAIL acqui/booksellers.pl
FAIL critic
# Variables::ProhibitUnusedVariables: Got 1 violation(s).
FAIL acqui/vendors.pl
FAIL file permissions
File must have the exec flag
Fixed I've addressed the bugs in comments 276 and 277 as well - they're all on the openfifth/bug_38010 branch as the attachment list is getting too long -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39709 --- Comment #281 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #276)
1. Should we provide more rewrite rule to not break existing bookmarks? For instance http://localhost:8081/cgi-bin/koha/acqui/supplier.pl?booksellerid=1 now returns 404
Still valid.
3. breadcrumb: http://localhost:8081/cgi-bin/koha/vendors?supplier=my+vendor Click "Vendors" in the breadcrumb: http://localhost:8081/cgi-bin/koha/vendors?supplier=my+vendor# Expected: see all vendors Not a regression, and not sure we can fix here.
Still valid, opened bug 39709.
4. Filtering: http://localhost:8081/cgi-bin/koha/vendors?supplier=my+vendor "Showing 1 to 1 of 1 entries (filtered from 3 total entries)" But you have no way to remove the filtering and see all vendors It is the current behaviour in main, but at least we had "Search for vendor my vendor" in the breadcrumb
Still valid, and this is confusing IMO.
6. http://localhost:8081/cgi-bin/koha/vendors/2 Warning in the console: [Vue Router warn]: Discarded invalid param(s) "vendor_id" when navigating.
Still valid.
8. show vendor view: a. website is a button: https://snipboard.io/16ZLPA.jpg (same for the interfaces)
Still a problem, the link is not clickable (missing href)
9. edit vendor: a. hit enter when you add an alias: the form is submitted. This is a regression, we prevented that in the current code with: acqui/supplier.tt:596 nodes.append("<input id='new_alias' type='text' class='noEnterSubmit' />");
Fixed but now we cannot remove an alias, there is a JS error in the console: "Uncaught ReferenceError: e is not defined"
b. enter "foo" in discount: cannot save, no error on the UI, 400 in the response: {"errors":[{"message":"Expected number\/null - got string.","path":"\/body\/discount"}],"status":400}
Better. There is a change in the behaviour however. Before we display %.1f, now we display what is in the DB. There is only one inconsistency: 1.234 is considered valid, 1.2345 is not and the error says "Please enter a decimal number in the format: 0.0". It's not clear why 3 decimals. If it's a float it should go as it. Not considering blocker. (In reply to Jonathan Druart from comment #277)
11. We lost test on email and URI fields: Account email: Please enter a valid email address.
Email should be fixed with only `type="email"` however the URI check is still a problem. New ones: 12. http://localhost:8081/cgi-bin/koha/acquisition/vendors/1 * Missing "Receive shipment" * Missing space "+New" https://snipboard.io/WpbPck.jpg 13. Edit a vendor, open 2 contact blocks. Tick all options for first contact, then tick all for second contact: => Two from the first contact are unchecked: https://snipboard.io/SLNiJI.jpg 14. It's missing "%" for the discount display on the vendor show view: https://snipboard.io/hUw8dQ.jpg (In reply to Matt Blenkinsop from comment #280)
(In reply to Jonathan Druart from comment #278)
QA review
1. We really should move C4::Contracts to Koha::Acquisition::Contract[s] before. It does not make sense to use C4::Contracts from Koha::Acquisition. The module is pretty trivial to replace.
I can do this but I think it should be a separate follow-up bug so that the change isn't lost in this code
Should have been done before this one, now it's kinda too late for 25.05. I let you decide what to do. Adding new uses of C4 from Koha should be avoided as much as possible. If you do not decide to move it before this patch set, then please open a follow-up bug report.
3. We lost the "Show" password link + <p><span>Password: <span class="password"><a href="#" class="show_password" data-plain-text-password="[% i.plain_text_password | html %]">Show</a></span></span></p>
We discussed it previously, but I actually didn't notice that this is something we have currently. Need to be re-discussed maybe. We also had bug 34778 since then.
I think we should have a Vue component for handling this - I can add one but again that should probably be a separate follow-up
It's a regression caused by this change, not sure why we would need a separate bug. If you really think we should split then do but please provide a patch ASAP.
4. (In reply to Jonathan Druart from comment #205)
Koha/Schema/Result/Aqbookseller.pm +__PACKAGE__->has_many( + "aliases", + "Koha::Schema::Result::AqbooksellerAlias",
Why?
We already have Koha::Acquisition::Bookseller->aliases, when is this used?
Still valid.
This was so that I could embed directly via the API - I couldn't seem to get it to work with just the method itself. Maybe I'm missing something?
It was invalid indeed. You need it for the order, not the embed: _order_by=+me.name,+aliases.alias,+me.id
6. Manual link This needs to be adjusted Koha/Manual.pm: 'acqui/supplier' => '/acquisitions.html#vendors',
Updated - we might need a new bug for an issue here as any url parameters in the Vue modules break the links - same happens in ERM, you just get the manual homepage
Can you open a bug report please?
7. DELETE /vendors/:id should use apiclient (acq.js)
This feels like a follow-up as well, not directly related to the vendors code
It's done now, thanks! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39709 [Bug 39709] "Vendors" link in the breadcrumb should list all the vendors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #282 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- (In reply to Jonathan Druart from comment #281)
(In reply to Jonathan Druart from comment #276)
1. Should we provide more rewrite rule to not break existing bookmarks? For instance http://localhost:8081/cgi-bin/koha/acqui/supplier.pl?booksellerid=1 now returns 404
Still valid.
Fixed - redirect added to the new show page
4. Filtering: http://localhost:8081/cgi-bin/koha/vendors?supplier=my+vendor "Showing 1 to 1 of 1 entries (filtered from 3 total entries)" But you have no way to remove the filtering and see all vendors It is the current behaviour in main, but at least we had "Search for vendor my vendor" in the breadcrumb
Still valid, and this is confusing IMO.
See 'Bug 38010: (QA follow-up) Stop breadcrumbs from keeping filters' for a concept - allows us to reuse it for future breadcrumbs as well
6. http://localhost:8081/cgi-bin/koha/vendors/2 Warning in the console: [Vue Router warn]: Discarded invalid param(s) "vendor_id" when navigating.
Still valid.
This is still happening in all Vue apps - I'm not entirely sure why, needs some deeper investigation
8. show vendor view: a. website is a button: https://snipboard.io/16ZLPA.jpg (same for the interfaces)
Still a problem, the link is not clickable (missing href)
Typo - fixed
9. edit vendor: a. hit enter when you add an alias: the form is submitted. This is a regression, we prevented that in the current code with: acqui/supplier.tt:596 nodes.append("<input id='new_alias' type='text' class='noEnterSubmit' />");
Fixed but now we cannot remove an alias, there is a JS error in the console: "Uncaught ReferenceError: e is not defined"
Fixed
(In reply to Jonathan Druart from comment #277)
11. We lost test on email and URI fields: Account email: Please enter a valid email address.
Email should be fixed with only `type="email"` however the URI check is still a problem.
I've added the type - do you mean the URI field on the form for interfaces or the email more generally?
New ones: 12. http://localhost:8081/cgi-bin/koha/acquisition/vendors/1 * Missing "Receive shipment" * Missing space "+New" https://snipboard.io/WpbPck.jpg
Can't reproduce the first, Receive shipment shows for me - did you delete the baskets for the vendor? Space added to the "New" button
13. Edit a vendor, open 2 contact blocks. Tick all options for first contact, then tick all for second contact: => Two from the first contact are unchecked: https://snipboard.io/SLNiJI.jpg
This is the expected behaviour as we should only have one primary contact of each type - supplier.tt line 700 in main
14. It's missing "%" for the discount display on the vendor show view: https://snipboard.io/hUw8dQ.jpg
Fixed
(In reply to Matt Blenkinsop from comment #280)
(In reply to Jonathan Druart from comment #278)
QA review
1. We really should move C4::Contracts to Koha::Acquisition::Contract[s] before. It does not make sense to use C4::Contracts from Koha::Acquisition. The module is pretty trivial to replace.
I can do this but I think it should be a separate follow-up bug so that the change isn't lost in this code
Should have been done before this one, now it's kinda too late for 25.05. I let you decide what to do. Adding new uses of C4 from Koha should be avoided as much as possible.
If you do not decide to move it before this patch set, then please open a follow-up bug report.
Follow-up opened (39711) - I've already started the code for it
3. We lost the "Show" password link + <p><span>Password: <span class="password"><a href="#" class="show_password" data-plain-text-password="[% i.plain_text_password | html %]">Show</a></span></span></p>
We discussed it previously, but I actually didn't notice that this is something we have currently. Need to be re-discussed maybe. We also had bug 34778 since then.
I think we should have a Vue component for handling this - I can add one but again that should probably be a separate follow-up
It's a regression caused by this change, not sure why we would need a separate bug. If you really think we should split then do but please provide a patch ASAP.
I've added a patch to the branch which gives the 'Show password' functionality
6. Manual link This needs to be adjusted Koha/Manual.pm: 'acqui/supplier' => '/acquisitions.html#vendors',
Updated - we might need a new bug for an issue here as any url parameters in the Vue modules break the links - same happens in ERM, you just get the manual homepage
Can you open a bug report please?
Done - bug 37912 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39711 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39711 [Bug 39711] Migrate C4::Contract to object classes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178182|0 |1 is obsolete| | Attachment #178183|0 |1 is obsolete| | Attachment #178184|0 |1 is obsolete| | Attachment #178185|0 |1 is obsolete| | Attachment #178186|0 |1 is obsolete| | Attachment #178187|0 |1 is obsolete| | Attachment #178188|0 |1 is obsolete| | Attachment #178189|0 |1 is obsolete| | Attachment #178190|0 |1 is obsolete| | Attachment #178191|0 |1 is obsolete| | Attachment #178192|0 |1 is obsolete| | Attachment #178193|0 |1 is obsolete| | Attachment #178194|0 |1 is obsolete| | Attachment #178195|0 |1 is obsolete| | Attachment #178196|0 |1 is obsolete| | Attachment #178197|0 |1 is obsolete| | Attachment #178198|0 |1 is obsolete| | Attachment #178199|0 |1 is obsolete| | Attachment #178200|0 |1 is obsolete| | Attachment #178201|0 |1 is obsolete| | Attachment #178202|0 |1 is obsolete| | Attachment #178203|0 |1 is obsolete| | Attachment #178204|0 |1 is obsolete| | Attachment #178205|0 |1 is obsolete| | Attachment #178206|0 |1 is obsolete| | Attachment #178207|0 |1 is obsolete| | Attachment #178208|0 |1 is obsolete| | Attachment #178209|0 |1 is obsolete| | Attachment #178210|0 |1 is obsolete| | Attachment #178211|0 |1 is obsolete| | Attachment #178212|0 |1 is obsolete| | Attachment #178213|0 |1 is obsolete| | Attachment #178214|0 |1 is obsolete| | Attachment #178215|0 |1 is obsolete| | Attachment #178216|0 |1 is obsolete| | Attachment #178217|0 |1 is obsolete| | Attachment #178218|0 |1 is obsolete| | Attachment #178219|0 |1 is obsolete| | Attachment #178220|0 |1 is obsolete| | Attachment #178221|0 |1 is obsolete| | Attachment #178222|0 |1 is obsolete| | Attachment #178223|0 |1 is obsolete| | Attachment #178224|0 |1 is obsolete| | Attachment #178225|0 |1 is obsolete| | Attachment #178226|0 |1 is obsolete| | Attachment #178227|0 |1 is obsolete| | Attachment #178228|0 |1 is obsolete| | Attachment #178229|0 |1 is obsolete| | Attachment #178230|0 |1 is obsolete| | Attachment #178231|0 |1 is obsolete| | Attachment #178232|0 |1 is obsolete| | Attachment #178233|0 |1 is obsolete| | Attachment #178234|0 |1 is obsolete| | Attachment #178235|0 |1 is obsolete| | Attachment #178236|0 |1 is obsolete| | Attachment #178237|0 |1 is obsolete| | Attachment #178238|0 |1 is obsolete| | Attachment #178239|0 |1 is obsolete| | Attachment #178240|0 |1 is obsolete| | Attachment #178241|0 |1 is obsolete| | Attachment #178242|0 |1 is obsolete| | --- Comment #283 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181579&action=edit Bug 38010: (QA follow-up) Add a 'Show password' option -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181579|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/openfift | |h/koha/commits/bug_38010 --- Comment #284 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Attached the url now rather than having so many patches on the bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #285 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181585&action=edit Bug 38010: (bugfix) Show contract of the basket if inactive If the contract is inactive it should be displayed on the basket edit view. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181585|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39764, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37912 --- Comment #286 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Matt Blenkinsop from comment #282)
(In reply to Jonathan Druart from comment #281)
4. Filtering: http://localhost:8081/cgi-bin/koha/vendors?supplier=my+vendor "Showing 1 to 1 of 1 entries (filtered from 3 total entries)" But you have no way to remove the filtering and see all vendors It is the current behaviour in main, but at least we had "Search for vendor my vendor" in the breadcrumb
Still valid, and this is confusing IMO.
See 'Bug 38010: (QA follow-up) Stop breadcrumbs from keeping filters' for a concept - allows us to reuse it for future breadcrumbs as well
Great. Still not perfect however, IMO we need a way to reset the filters near the table. But it's a good start. We will see what end-users say.
6. http://localhost:8081/cgi-bin/koha/vendors/2 Warning in the console: [Vue Router warn]: Discarded invalid param(s) "vendor_id" when navigating.
Still valid.
This is still happening in all Vue apps - I'm not entirely sure why, needs some deeper investigation
Opened bug 39764.
(In reply to Jonathan Druart from comment #277)
11. We lost test on email and URI fields: Account email: Please enter a valid email address.
Email should be fixed with only `type="email"` however the URI check is still a problem.
I've added the type - do you mean the URI field on the form for interfaces or the email more generally?
The 2 email fields (interface and contacts) are now solved with type="email". However we lost the URI check on "Company's details: Website". Not blocker, not considering it really important for now.
New ones: 12. http://localhost:8081/cgi-bin/koha/acquisition/vendors/1 * Missing "Receive shipment" * Missing space "+New" https://snipboard.io/WpbPck.jpg
Can't reproduce the first, Receive shipment shows for me - did you delete the baskets for the vendor?
Oops, yes I guess so! Forget that.
13. Edit a vendor, open 2 contact blocks. Tick all options for first contact, then tick all for second contact: => Two from the first contact are unchecked: https://snipboard.io/SLNiJI.jpg
This is the expected behaviour as we should only have one primary contact of each type - supplier.tt line 700 in main
Indeed, it's confusing :D Sorry! Forget that as well. All good for me. I will do another round of code review and test tomorrow. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community |https://bugs.koha-community |.org/bugzilla3/show_bug.cgi |.org/bugzilla3/show_bug.cgi |?id=37912 |?id=39712 --- Comment #287 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Matt Blenkinsop from comment #282)
(In reply to Jonathan Druart from comment #281)
6. Manual link This needs to be adjusted Koha/Manual.pm: 'acqui/supplier' => '/acquisitions.html#vendors',
Updated - we might need a new bug for an issue here as any url parameters in the Vue modules break the links - same happens in ERM, you just get the manual homepage
Can you open a bug report please?
Done - bug 37912
Actually bug 39712. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #288 from Michaela Sieber <michaela.sieber@kit.edu> --- tested and from an end-user perspective no blockers for the upcoming release. Minor enhancements could be solved as follow-up bugs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #289 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Michaela Sieber from comment #288)
tested and from an end-user perspective no blockers for the upcoming release. Minor enhancements could be solved as follow-up bugs
Did you note the minor enhancements you would like to see? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39776 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39776 [Bug 39776] VueJS - Inconsistencies for icons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39785 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39785 [Bug 39785] We need tests for Vue module config endpoints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #290 from Jonathan Druart <jonathan.druart@gmail.com> --- Changes in behaviour: new a vendor cannot be deleted if it has invoices linked to it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39794 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39794 [Bug 39794] Improve 404 for VueJS components -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39795 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39795 [Bug 39795] Data loss when editing vendor.addressX -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39796 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39796 [Bug 39796] Format discount and tax rate code should be moved out of the vue component -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39797 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39797 [Bug 39797] Cypress tests Acquisitions/Vendors_spec.ts should not have a whole vendor object -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #291 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181727&action=edit Bug 38010: Add vue app and list component This patch adds the base vue app as well as the component to list vendors Amended-by: Jonathan Druart chmod 755 acqui/vendors.pl Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #292 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181728&action=edit Bug 38010: Add the component to display a vendor Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #293 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181729&action=edit Bug 38010: Add permissions This patch adds a permissions store and utility methods for implementing permissions checks in a Vue app Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #294 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181730&action=edit Bug 38010: Add authorised values Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #295 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181731&action=edit Bug 38010: Rename routes to acquisitions This patch renames the app from vendors to acquisitions to allow further acquisitions pages to be migrated Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #296 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181732&action=edit Bug 38010: Add the form to add a new vendor Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #297 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181733&action=edit Bug 38010: Update navigation links Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #298 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181734&action=edit Bug 38010: Allow external breadcrumbs This patch allows breadcrumbs to navigate to pages outside the Vue application Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #299 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181735&action=edit Bug 38010: Add a contracts table to the vendor show component Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #300 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181736&action=edit Bug 38010: Remove drawCallback from contracts table Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #301 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181737&action=edit Bug 38010: Add permissions to action buttons Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #302 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181738&action=edit Bug 38010: Make the delete button conditional on whether a vendor has baskets or subscriptions Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #303 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181739&action=edit Bug 38010: Add cypress tests Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #304 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181740&action=edit Bug 38010: Adjust vendor update logic This patch handles the embedded data that might also need updating when editing a vendor Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #305 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181741&action=edit Bug 38010: Fix vendors search bar Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #306 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181742&action=edit Bug 38010: Update links to vendor module Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #307 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181743&action=edit Bug 38010: Rebase for Button component change Bug 38010: Fix rspack error in VendorShow Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #308 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181744&action=edit Bug 38010: Add basket page Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #309 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181745&action=edit Bug 38010: Allow embedding for baskets table Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #310 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181746&action=edit Bug 38010: Point basket action buttons to correct pages Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #311 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181747&action=edit Bug 38010: Fix null basket names Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #312 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181748&action=edit Bug 38010: Respect AcqViewBaskets syspref Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #313 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181749&action=edit Bug 38010: Add delete contact button Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #314 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181750&action=edit Bug 38010: Add menu components for vendor and acquisitions menus Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #315 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181751&action=edit Bug 38010: Implement side menus in vendors app Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #316 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181752&action=edit Bug 38010: Allow searching by alias in the vendors table Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #317 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181753&action=edit Bug 38010: Form fixes Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #318 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181754&action=edit Bug 38010: Rebase for bug 38390 Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #319 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181755&action=edit Bug 38010: Add receive shipments action to table Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #320 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181756&action=edit Bug 38010: Restore new basket/contract buttons Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #321 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181757&action=edit Bug 38010: Add dropdown button component Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #322 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181758&action=edit Bug 38010: Reset basket view Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #323 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181759&action=edit Bug 38010: Remove unnecessary navigation check Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #324 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181760&action=edit Bug 38010: Fix tax rate display Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #325 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181761&action=edit Bug 38010: Add callbacks to Toolbarbutton Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #326 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181762&action=edit Bug 38010: Fix acqui-home.pl breadcrumbs Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #327 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181763&action=edit Bug 38010: Fix programmatic navigation id attribute Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #328 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181764&action=edit Bug 38010: Remove unneccessary test Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #329 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181765&action=edit Bug 38010: Delete old code Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #330 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181766&action=edit Bug 38010: Fix navigation links Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #331 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181767&action=edit Bug 38010: Prevent vendor contacts from duplicating Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #332 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181768&action=edit Bug 38010: Check for baskets for receive shipments button Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #333 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181769&action=edit Bug 38010: Check for invoices before allowing vendor deletion Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #334 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181770&action=edit Bug 38010: Only allow one primary contact Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #335 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181771&action=edit Bug 38010: Remove unnecessary buttons Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #336 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181772&action=edit Bug 38010: Apply format_date to vendor contracts Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #337 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181773&action=edit Bug 38010: Change how interface details are displayed Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #338 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181774&action=edit Bug 38010: (QA follow-up) Template fixes Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #339 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181775&action=edit Bug 38010: (QA follow-up) Fix new vendor form Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #340 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181776&action=edit Bug 38010: (QA follow-up) Restore navigation links This patch restores any links that previously pointed to booksellers.pl as this script is still in use. All references to supplier.pl remain pointed at the new Vue app Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #341 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181777&action=edit Bug 38010: (QA follow-up) Fix delete button Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #342 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181778&action=edit Bug 38010: (QA follow-up) Fix vendor show component Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #343 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181779&action=edit Bug 38010: (QA follow-up) Use format_price Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #344 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181780&action=edit Bug 38010: (QA follow-up) Rebase acquisitions amd vendor menus Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #345 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181781&action=edit Bug 38010: (QA follow-up) Remove unnecessary code from booksellers.pl Bug 38010: (QA follow-up) Fix QA tests Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #346 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181782&action=edit Bug 38010: (QA follow-up) Rebase for bug 37930 Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #347 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181783&action=edit Bug 38010: (QA follow-up) Rebase for bug 38854 Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #348 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181784&action=edit Bug 38010: (QA follow-up) Convert vendor menu to Vue island Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #349 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181785&action=edit Bug 38010: (QA follow-up) Add unit tests Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #350 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181786&action=edit Bug 38010: (QA follow-up) Fix toolbar on VendorShow The delete button was missing from VendorShow and bug 37301 has been removed as a dependency so some small fixes were required for that Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #351 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181787&action=edit Bug 38010: (QA follow-up) Update routes to include 'acquisition' Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #352 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181788&action=edit Bug 38010: (QA follow-up) Redirect Home component to List Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #353 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181789&action=edit Bug 38010: (QA follow-up) Move island hydration to container wrapper Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #354 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181790&action=edit Bug 38010: (QA follow-up) Fix issues in Show component This patch addresses the following: - website links were buttons so we now can pass a css class to the toolbar buttons again - contact options have been formatted to have the correct margin - the dropdown-item class has been added to the dropdown button list - entries in the dropdown were opening in a new tab, they are now a callback to avoid this Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #355 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181791&action=edit Bug 38010: (QA follow-up) Fix issues on vendor edit page This commit addresses the following: - Prevents form submission when hitting enter in the alias field - validation for the discount field - restores delete functionality to interfaces - fixes the broken edit button on the list view Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #356 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181792&action=edit Bug 38010: (QA follow-up) Adjust mapping for the manual Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #357 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181793&action=edit Bug 38010: (QA follow-up) UI fixes This patch addresses - Translation issues in VendorList - Removing the pagers from the contracts table - Removing redundant code from the vendors template file Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #358 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181794&action=edit Bug 38010: (QA follow-up) Handle form parameters in the browser Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #359 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181795&action=edit Bug 38010: (QA follow-up) Rebase on main Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #360 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181796&action=edit Bug 38010: (QA follow-up) Convert delete modal to use the API client Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #361 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181797&action=edit Bug 38010: (QA follow-up) Add a config endpoint for permissions Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #362 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181798&action=edit Bug 38010: (QA follow-up) Email type checking and UI fixes Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #363 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181799&action=edit Bug 38010: (QA follow-up) Stop breadcrumbs from keeping filters Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #364 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181800&action=edit Bug 38010: (QA follow-up) Add new apache redirect Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #365 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181801&action=edit Bug 38010: (QA follow-up) Add a 'Show password' option Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #366 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181802&action=edit Bug 38010: Improve show/hide password icon Use font-awesome-icon tag and add "hide" Also prevent the scrollbar to jump when the link is clicked (removing href) (cherry picked from commit 78876ee276cf0af6e307cd7a033bbbe2842e1dc1) Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #367 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181803&action=edit Bug 38010: (QA follow-up) Add a Link component Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #368 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181804&action=edit Bug 38010: (QA follow-up) Add missing filter to main-container.inc Amended-by: Jonathan Druart -[% SET islands = Asset.js("js/vue/dist/islands.esm.js").match('(src="([^"]+)")').1 | $raw %] <script src="[% islands %]" type="module"> +[% SET islands = Asset.js("js/vue/dist/islands.esm.js").match('(src="([^"]+)")').1 %] <script src="[% islands | $raw %]" type="module"> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #369 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181805&action=edit Bug 38010: (QA follow-up) Remove extra sidebar_menu class Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #370 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181806&action=edit Bug 38010: Remove op=do_search from the 'Invoices' link So we don't see "no result for your search" (cherry picked from commit 1cc3dabaa25d503b6b6b7d49d81c9bf739013d10) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #371 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181807&action=edit Bug 38010: Code improvement (cherry picked from commit a14f1898672950be9d9097bc7b5dd56392a241b0) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #372 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181808&action=edit Bug 38010: Fix links to the manual The way we deal with routes for VueJS is messy and will need to be reconsidered, but it's not within the scope of this patch. (cherry picked from commit 2558583ef0fbf149664a3d9a2e3cec081ac505ff) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #373 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181809&action=edit Bug 38010: Fix wrong use of scalar in the REST API controller It was wrong, we need to use scalar on the array, not the arrayref (otherwise it will always be true) No change in behaviour expected here, just some code cleaning (cherry picked from commit 7abbcb7ba73da13d988202aaf06ba239e21692da) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #374 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181810&action=edit Bug 38010: Add tests for embed contacts,interfaces,aliases (cherry picked from commit cae75569e6e8f2bfe5a2e6d3acc111485f81cc1e) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #375 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181811&action=edit Bug 38010: (QA follow-up) Move syspref values to config endpoint Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #376 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181812&action=edit Bug 38010: Fix LeftMenu (cherry picked from commit a78af54eebf07a623779f4642bcdad28f35e662f) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #377 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181813&action=edit Bug 38010: Embed baskets+count and subscriptions+count We don't need to whole list of baskets and subscriptions (cherry picked from commit 391b4d3b32b57c97bfb7e66ab394020ae7eed0e5) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #378 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181814&action=edit Bug 38010: Migrate to_api logic to GET endpoint Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #379 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181815&action=edit Bug 38010: Translation fix Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #380 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181816&action=edit Bug 38010: Add protection logic to the DELETE endpoint Amended-by: Jonathan Druart typo: subsicriptions => subscriptions Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #381 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181817&action=edit Bug 38010: (QA follow-up) Add default settings to vendor store Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #382 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181818&action=edit Bug 38010: Fix vendor deletion tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #383 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181819&action=edit Bug 38010: Add tests for DELETE vendors/{vendor_id} Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #384 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181820&action=edit Bug 38010: Fix cypress tests - do not intercept /config We do not want to intercept /acquisitions/vendors/config Ideally we should mock it separately Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #385 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181821&action=edit Bug 38010: Fix cypress tests - add _count to the mock object Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #386 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 95 patches... ugh. Did some testing, found some smaller and some odder things, no deal breakers, but I believe in quick follow-ups before release! 1) Terminology (follow-up) + description: List of GST values We removed GST as a term a while ago, I think this should probably read: List of tax rates + description: EDIFACT syspref value + description: MarcOrderingAutomation syspref value Please always spell out system preference instead of using the short form. (see Terminology list on wiki) 2) Vendor result list a) Currency takes a lot of width, not sure why. But it's also ambiguous. Can you please clarify if it's the list price currency or invoice price currency? (follow-up, string change) b) I think the vendor result table would greatly benefit from being column configurable (separate bug, can file later) c) The action column should be excluded from exports and print preview. (follow-up) d) Alias: if a vendor is found by searching for it's alias, it would be nice if there was some visual indicator. Maybe when adding column configuration we could add a column displaying the alias? (possible enhancement, can file later) 3) Managing vendors a) Encoding problem for the interface password (separate bug) - Create a new vendor - Add an interface with a password: KölnHamburgBerlinMünster - Save - Edit: The password umlauts appear mangled ... Now I was going to mark this blocker, but it already happens in 24.11... b) Deleting vendor only works from result list (follow-up or separate bug) In 24.11 we have a "Delete vendor" in the toolbar you can see on the vendor's detail page. With this patch set the "Delete" link only appears in the vendor result list. It works from there, so the vendor was "deletable" (no orders or subscriptions linked). 4) Managing contracts (follow-up or separate bug) a) Start and end date missing mark-up for sorting correctly with different date formats. This works in 24.11 (regression). The styling of the contacts table also appears a little odd, like dates should be aligned right etc.? X) Should not always complain, bonus points for: * Updating links to help files * Updating POD * Switching suppliers.pl to vendors.pl * Translatability :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #387 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #388 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181891&action=edit Bug 38010: Fix xt/api.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #389 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #388)
Created attachment 181891 [details] [review] Bug 38010: Fix xt/api.t
Patch pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39826 --- Comment #390 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Katrin Fischer from comment #386)
3) Managing vendors
a) Encoding problem for the interface password (separate bug)
- Create a new vendor - Add an interface with a password: KölnHamburgBerlinMünster - Save - Edit: The password umlauts appear mangled ... Now I was going to mark this blocker, but it already happens in 24.11...
Opened bug 39826. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #391 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181898&action=edit Bug 38010: Embed invoices_count - fix patron deletion from show view Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #392 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Katrin Fischer from comment #386)
b) Deleting vendor only works from result list (follow-up or separate bug)
In 24.11 we have a "Delete vendor" in the toolbar you can see on the vendor's detail page. With this patch set the "Delete" link only appears in the vendor result list. It works from there, so the vendor was "deletable" (no orders or subscriptions linked).
Done on the last patch. (In reply to Jonathan Druart from comment #391)
Created attachment 181898 [details] [review] Bug 38010: Embed invoices_count - fix patron deletion from show view
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #393 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181901&action=edit Bug 38010: Restore ordering on the contracts table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39836 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39836 [Bug 39836] Vendor contact object under specified -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39837 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39837 [Bug 39837] Vendor interfaces object under specified -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39838 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39838 [Bug 39838] Vendor alias object under specified -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #394 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181963&action=edit Bug 38010: (follow-up) Fix API spec terminology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #395 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 181964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181964&action=edit Bug 38010: (follow-up) Make vendor table columns configurable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #396 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I could apply Matts 2 follow-ups, but I get an sha1 error on yours Joubu: Apply? [(y)es, (n)o, (i)nteractive] i Applying: Bug 38010: Restore ordering on the contracts table error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorContracts.vue). error: could not build fake ancestor It doesn't appear to be pushed either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39858 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39858 [Bug 39858] Cannot save vendor if it has invoices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181901|0 |1 is obsolete| | --- Comment #397 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182053&action=edit Bug 38010: Restore ordering on the contracts table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #398 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Katrin Fischer from comment #396)
I could apply Matts 2 follow-ups, but I get an sha1 error on yours Joubu:
Apply? [(y)es, (n)o, (i)nteractive] i Applying: Bug 38010: Restore ordering on the contracts table error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorContracts.vue). error: could not build fake ancestor
It doesn't appear to be pushed either.
Oops yes, I had another patch on the branch, and both should have been squashed before attaching. Should be fixed now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #399 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed last follow-up. @Joubu: Your patch restores the sorting. But I am wondering: I don't see the mark-up for date sorting in the table. data-order with the sortable form of the date? Applied patch, ran yarn build. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #400 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182351&action=edit Bug 38010: (follow-up) Remove DT reference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #401 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Katrin Fischer from comment #399)
Pushed last follow-up.
@Joubu: Your patch restores the sorting. But I am wondering: I don't see the mark-up for date sorting in the table. data-order with the sortable form of the date?
Applied patch, ran yarn build.
Looks ok to me: https://snipboard.io/1D8hHo.jpg The trick is here: + return type == "sort" + ? row.contractenddate + : format_date(row.contractenddate); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #402 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Matt Blenkinsop from comment #400)
Created attachment 182351 [details] [review] Bug 38010: (follow-up) Remove DT reference
Patch pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #403 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 182438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182438&action=edit Bug 38010: Fix cypress tests by mocking more API responses Jenkins runs the tests on top of the onboarding, there is no acq data -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #404 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #403)
Created attachment 182438 [details] [review] Bug 38010: Fix cypress tests by mocking more API responses
Jenkins runs the tests on top of the onboarding, there is no acq data
This patch fixes the 2 remaining cypress failures <testcase name="Vendor CRUD operations should edit a vendor" time="0.000" classname="should edit a vendor"> <failure message="Timed out retrying after 10000ms: Expected to find element: `#vendors_list table tbody tr:first`, but never found it." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 10000ms: Expected to find element: `#vendors_list table tbody tr:first`, but never found it. at Context.eval (webpack://koha/./t/cypress/integration/Acquisitions/Vendors_spec.ts:193:11)]]></failure> </testcase> <testcase name="Vendor CRUD operations should show a vendor" time="0.000" classname="should show a vendor"> <failure message="Timed out retrying after 10000ms: Expected to find element: `#vendors_show h1`, but never found it." type="AssertionError"><![CDATA[AssertionError: Timed out retrying after 10000ms: Expected to find element: `#vendors_show h1`, but never found it. at Context.eval (webpack://koha/./t/cypress/integration/Acquisitions/Vendors_spec.ts:232:11)]]></failure> </testcase> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #405 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #403)
Created attachment 182438 [details] [review] Bug 38010: Fix cypress tests by mocking more API responses
Jenkins runs the tests on top of the onboarding, there is no acq data
Patch pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature Keywords|additional_work_needed | --- Comment #406 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe we have taken care of the lose ends here, please correct me if I missed something. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39980 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39980 [Bug 39980] Vendors pages are broken when using Koha as a Mojolicious application -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This update improves the release notes| |vendor management interface | |by migrating it to Vue.js, | |enhancing user experience | |and maintainability. It | |introduces embedded counts | |for associated baskets and | |subscriptions, adds | |protection logic to the | |DELETE endpoint to prevent | |unintended deletions, and | |relocates system preference | |values to a configuration | |endpoint for better | |accessibility. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Bug 38010 depends on bug 38390, which changed state. Bug 38390 Summary: Add 'subscriptions+count' embed to vendors endpoint https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38390 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40066 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40066 [Bug 40066] Cannot add order to basket from the baskets view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40067 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40067 [Bug 40067] "Receive shipments" opens in a new tab/window -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40106 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40106 [Bug 40106] Language selector not displayed on some acquisition views (vue) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Sara Brown <sbrown@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40483 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40533 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40533 [Bug 40533] Clicking "Invoices" in vendor file doesn't show the vendor's invoices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #407 from Fridolin Somers <fridolin.somers@biblibre.com> --- New feature not for 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40684 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40684 [Bug 40684] Permission error for vendors if user has not full acquisition modul permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40796 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40796 [Bug 40796] Vendor search should redirect single result -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40797 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40797 [Bug 40797] Add the option to create a new basket from the vendor search results page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 --- Comment #408 from David Cook <dcook@prosentient.com.au> --- Comment on attachment 181800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181800 Bug 38010: (QA follow-up) Add new apache redirect Review of attachment 181800: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=38010&attachment=181800) ----------------------------------------------------------------- ::: debian/templates/apache-shared-intranet.conf @@ +29,1 @@
RewriteRule ^/cgi-bin/koha/acquisition/vendors(.*)?$ /cgi-bin/koha/acqui/vendors.pl$1 [PT]
Why do rewrite "acquisition/vendors(.*)?" to "acqui/vendors.pl$1" instead of just having an "acquisition/vendors" script? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40146 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40146 [Bug 40146] Untranslatable actions on vendor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40912 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40912 [Bug 40912] Receive shipments button requires full acquisitions permissions not just order_receive -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40483 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40483 [Bug 40483] Searching vendors by Alias no longer works -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Initiative type|--- |Epic -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|38011 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38011 [Bug 38011] Add a foreign key link between vendors and subscriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41088 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41088 [Bug 41088] Need to add context to "Add new" and "Remove this" in vue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Bug 38010 depends on bug 38941, which changed state. Bug 38941 Summary: Convert the acquisitions menu to a Vue island https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38941 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41167 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41473 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41473 [Bug 41473] Editing a vendor returns to vendor search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41804 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41804 [Bug 41804] Migrate EDI accounts settings to Vendors page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42959 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42959 [Bug 42959] Migrate staff interface functionality from CGI controller + Template Toolkit to REST API + Vue.js -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org