http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12128 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 27478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27478&action=edit [Signed-off] Format some of the values in basket display with two decimals, as adding the values together loses the formatting given by get_order_infos() http://bugs.koha-community.org/show_bug.cgi?id=12128 To test open a basket and see some values without decimal formatting (e.g. in column Total tax exc.) Apply patch Values are now formatted wit two decimals. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12128 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12128 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |kyle@bywatersolutions.com --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- I think it would be best to move this formatting logic to the template, rather than formatting the string in perl. Since this is a display issue, we should solve it at the display level whenever possible. If paxed, Marc or anyone else agrees with me, please sign the alternate patch and deprecate the original patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12128 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27478|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12128 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED CC| |katrin.fischer@bsz-bw.de Resolution|--- |DUPLICATE --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this patch got lost 'in discussion'. In the current pl file we got: total_gste => sprintf( "%.2f", $total_gste ), total_gsti => sprintf( "%.2f", $total_gsti ), total_gstvalue => sprintf( "%.2f", $total_gstvalue ), So the display problem no longer appears. I agree that the formatting should be in the template - Jonathan has worked on a TT plugin for currencies in acq that I think will do that. *** This bug has been marked as a duplicate of bug 12970 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.