[Bug 10187] New: precision needed in subscription-add.tt (1/quarter)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 Bug ID: 10187 Summary: precision needed in subscription-add.tt (1/quarter) Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: mathieu.saby@univ-rennes2.fr A precision is needed in subscription-add.tt : "1/quarter" is used 2 times. I suppose there is some difference, but I do not know which... [% IF ( subscription.periodicity7 ) %] 1/quarter [% END %] [% IF ( subscription.periodicity8 ) %] 1/quarter [% END %] M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Oups, not in subscription-add.tt but in serials-collection.tt ! In subscription-add.tt there are the same values, but with this comment : "periodicity8 is 1/quarter, exactly like periodicity7 but will use it for seasonal option" So in serials-collection.tt we should have : periodicity7 1/3 months (1/quarter) periodicity8 1/quarter (seasonal) M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |mathieu.saby@univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|precision needed in |precision needed in |subscription-add.tt |serials-collection.tt |(1/quarter) |(1/quarter) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 --- Comment #2 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 17944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17944&action=edit [PATCH] Bug 10187 : Make a distinction between 2 forms of quarterly in serials-collection.tt This patch changes the description of periodicity7 and periodicity8 in serials-collection.tt. The descriptions are now the same as in subscription-add.tt To test : - Find or create 2 serials subscriptions, with "1/3 months (1/quarter)" and "1/quarter (seasonal)" periodicity - Go on serial collection informations (serials-collection.pl) for the 1st subscription - You must see in Periodiciy column "1/3 months (1/quarter)" - Go on serial collection informations (serials-collection.pl) for the 2d subscription - You must see in Periodiciy column "1/quarter (seasonal)" M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Would it be more clear to make the scope of this report little bit wider? 1/season (spring, summer, etc.) [do not mention quarter anymore] 1/quarter (three months) [if quarter is harder, we could also eliminate it] BTW I am curious: Why not let every 3 months just cover both? Extending this report with: 1/week= weekly 1/month = monthly 1/2 weeks is not completely clear (0,5 or 2?): 1/two weeks idem: 1/three weeks, 1/two three four months, 1/two years BTW: What do you think of every instead of 1/ So: every 2 weeks, every 3 months etc. each year or annually instead of 1/year 2/year: every 6 months, semiannual (?) 2/day= twice a day Another step: We could also just say the frequency is two weeks etc. instead of prefix 75% of the list with 'every'. So list: daily, 1 week, 2 weeks, 1 month, .., 4 months, 6 months, 1 year, 2 years What do you think? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to M. de Rooy from comment #3)
Would it be more clear to make the scope of this report little bit wider?
1/season (spring, summer, etc.) [do not mention quarter anymore] 1/quarter (three months) [if quarter is harder, we could also eliminate it]
BTW I am curious: Why not let every 3 months just cover both?
Extending this report with: 1/week= weekly 1/month = monthly 1/2 weeks is not completely clear (0,5 or 2?): 1/two weeks idem: 1/three weeks, 1/two three four months, 1/two years BTW: What do you think of every instead of 1/ So: every 2 weeks, every 3 months etc.
each year or annually instead of 1/year 2/year: every 6 months, semiannual (?) 2/day= twice a day
Another step: We could also just say the frequency is two weeks etc. instead of prefix 75% of the list with 'every'. So list: daily, 1 week, 2 weeks, 1 month, .., 4 months, 6 months, 1 year, 2 years
What do you think?
I might be wrong, but I think it might be important to have separate periodicities, as they might be linked to different number patterns/formulas? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 --- Comment #5 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Hello So for the moment, this patch uses the same description for equivalent values in subscription-add.tt and serials-collection.tt. Maybe it could be improved later.... I am not a serials expert, but I think these 2 types of "quarter" periodicity are defined in unimarc and marc21. So we may keep both, even if the difference is not ovbious ;-) Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Interesting point. You mention that there should be two quarterly periodicity definitions in marc. I checked MARC21 853-855 $w in this respect: Values are: a - Annual b - Bimonthly c - Semiweekly d - Daily e - Biweekly f - Semiannual g - Biennial h - Triennial i - Three times a week j - Three times a month k - Continuously updated m - Monthly q - Quarterly s - Semimonthly t - Three times a year w - Weekly x - Completely irregular In this case there is no distinction between season and quarter: both map to q. This would be some kind of argument to use only one 3 months periodicity. But note that we are talking about Koha serial fields here that are not directly related to MARC tags. David refers to the numbering formula. Currently, the code makes frequency jump to Season when choosing Seasonal only as numbering formula. Good to keep in mind indeed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 --- Comment #7 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In reply to M. de Rooy from comment #6)
Interesting point. You mention that there should be two quarterly periodicity definitions in marc. I checked MARC21 853-855 $w in this respect: Values are: a - Annual b - Bimonthly c - Semiweekly d - Daily e - Biweekly f - Semiannual g - Biennial h - Triennial i - Three times a week j - Three times a month k - Continuously updated m - Monthly q - Quarterly s - Semimonthly t - Three times a year w - Weekly x - Completely irregular
In this case there is no distinction between season and quarter: both map to q.
Sorry, you are right, I was wrong for the last point. And this is the same in unimarc I will take a closer look to template files (and help files) and give my analysis later. Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #8 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #9 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I put it in discussion, as the patch probably need to be fixed (I had no time to do that for the moment.) M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Is this bug still valid with the reworked serials module? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org