"Mason James" <mason@katipo.co.nz> wrote:
what is everyones opinion about using a standardised perltidy style on Koha commits?
It's a good idea.
what perltidy style shall we standardise on?, any ideas?
No strong opinion.
is there any reason not to use perltidy before committing?
It will result in a massive diff if you run it over the whole file. I suggest only reformatting existing code if you change it, or maybe at some future branch point.
FYI: i have recently discovered 'perltidy -sob foo.pl', which seems to chomp up (and add) extra blanks lines between code too, this option would be helpful for having consistent line spacing too
Does it obliterate paragraph breaks in a block of code?
i have found using perltidy helps alot to reduce false 'cvs diff' lines
That may be done better by using cvs diff -b and similar options. Hope that helps, -- MJ Ray - see/vidu http://mjr.towers.org.uk/email.html Somerset, England. Work/Laborejo: http://www.ttllp.co.uk/ IRC/Jabber/SIP: on request/peteble.