On 20-06-03 20:12, Owen Leonard wrote:
I've been working on a Bootstrap 4 upgrade to the OPAC (Bug 20168, https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168).
My work in progress is here: https://gitlab.com/koha-dev/koha-dev/-/tree/wip-2020-05-14-opac-bootstrap-4
Tested it quickly, nothing seems to be really broken. "Just" a lot (😱) of stuff that moved are takes all the width. I hope it's not too much individual and unique issues and that it won't require fixing a dozen of thing per page. Tough work, oleonard++
One of the differences between this version and master is that Bootstrap assets will be added by npm and the OPAC's SCSS files built using those. This seems to make more sense than adding the entire Bootstrap library to our repo and building from there.
Yes, this is great!
I think the same should probably be done for jQuery and jQueryUI. I'm curious if anyone has comments on that.
+++++++++++++!!
Ultimately opac.css would be the only prebuilt CSS file in version control rather than adding a copy of the Bootstrap CSS.
Are there any obstacles to that? In the way things work now. Besides finding a lot of time to tidy up all these things accumulated and scattered since many years. -- Victor Grousset/tuxayo