Hi, On Wed, Jul 2, 2008 at 7:32 AM, Frederic Demians <frederic@tamil.fr> wrote:
Have you tested to see if the zebra engine does handle the stopwords correctly? I didn't know that it did that.
No I haven't tested and I don't know also if Zebra supports stop words.
I found the first part of your sentence troubling, but perhaps I worry too much. :) A good case can be made that stopwords are (or could be) irrelevant when Zebra is used, but surely they are needed for NoZebra to perform reasonably well. At this point, patches to improve performance should not change functionality, and ideally a test case should accompany each major performance fix to verify that functional behavior has not in fact changed. Perhaps you could take another look at _remove_stopwords() to see if a faster implementation can be written. Regards, Galen -- Galen Charlton Koha Application Developer LibLime galen.charlton@liblime.com p: 1-888-564-2457 x709 _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel