No, Ryan, I was just talking about the singular vs. plural table names. As in, nobody will complain about the table names when they are taken out of view. I'm still very much for killing biblioitems. On Tue, Nov 25, 2008 at 1:44 PM, Ryan Higgins <ryan.higgins@liblime.com>wrote:
Joe, are you suggesting that merging the tables will not be worth the effort? I guess it really isn't going much of a performance hit to add an extra table join to queries since it's 1-1 and indexed. Perhaps the time spent on this
would be better spent on ORM ? The only benefit that this has if it's behind an ORM is potentially making direct sql reporting easier and peace of mind that the table structure is more sane than it used to be.
So is the performance difference negligible in keeping two tables ?
If so, perhaps just removing the extra columns and fixing duplicated column names like 'notes' would be sufficient, and we can put off the merge until after the ORM is in place.
My reasoning for doing the merge first was to clean up before I had to touch some of these queries for some work I'm looking at that won't wait until after the ORM changes are in place.
But I'd rather put time in where it's most valuable short-term.
Comments ?
Ryan
On Tue, Nov 25, 2008 at 12:43 PM, Joe Atzberger <ohiocore@gmail.com>wrote:
Or we have the option of not caring at all once an ORM is in place! --joe
On Tue, Nov 25, 2008 at 7:23 AM, Galen Charlton < galen.charlton@liblime.com> wrote:
Hi,
On Tue, Nov 25, 2008 at 4:24 AM, Paul POULAIN <paul.poulain@free.fr> wrote:
In fact I don't care. But atm we have some tables plural, and some singular. and for sure, that's a pity ! I'm for a unique rule ! and there are more plural than singular, so that would be easier to switch to plural I think.
Roughly speaking, 70% of the table names have plural names and 30% singular. Although it would be nice to pick a convention and change all table names to match, I'm not in favor of renaming biblio to biblios at this point due to the number of queries on that table that would have to be changed and the risk of adding bugs. We'll be better able to make such name changes once an ORM is in place.
Regards,
Galen -- Galen Charlton VP, Research & Development, LibLime galen.charlton@liblime.com p: 1-888-564-2457 x709 skype: gmcharlt _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel
-- Ryan Higgins
LibLime * Open-Source Solutions for Libraries Featuring KohaZOOM ILS 888-564-2457 x704