Everyone, While there can be no guarantees as to whether a patch will be committed into the Koha codebase, I think in practice there are several requirements. This email is an attempt to identify a few of them, and hopefully start a discussion about whether they are truly requirements, and what others could possibly be added. 1. The patch must do what it claims to do, in all commonly-supported Koha environments 2. The patch must not break existing functionality 3. The patch must apply to the current HEAD of the master branch of the code 4. The patch must follow the Coding Style Guidelines 5. The patch must be MARC-flavour agnostic 6. The patch must contain appropriate copyright information 7. If a database update is require, the patch must handle the update both for new installs and upgrades 8. If a new feature is added, the patch must include appropriate Help documentation What do people think of these requirements? Are they reasonable? Should there be more? I understand that there may not be any set of requirements that's completely sufficient, but if we can identify as many as possible, it would make developers lives a bit easier, since we'd all have a better idea what is needed for our patches to be committable. Cheers, -Ian -- Ian Walls Lead Development Specialist ByWater Solutions Phone # (888) 900-8944 http://bywatersolutions.com ian.walls@bywatersolutions.com Twitter: @sekjal