Hi, nice overview again, Jonathan! El mié., 14 sept. 2016 a las 6:40, Jonathan Druart (< jonathan.druart@bugs.koha-community.org>) escribió:
= RESTful API = Last month I have asked some general questions about the RESTful API and the different patches waiting for QA/SO. I did not receive any replies from people directly involved in the RESTful API patches. I have put this part aside last month (and certainly for the next month as well). As Marcel said: "If the community decides to push it, the community will have to maintain it". Ok so let's define "the community" :)
Last month I replied to this, and I now notice I answered partially. Here it goes: I find no reason to think this 'RESTful API' code in a different way than the rest of the codebase. In fact, it is only a small piece of code that routes URLs into the current business classes. The routes can be wrongly defined (wording, convenience, etc), the data types can be wrongly specified, the required permissions to access those endpoints can be wrong. And that's all of it. No important business logic on this code. Anyone should be able to fill bugs for it if problems are found. And I have no problem writing patches for that and I'm sure others will join. The sample Jonathan gave on "What's on #3", about wrong function called for deleting patrons, it is just a piece of code that needs to be failed-qa, and that's it. It should probably be made dependent on the C4::Members rewrite into Koha::Patron(s) classes because it makes more sense. But that's it. I don't really understand what's the big deal about the REST api implementation. Pretty cool features could be written on top of it if we had more endpoints pushed, And there are several already in BZ, even with patches attached: https://bugs.koha-community.org/bugzilla3/buglist.cgi?quicksearch=REST%20api... Regards -- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/>) ✆ +54 9351 3513384 GPG: B2F3C15F