Hi, On Wed, Mar 2, 2016 at 9:56 AM, Jonathan Druart <jonathan.druart@bugs.koha-community.org> wrote:
What are your thoughts? Are you more a, b, c, d or ... e?
I'm in favor of option a (remove $VERSION from internal modules) or option e (drop PERL12 outright, but don't necessarily bother to remove $VERSION from the existing modules). I take this position on the following basis: - we don't explicitly promise that C4:: and Koha:: provide a _public_ API - no, really, we don't; if we did, we would have been taking much more care about keeping function and method signatures stable the past decade - any third-party code that nonetheless relies on Perl modules in C4:: and Koha:: should just check $Koha::VERSION - if we want to provide a public API via a set of Perl modules, we're of course free to do so, but should then keep questions of API versioning segregated to a special namespace - in light of all of the above considerations, any of the other options requires effort that doesn't solve a particular problem Regards, Galen -- Galen Charlton Infrastructure and Added Services Manager Equinox Software, Inc. / The Open Source Experts email: gmc@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org