Agreed. Thanks for creating that bug, Frédéric! David Cook Systems Librarian Prosentient Systems 72/330 Wattle St, Ultimo, NSW 2007
-----Original Message----- From: frederic.demians@gmail.com [mailto:frederic.demians@gmail.com] On Behalf Of Frédéric Demians Sent: Friday, 2 October 2015 4:59 PM To: David Cook <dcook@prosentient.com.au> Cc: Christopher Nighswonger <chris.nighswonger@gmail.com>; Philippe Blouin <philippe.blouin@inlibro.com>; Koha Devel <koha-devel@lists.koha- community.org> Subject: Re: [Koha-devel] Add rule for no subroutines in PL scripts
Another scary one is opac/oai.pl, although that's actually created packages in the pl script which I think is actually worse in a way.
Even if I am on Philippe Blouin side on this discusion (overengineering has its drawbacks), concerning Koha OAI server, it has been done in one unique .pl file because there wasn't any object model or rules in the Koha project when it has been coded. But it's OO (with something like Moose, it would be even cleaner...) It's just a matter of modularization: putting each class in a separate file in a Koha::OAI namespace.
I've created a bug for that:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939