Yes, the file is xt/perltidyrc, and it represents a compromise consensus after months of code-format and editor holy wars. http://git.koha.org/cgi-bin/gitweb.cgi?p=Koha;a=blob;f=xt/perltidyrc;h=f7d9a... The only other thing that might be useful is a sample .vimrc file that makes 4-space-indents and no-tabs automatic. Remember not to get overzealous and try tidying up Makefiles and things that actually need tabs in them. --joe On Thu, Dec 10, 2009 at 8:49 AM, Kyle Hall <kyle.m.hall@gmail.com> wrote:
Didn't someone create a PerlTidy config file for Koha awhile back? I think that would be an excellent way to easily standardize indentation rules. If someone has it, it would be nice to have a link to it on the coding guidelines wiki page.
Kyle
http://www.kylehall.info Information Technology Crawford County Federated Library System ( http://www.ccfls.org )
On Thu, Dec 10, 2009 at 8:07 AM, Nahuel ANGELINETTI <nahuel.angelinetti@biblibre.com> wrote:
Hi,
Le 10/12/2009 13:56, Paul Poulain a écrit :
Hello koha-dev,
with koha 3.2 almost knocking on the door, and chris C. ideas for 3.4, I think it's time to harden& strengthen our coding guidelines, that are really too light. The guidelines are here : http://wiki.koha.org/doku.php?id=en:development:codingguidelines
I suggest we create a page "newcodingguidelines", with everyone/anyone ideas, that could be discussed through a chat session.
is it a good suggestion ?
I'm looking the koha code every day, the most difficult to read the code is : Identation My propositions are: * don't use tabs, indentation should be 4 white spaces * Identation must be valid to accept a patch
Then, as you know, urls are hard coded in templates, they should be a baseurl everywhere like: CGIBASE + "/members/memberentry.pl"
I propose tu use everytime $myhash->{mykey} instead of $$myhash{mykey}.
Deny patches with SQL in .pl scripts, accept "SQL" only in C4, and encourage the use of SQLHelper.
New ideas will come later :)
bests,
-- Nahuel ANGELINETTI
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel