On Mon, Apr 9, 2012 at 8:08 PM, Chris Cormack <chris@bigballofwax.co.nz> wrote:
2012/4/10 Chris Nighswonger <cnighswonger@foundations.edu>:
On Mon, Apr 9, 2012 at 1:03 PM, Dobrica Pavlinusic <dpavlin@rot13.org> wrote:
- Simplifying code - Minimizing XML parsing
I had one patch with this which uses marc instead of marcxml from biblioitems to provide huge performance improvement:
http://git.rot13.org/?p=koha.git;a=commitdiff;h=a18a7f709447cccf617e8fa5b545...
(it needs cleanup, rebase and probably own bug)
That's spectacular. What's keeping us from pushing that now?
It is indeed spectacular
Unfortunately, it is now missing all the item information. So it still needs to call C4::Biblio::EmbedItemsInMarcBiblio($record, $biblionumber) if ($embeditems);
Can you test it with that ?
One other thought: Won't $record = MARC::Record::new_from_usmarc( $row->{marc} ) choke on normarc, unimarc, and friends? I'm wondering if this was not part of the reason we went to XML... Kind Regards, Chris