Hi Jonathan, Unfortunately, I doubt that I'll ever be able to attend a dev meeting. Australia/Sydney 21 UTC = 7am 19 UTC = 5am 7 UTC = 5pm Of course, looking at the times for others, I see that the times for Europe aren't always that desirable either. Europe/Paris 21 UTC = 11pm 19 UTC = 9pm 7 UTC = 9am Pacific/Auckland 21 UTC = 10am 19 UTC = 8am 7 UTC = 8pm America/Los_Angeles 21 UTC = 2pm 19 UTC = 12pm 7 UTC = 12am And I doubt it's worthwhile changing one of the meeting times to be inclusive of Australians, as there probably aren't that many of us. In fact, I'm sure 7am and 5pm aren't too bad for some Australians, but for me those are times where I'm with my family and not at a computer, so maybe I'm just the exception. As Katrin said, there are always the meeting minutes and adding a "watch" on the wiki page. Even if I can't contribute, I can at least keep track of what's discussed that way. David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595
-----Original Message----- From: koha-devel-bounces@lists.koha-community.org [mailto:koha-devel- bounces@lists.koha-community.org] On Behalf Of Jonathan Druart Sent: Tuesday, 13 September 2016 5:19 PM To: koha-devel <koha-devel@lists.koha-community.org> Subject: Re: [Koha-devel] Coding patterns discussion
Next dev meeting is on September 28: https://wiki.koha- community.org/wiki/Development_IRC_meeting_28_September_2016
2016-09-12 19:32 GMT+01:00 Tomas Cohen Arazi <tomascohen@gmail.com>:
I've been looking at our coding patterns, and noticed we haven't discussed/agreed on some stuff. Which is a good oportunity to just do it, now the Koha:: namespace is being filled with cool old-code rewrites with lots of test coverage.
- Transactions on heavy business functions that should definitely be wrapped inside a transaction.
Running $ cd Koha ; git grep txn is just sad.
- Little use of Exceptions in Koha. We introduced them, but still don't extend its use. Maybe related to the next item.
I think we should keep general exceptions (like Koha::Exceptions::ObjectNotFound) in the general Koha::Exceptions namespace. But move the package-specific ones into its own file. To aid maintenance. A good candidate are Koha::Exceptions::Virtualshelves
- We don't use a Try/Catch library. It would make it easier to use Koha::Exceptions with a nice syntax.
There are a couple interesting libraries: Try::Tiny and TryCatch. [1] I prefer the latter because the type check seems nicer to write and eval (instead of an if/ifelse cascade checking ref($exception) eq 'Something'.
I have my opinions on this items, and it would be great to discuss it openly. There's code in bugzilla waiting for QA, and it'd be great to have some consensus on how to organize the code for the future.
Regards
[1] http://search.cpan.org/~ether/Try-Tiny-0.27/lib/Try/Tiny.pm and http://search.cpan.org/~ash/TryCatch-1.003002/lib/TryCatch.pm
-- Tomás Cohen Arazi Theke Solutions (https://theke.io) ✆ +54 9351 3513384 GPG: B2F3C15F
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha- community.org/ bugs : http://bugs.koha-community.org/