CCing koha-devel, as I had meant to originally. --gmc On Mon, Mar 15, 2010 at 9:13 AM, Galen Charlton <gmcharlt@gmail.com> wrote:
Hi,
On Sun, Mar 14, 2010 at 10:43 PM, Lars Wirzenius <lars@catalyst.net.nz> wrote:
* INSTALL.fedora7 -- this has a copyright statement, but no copyright license information. Is it still relevant? Fedora 7 is pretty old by now, and no longer support, as far as I can tell. Do the instructions work for modern versions of Fedora? If not, can they be updated? If not, the file should probably be removed. If it is still relevant, or can be made relevant, a copyright license should be added.
My preference is to update installation documentation, not remove it. Any Fedora users about who could run through an installation with the current version of Fedora?
* t/smolder_smoke_signal -- this is not under the GPL-2, but the license seems compatible with it, in case that is necessary, so thist should be OK. I am bringing it up just to make sure it is actually OK, not just in the happy universe in my head.
License seems OK, but there's an another issue here - is anybody willing to volunteer to run a Smolder server for the Koha project?
* misc/cronjobs/check-url.pl, misc/cronjobs/cloud-kw.pl -- these have a copyright license of GPL version 2 only, whereas most of Koha has version 2 or later. Is this a problem? Can we get the author to relicense to version 2 or later, to keep it compatible with the rest of Koha?
Frédéric - can you confirm willingness to update the license of check-url.pl to GPL 2+? Ditto for cloud-kw.pl?
Another issue I noticed is that few if any files have their copyright statements updated. Many files have copyright timestamps from 8 years ago, for example, but have been modified since. I am not sure if this is important enough to fix, but on the whole it would probably be good to be careful about these things. Fixing ten years of code base for this is going to be a pain, though.
In more ways than one. I will take this opportunity to ask/remind/beg people to not copy-and-paste the "Copyright 2000-2002 Katipo Communications" line in new files. Please use your own (or your employer's) copyright statement with a current year.
Regards,
Galen -- Galen Charlton gmcharlt@gmail.com
-- Galen Charlton gmcharlt@gmail.com