If the syspref doesn't exist, we made a mistake. One thing I've been trying to finish for the next release (and I haven't) is a syspref report for the about page. We should already have that. And I'd also say that we should encourage every addition/deletion to koha-conf.xml to include a check that shows a warning on the about page also. It should be on the coding guidelines. Otherwise if someone inadvertedly changes a fallback behaviour, we cannot help the users debug their problem. Regards El Tue Oct 28 2014 at 12:04:10, Marcel de Rooy (<M.de.Rooy@rijksmuseum.nl>) escribió:
Yes, they should be in the sql file and updatedatabase.
But if the pref somehow does not exist and the code can handle that, Koha does a good job imho.
------------------------------ *Van:* koha-devel-bounces@lists.koha-community.org [ koha-devel-bounces@lists.koha-community.org] namens Mark Tompsett [ mtompset@hotmail.com] *Verzonden:* dinsdag 28 oktober 2014 15:35 *Aan:* koha-devel@lists.koha-community.org *Onderwerp:* [Koha-devel] System preference question
Greetings,
I was looking at Bug 9580, and came across the non-problem of non-existent system preferences. That is, the system preference does not exist in the systempreferences table, but that didn’t stop me from creating it on the fly when I set the system preference in the staff client, because the .pref file had been modified and updating it created the missing system preference, and it did not cause any difficulties in actually testing.
Should all system preferences be in syspref.sql? Should all system preferences be created in updatedatabase.pl? Or are there exceptions like this one, where it just works?
On a related note there is a Wiki page that should reflect this consensus I’m trying to find. http://wiki.koha-community.org/wiki/System_Preferences
GPML, Mark Tompsett _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/