Agreed with Galen and Chris. DBIC should be able to handle this. Also, distinct column names would make joins more difficult when writing it out by hand (and for DBIC I think). David Cook Systems Librarian Prosentient Systems 72/330 Wattle St, Ultimo, NSW 2007
-----Original Message----- From: koha-devel-bounces@lists.koha-community.org [mailto:koha-devel- bounces@lists.koha-community.org] On Behalf Of Galen Charlton Sent: Thursday, 13 November 2014 5:39 AM To: Chris Cormack Cc: Koha Devel Subject: Re: [Koha-devel] Ambiguous column names
Hi,
On Wed, Nov 12, 2014 at 10:35 AM, Chris Cormack <chris@bigballofwax.co.nz> wrote:
I think we don't need to make columns unique across the whole db just when selecting do select borrowers.timestamp as something. DBIx::Class helps us with this also
I agree with Chris. In legacy code, doing a "select *" from a join on multiple tables is should be discouraged, so using the addition of a new column to locate cases of these to stamp out is preferable. The alternative of using a distinct column name has the problem of making the writing of more general templates and classes more difficult.
Regards,
Galen -- Galen Charlton Manager of Implementation Equinox Software, Inc. / The Open Source Experts email: gmc@esilibrary.com direct: +1 770-709-5581 cell: +1 404-984-4366 skype: gmcharlt web: http://www.esilibrary.com/ Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha- community.org/ bugs : http://bugs.koha-community.org/