Hi Stephen, On Thu, Feb 5, 2009 at 11:36 AM, Stephen G. Edwards <sedwards@alloycomputing.com> wrote: 1. Add a "Place Hold" button to the search results page. I did this in my
sandbox by tweaking "opac-results.tmpl" and "basket.js" (trying to mirror the flow of the "Save" button's functionality). Use this to pass the list of checked biblio numbers to the "opac-reserve.pl" script. 2. Redesign the "opac-reserve.tmpl" template to allow for a list of biblio items, rather than just one. For each biblio, allow the selection of "next available" or "particular item" (if allowed). 3. Update "opac-reserve.pl" to handle multiple biblio numbers and the new template. Is there any reason I shouldn't proceed (carefully) along these lines?
This looks sensible to me.
The second call appears to be redundant, unless I'm missing something.
It is redundant. The second call to opac-reserve.pl is coming from a bug in the part of the template that displays item type icons; if there is no icon associated with an item's item type, an <img> tag like this is still produced: <img src="" alt="" title="" /> The browsers is evidently handling src="" by assuming that it should retrieve the page again, thus running the script for a second time.
Also, the end of the "opac-reserve.tmpl" template has a section that appears to be dead code. It is guarded by a check for the "item_types_selected" template variable, but I can't find anyplace that this could be set. The
Yes, that appears to be dead. Regards, Galen -- Galen Charlton VP, Research & Development, LibLime galen.charlton@liblime.com p: 1-888-564-2457 x709 skype: gmcharlt