Hi Marcel and Chris, I think what you are discussing here is basically the definition of 'Passed QA'. I think setting this status means, that I am sure that a patch works and does not cause any regressions. I would like QA team members only to set this status, if they are sure. Else what we do is pass this task on to our RM, who is only one person and has to deal with a lot of more work than any individual member of the QA team. So the next question is, what can we do to be sure something works? - make sure the patch applies - make sure it passes all the tests - step through the coding guidelines and review the code - do functionality testing - add our sign-off If the documentation on the bug is not enough, to make it possible to test or understand what a patch is supposed to do - we should ask for more information. Everyone misses something sometimes, but that is why we have different people looking at patches. Even with a solid sign-off, there might still be something to catch and there is nothing wrong with missing something or with catching it. :) Katrin
-----Original Message----- From: koha-devel-bounces@lists.koha-community.org [mailto:koha-devel- bounces@lists.koha-community.org] On Behalf Of Marcel de Rooy Sent: Monday, November 26, 2012 9:42 AM To: Chris Cormack; koha-devel@lists.koha-community.org Subject: Re: [Koha-devel] [QA] QAing and signing off
For me it feels more work. If I add a signoff, I must have tested the patch more extensively. But if I do not need to add signoff and I can rely on a solid signoff already, the QA process will be faster. Note that I do not oppose this step, I am just warning that it takes more time. I do not favor only adding a signoff line without more testing. This would create a "false feeling of security".
Marcel
-----Oorspronkelijk bericht----- Van: Chris Cormack [mailto:chris@bigballofwax.co.nz] Verzonden: maandag 26 november 2012 9:28 Aan: Marcel de Rooy CC: Jared Camins-Esakov; koha-devel@lists.koha-community.org Onderwerp: Re: [Koha-devel] [QA] QAing and signing off
On 26 November 2012 21:25, Marcel de Rooy <M.de.Rooy@rijksmuseum.nl> wrote:
Testing is more than checking if it applies :)
Of course it is, but you can hardly QA something if you haven't even applied it. My point is, applying a patch then doing your QA then signing that patch off ... the only change is adding the sign off.
All Jared is asking is, that if you mark a patch passed-qa you add a sign off to it.
Chris _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha- community.org/ bugs : http://bugs.koha-community.org/