Hi folks ... On Thu, 23 Jan 2003, Chris Cormack wrote:
On Wed, Jan 22, 2003 at 05:54:20PM -0800, Owen Leonard said:
I'm going through the default [English] templates looking for things to clean up, and I'm finding a variety of ways of handling quoting. For example:
<a href=/cgi-bin/koha/detail.pl?bib=<TMPL_VAR NAME="biblionumber">&type=intra><TMPL_VAR NAME="title">(<TMPL_VAR NAME="author">)</a>
I'm assuming that the href= value isn't double-quoted because TMPL_VAR NAME is. This won't validate, nor will instances where single quotes are used (href=''). Is this really necessary? Isn't Perl looking for the <TMPL...> blocks and ignoring the HTML around it?
Yep you are right. The missing " on the href are a mistake. Fixing those would be good :-)
That's part of what I'm attempting to do. Owen, maybe we should compare notes in the near future? I've gotten as far as getting Tidy (http://tidy.sourceforge.net/) to be almost co-operative, using a small perl-wrapper (www.bofh.dk/koha/html-beautify.pl) - it's not quite there yet, but almost :-) /bobby -- -- -- -- -- -- -- Bobby Billingsley, General Specialist -- -- -- -- -- -- -- ___ .--.- \ | | _ `-,_`--'__/ x./_ | Remember to love while you dare | ASCII ribbon campaign ( ) //-_`--/ //\ \ | remember to live while you do | - against HTML email X \__/ `---' \__/ | -- Piet Hein | & vcards / \ Lat: 55° 40' 52" N Lon: 12° 32' 56" E Anyone without a sense of humor is at the mercy of the rest of us :->