On 13 July 2012 21:11, Dobrica Pavlinusic <dpavlin@rot13.org> wrote:
With end of academic year near, I was forced to take a look why our due-dates aren't calculated correctly. Result is
Bug 8418 - Koha::Calendar is_holiday ignores all user data http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418
This is pure bug-fix patches to Koha::Calendar to restore functionality which used to work in C4::Calendar.
I'm aware there are quite a few patches which touch this code, but some of them are wrong and others are stuck in sign-off because they also modify another parts of Koha.
This is my attempt to provide simple bug fix only which should also be applicable for stable Koha versions. It makes useDaysMode work and remove one redundant SQL query so I hope that you will forgive me for making duplicate changes in separate bug. At least, I tried to block all bugs which also provide same fixes, but unblocking them is just removing relevant patches from them, making other bugs just functionality change.
Working on testing this now The first 2 patches are easily tested and seem to be working fine, so I have signed off. Testing the 3rd patch now Id love to get these into 3.8.3 Chris