http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=170 a.c.li@ieee.org changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|chris@katipo.co.nz |a.c.li@ieee.org ------- Additional Comments From a.c.li@ieee.org 2003-02-04 21:48 ------- items.holdingbranch was set to null in the return process. This causes itemcount2 to skip the item. returnbook in C4::Circulation::Circ2 ultimately does the return, and there is a $branch parameter which needs to be passed. returns.pl passes this parameter ultimately from $input->param('branch'). Comparing the $branch-setting code between returns.pl and circulation.pl, returns.pl is found to be missing some additional sanity-checking code for $branch and $printer. So, it seems that 1. Circ2 does not have error-checking code to abort when $branch is null 2. returns.pl is having branch/printer-getting code which is outdated 3. the branch/printer-getting code should have been modularized in a function to avoid this ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.