Marcel, As you say, it would be easy to make the matching case-insensitive. I have no opinion on whether that would be a good idea. Regards, Jared On Mon, Jan 27, 2014 at 4:32 AM, Marcel de Rooy <M.de.Rooy@rijksmuseum.nl>wrote:
Thanks, Jared.
Just to be more complete: I meant with an uppercase variant in this case the variant starting with only the first character in uc (like Number-local-acquisition).
I scrolled through the QueryParser code and came at the lines 855-857 of OpenILS/QueryParser.pm where three regexes are used to search for fields and aliases.
Is it an idea to make these regexes case insensitive?
This would make QueryParser behave case insensitive as to index names, just like C4/Search.pm now is when you disable QueryParser. (compare BZ 6786)
As an example, the Number-local-acquisition index of BZ 10544 could be mentioned. QueryParser does not recognize the index name with capital N, but since it prefixes the string with pqf=, C4/Search will not change it either.
Copying dev list for additional feedback?
Marcel
*Van:* Jared Camins-Esakov [mailto:jcamins@cpbibliography.com] *Verzonden:* donderdag 23 januari 2014 16:02 *Aan:* Marcel de Rooy *Onderwerp:* Re: QueryParser question
Marcel,
Upper-case indexes seem odd to me, but it would be easy to add them. For example, the following change in Koha/QueryParser/Driver/PQF.pm:
97 $self->add_search_field_alias( $class => $field => uc $field );
Regards,
Jared
On Thu, Jan 23, 2014 at 8:32 AM, Marcel de Rooy <M.de.Rooy@rijksmuseum.nl> wrote:
Hi Jared,
This question came up when looking at report http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10544
The index names in the config file seem to be lower case. Upper case variants do not seem to work.
Is it possible to add uppercase names? Or is it possible to have all variants work in some case insensitive manner?
Thanks,
Marcel
-- Jared Camins-Esakov
Bibliographer, C & P Bibliography Services, LLC
(phone) +1 (917) 727-3445
(e-mail) jcamins@cpbibliography.com
-- Jared Camins-Esakov Bibliographer, C & P Bibliography Services, LLC (phone) +1 (917) 727-3445 (e-mail) jcamins@cpbibliography.com (web) http://www.cpbibliography.com/