On Mon, Jun 23, 2008 at 5:18 AM, MJ Ray <mjr@phonecoop.coop> wrote:
Warning: Reply-To set to koha-devel.
"Andrew Moore" <andrew.moore@liblime.com> wrote:
I guess it should be optional. Good point. If it's an optional dependency, how should I indicate that? Should I leave it out of Makefile.PL altogether?
I know no good way to indicate optional modules in Makefile.PL. Three choices that I think are better than total omission:-
1. put it in as a comment and POD string;
2. put it in as something like %CURRENT_PM like spamassassin does http://spamassassin.apache.org/full/3.0.x/dist/Makefile.PL
3. switch on META.yml generation and add a recommends line http://module-build.sourceforge.net/META-spec.html
Which do people prefer? I'd lean towards doing (1 or 2) and 3. I prefer that all potential dependencies be clearly stated in the Makefile.PL, whether for optional features or not ... too many people installing Koha will perceive an after-the-fact error message, a bug in Koha.
Cheers, -- Joshua Ferraro SUPPORT FOR OPEN-SOURCE SOFTWARE CEO migration, training, maintenance, support LibLime Featuring Koha Open-Source ILS jmf@liblime.com |Full Demos at http://liblime.com/koha |1(888)KohaILS _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha.org http://lists.koha.org/mailman/listinfo/koha-devel