Master broken by 20521 (sql modes)
Hi devs, I quick email to let you know that master and tests are (completely) broken because of the recent push of bug 20521. It turned on the "problematic SQL modes" for dev installs (I let you search for that in your emails if it did not ring you the bell). I am working on fixing the different test failures (the ones we introduced since bug 20144, 6 months ago). They are all regressions and there are a lot! This shows us that we absolutely need this change, to alert us when we are doing something wrong, that's why I would not recommend a revert. If you are stuck in something urgent/important you can revert commit aafd0476342ca9691fd8a7c2c754c425ae1cf61f Bug 20521: Enable problematic SQL modes for dev installs Or easier, remove the dev_install flag in your koha-conf (but do not forget to switch it back in a few days!). Cheers, Jonathan
Hi all, I guess this effects the sandboxes as well? This afternoon and tomorrow morning is a hackday in Sweden and I was hoping for some sign-offs! Katrin On 18.10.18 01:38, Jonathan Druart wrote:
Hi devs,
I quick email to let you know that master and tests are (completely) broken because of the recent push of bug 20521. It turned on the "problematic SQL modes" for dev installs (I let you search for that in your emails if it did not ring you the bell).
I am working on fixing the different test failures (the ones we introduced since bug 20144, 6 months ago). They are all regressions and there are a lot!
This shows us that we absolutely need this change, to alert us when we are doing something wrong, that's why I would not recommend a revert.
If you are stuck in something urgent/important you can revert commit aafd0476342ca9691fd8a7c2c754c425ae1cf61f Bug 20521: Enable problematic SQL modes for dev installs Or easier, remove the dev_install flag in your koha-conf (but do not forget to switch it back in a few days!).
Cheers, Jonathan
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
The Bywater one's may be stuffed by this (assuming they all set dev_install inside their koha-testing-docker based setup).. but the ptfs-e one's don't yet set dev_install so they should be fine I think. *Martin Renvoize* <https://www.ptfs-europe.com> Development Team Manager *Phone:* +44 (0) 1483 378728 *Mobile:* +44 (0) 7725 985 636 *Email:* martin.renvoize@ptfs-europe.com *Fax:* +44 (0) 800 756 6384 www.ptfs-europe.com Registered in the United Kingdom No. 06416372 VAT Reg No. 925 7211 30 The information contained in this email message may be privileged, confidential and protected from disclosure. If you are not the intended recipient, any dissemination, distribution or copying is strictly prohibited. If you think that you have received this email message in error, please email the sender at info@ptfs-europe.com On Thu, 18 Oct 2018 at 06:11, Katrin Fischer <katrin.fischer.83@web.de> wrote:
Hi all,
I guess this effects the sandboxes as well? This afternoon and tomorrow morning is a hackday in Sweden and I was hoping for some sign-offs!
Katrin On 18.10.18 01:38, Jonathan Druart wrote:
Hi devs,
I quick email to let you know that master and tests are (completely) broken because of the recent push of bug 20521. It turned on the "problematic SQL modes" for dev installs (I let you search for that in your emails if it did not ring you the bell).
I am working on fixing the different test failures (the ones we introduced since bug 20144, 6 months ago). They are all regressions and there are a lot!
This shows us that we absolutely need this change, to alert us when we are doing something wrong, that's why I would not recommend a revert.
If you are stuck in something urgent/important you can revert commit aafd0476342ca9691fd8a7c2c754c425ae1cf61f Bug 20521: Enable problematic SQL modes for dev installs Or easier, remove the dev_install flag in your koha-conf (but do not forget to switch it back in a few days!).
Cheers, Jonathan
_______________________________________________ Koha-devel mailing listKoha-devel@lists.koha-community.orghttp://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
I've tested the Bywater sandboxes - can confirm some of the basics features are broken. On 18.10.18 10:09, Renvoize, Martin wrote:
The Bywater one's may be stuffed by this (assuming they all set dev_install inside their koha-testing-docker based setup).. but the ptfs-e one's don't yet set dev_install so they should be fine I think.
*Martin Renvoize*
Development Team Manager
*Phone:* +44 (0) 1483 378728
*Mobile:* +44 (0) 7725 985 636
*Email:* martin.renvoize@ptfs-europe.com <mailto:martin.renvoize@ptfs-europe.com>
*Fax:* +44 (0) 800 756 6384
www.ptfs-europe.com <https://www.ptfs-europe.com>
Registered in the United Kingdom No. 06416372 VAT Reg No. 925 7211 30
The information contained in this email message may be privileged, confidential and protected from disclosure. If you are not the intended recipient, any dissemination, distribution or copying is strictly prohibited. If you think that you have received this email message in error, please email the sender at info@ptfs-europe.com <mailto:info@ptfs-europe.com>
On Thu, 18 Oct 2018 at 06:11, Katrin Fischer <katrin.fischer.83@web.de <mailto:katrin.fischer.83@web.de>> wrote:
Hi all,
I guess this effects the sandboxes as well? This afternoon and tomorrow morning is a hackday in Sweden and I was hoping for some sign-offs!
Katrin
On 18.10.18 01:38, Jonathan Druart wrote:
Hi devs,
I quick email to let you know that master and tests are (completely) broken because of the recent push of bug 20521. It turned on the "problematic SQL modes" for dev installs (I let you search for that in your emails if it did not ring you the bell).
I am working on fixing the different test failures (the ones we introduced since bug 20144, 6 months ago). They are all regressions and there are a lot!
This shows us that we absolutely need this change, to alert us when we are doing something wrong, that's why I would not recommend a revert.
If you are stuck in something urgent/important you can revert commit aafd0476342ca9691fd8a7c2c754c425ae1cf61f Bug 20521: Enable problematic SQL modes for dev installs Or easier, remove the dev_install flag in your koha-conf (but do not forget to switch it back in a few days!).
Cheers, Jonathan
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org <mailto:Koha-devel@lists.koha-community.org> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website :http://www.koha-community.org/ git :http://git.koha-community.org/ bugs :http://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org <mailto:Koha-devel@lists.koha-community.org> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Hi all, Today's update: Good news, master is no longer broken, but not fixed! :) A new entry from koha-conf is going to be used: without <strict_sql_modes>1</strict_sql_modes> you will not be impacted by the recent failures. We are going to turn it on for Jenkins. I still recommend you to turn it on in order to catch inconsistencies in our code. If you find bugs, you can create a new one and link it to the existing omnibus (bug 17258). Make sure it's not fixed yet, there a quite a bunch waiting in the bug tracker. Waiting for a signoff: Bug 21603 <https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21603> - Remove Group by clause in SearchCourses Bug 21604 <https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21604> - Cannot add/edit funds, cannot add budgets Bug 21606 <https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21606> - Issues with matching rules Bug 21610 <https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21610> - Koha::Object->store needs to handle incorrect values Bug 21612 <https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21612> - Incorrect GROUP BY in Koha::Virtualshelves Waiting for a patch: Bug 21605 <https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21605> - Cannot create EDI account Cheers, Jonathan On Wed, 17 Oct 2018 at 20:38 Jonathan Druart < jonathan.druart@bugs.koha-community.org> wrote:
Hi devs,
I quick email to let you know that master and tests are (completely) broken because of the recent push of bug 20521. It turned on the "problematic SQL modes" for dev installs (I let you search for that in your emails if it did not ring you the bell).
I am working on fixing the different test failures (the ones we introduced since bug 20144, 6 months ago). They are all regressions and there are a lot!
This shows us that we absolutely need this change, to alert us when we are doing something wrong, that's why I would not recommend a revert.
If you are stuck in something urgent/important you can revert commit aafd0476342ca9691fd8a7c2c754c425ae1cf61f Bug 20521: Enable problematic SQL modes for dev installs Or easier, remove the dev_install flag in your koha-conf (but do not forget to switch it back in a few days!).
Cheers, Jonathan
participants (3)
-
Jonathan Druart -
Katrin Fischer -
Renvoize, Martin