Second look needed on a few (2!) lines related to plugins
Hi :) It's about Bug 25476 - Uploaded files can't be easily browsed via upload.pl There are two lines in the patch that are out of my knowledge to QA: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476#c6 [% PROCESS plugin_pars %] [...] $plugin? ( public => 1 ): () Does this look familiar to anyone? Cheers, -- Victor Grousset/tuxayo
hiya, here's some info... https://docstore.mik.ua/orelly/perl3/prog/ch03_16.htm On 30/03/21 5:25 am, Victor Grousset/tuxayo wrote:
Hi :)
It's about Bug 25476 - Uploaded files can't be easily browsed via upload.pl
There are two lines in the patch that are out of my knowledge to QA: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476#c6
[% PROCESS plugin_pars %] [...] $plugin? ( public => 1 ): ()
Does this look familiar to anyone?
Cheers,
On 21-03-30 01:31, Mason James wrote:
hiya, here's some info...
Indeed there is a trinary, but it's about if it makes sense to do "those things" related to plugins. Is that useful, is that valid, is that enough? Cheers, -- Victor Grousset/tuxayo
Hi, In my opinion this syntax looks strange. I'd prefer : my $filter = { uploadcategorycode => $browsecategory }; $filter{public} = 1 if $plugin; $uploads = Koha::UploadedFiles->search($filter)->unblessed; Super cool enhancement BTW ;) Best regards, Le 29/03/2021 à 18:25, Victor Grousset/tuxayo a écrit :
Hi :)
It's about Bug 25476 - Uploaded files can't be easily browsed via upload.pl
There are two lines in the patch that are out of my knowledge to QA: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476#c6
[% PROCESS plugin_pars %] [...] $plugin? ( public => 1 ): ()
Does this look familiar to anyone?
Cheers,
-- Fridolin SOMERS <fridolin.somers@biblibre.com> Software and system maintainer 🦄 BibLibre, France
I wrote the patch close to a year ago so I have no idea why I used the syntax that I did. I think maybe I was copying what was already there for the search feature at the time. But I'm happy for people to change it! And thanks for the compliment. I do like this feature! David Cook Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 -----Original Message----- From: Koha-devel <koha-devel-bounces@lists.koha-community.org> On Behalf Of Fridolin SOMERS Sent: Tuesday, 30 March 2021 6:08 PM To: koha-devel@lists.koha-community.org Subject: Re: [Koha-devel] Second look needed on a few (2!) lines related to plugins Hi, In my opinion this syntax looks strange. I'd prefer : my $filter = { uploadcategorycode => $browsecategory }; $filter{public} = 1 if $plugin; $uploads = Koha::UploadedFiles->search($filter)->unblessed; Super cool enhancement BTW ;) Best regards, Le 29/03/2021 à 18:25, Victor Grousset/tuxayo a écrit :
Hi :)
It's about Bug 25476 - Uploaded files can't be easily browsed via upload.pl
There are two lines in the patch that are out of my knowledge to QA: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476#c6
[% PROCESS plugin_pars %] [...] $plugin? ( public => 1 ): ()
Does this look familiar to anyone?
Cheers,
-- Fridolin SOMERS <fridolin.somers@biblibre.com> Software and system maintainer 🦄 BibLibre, France _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
Hi Victor, I will be addressing your question on the bug itself. Marcel ________________________________ T/m 18 jaar gratis Kijk hier de nieuwste aflevering van Rijksmuseum Unlocked x! xxx Please think before you print Van: Koha-devel <koha-devel-bounces@lists.koha-community.org> namens Victor Grousset/tuxayo <victor@tuxayo.net> Verzonden: maandag 29 maart 2021 18:25 Aan: koha-devel <koha-devel@lists.koha-community.org> Onderwerp: [Koha-devel] Second look needed on a few (2!) lines related to plugins Hi :) It's about Bug 25476 - Uploaded files can't be easily browsed via upload.pl There are two lines in the patch that are out of my knowledge to QA: https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.koha-... [% PROCESS plugin_pars %] [...] $plugin? ( public => 1 ): () Does this look familiar to anyone? Cheers, -- Victor Grousset/tuxayo _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.koha... website : https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.koha-c... git : https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.koha-c... bugs : https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.koha-...
participants (5)
-
dcook＠prosentient.com.au -
Fridolin SOMERS -
Marcel de Rooy -
Mason James -
Victor Grousset/tuxayo