I wrote the patch close to a year ago so I have no idea why I used the syntax that I did. I think maybe I was copying what was already there for the search feature at the time. But I'm happy for people to change it! And thanks for the compliment. I do like this feature! David Cook Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 -----Original Message----- From: Koha-devel <koha-devel-bounces@lists.koha-community.org> On Behalf Of Fridolin SOMERS Sent: Tuesday, 30 March 2021 6:08 PM To: koha-devel@lists.koha-community.org Subject: Re: [Koha-devel] Second look needed on a few (2!) lines related to plugins Hi, In my opinion this syntax looks strange. I'd prefer : my $filter = { uploadcategorycode => $browsecategory }; $filter{public} = 1 if $plugin; $uploads = Koha::UploadedFiles->search($filter)->unblessed; Super cool enhancement BTW ;) Best regards, Le 29/03/2021 à 18:25, Victor Grousset/tuxayo a écrit :
Hi :)
It's about Bug 25476 - Uploaded files can't be easily browsed via upload.pl
There are two lines in the patch that are out of my knowledge to QA: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25476#c6
[% PROCESS plugin_pars %] [...] $plugin? ( public => 1 ): ()
Does this look familiar to anyone?
Cheers,
-- Fridolin SOMERS <fridolin.somers@biblibre.com> Software and system maintainer 🦄 BibLibre, France _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/