Plan for upgrading jQuery in the staff client
I have filed a new bug with a plan for how to move forward on an upgrade of jQuery in the staff client. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 I would love to hear other developers' comments about it. Thanks, Owen -- Web Developer Athens County Public Libraries http://www.myacpl.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883
I've attached a proof-of-concept patch to the bug which does the following: - Adds jQuery 1.12.0 - Adds jQueryUI 1.11.4 - Adds a new version of doc-head-close.inc, doc-head-close-jquery-1.12.0.inc, to be included on pages which have been tested with the new versions of jQuery and jQueryUI. - Updates the staff client home page to use the new include. If that patch gets approved I suggest we move forward in this way: - Start testing other pages with the new include and update JavaScript as necessary on a page-by-page or section-by-section basis. - Require that any new page use the new include file. - Require that any patch which changes existing JavaScript use the new include and thus the new versions of jQuery and jQueryUI. Comments welcome, Owen -- Web Developer Athens County Public Libraries http://www.myacpl.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883
I have attached a new patch which is ready for testing. It upgrades jQuery to 2.2.3, which does not support Internet Explorer 6, 7, or 8. The patch adds the jQuery migrate plugin in order to prevent existing scripts from breaking. -- Owen -- Web Developer Athens County Public Libraries http://www.myacpl.org
I have filed a new bug with a plan for how to move forward on an upgrade of jQuery in the staff client.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883
This is stuck, so I need to ask for suggestions on how to proceed. Jonathan and I have two different proposals. Mine: - Create a new include file which uses new version of jQuery and jQueryUI. Name that include file according to the version of jQuery it includes ("doc-head-close-jquery-1.12.0.inc"). - Gradually (page by page or in batches) submit patches which add use of the new include file while making any changes to the affected page(s) to update relevant JavaScript to work with the new versions. Advantages to this method: Small manageable patches, nothing breaks without warning. Disadvantages to this method: We introduce duplicate versions of doc-head-close.inc which must be kept in sync. There could end up being many many patches. Jonathan suggests that we update jQuery and jQueryUI without creating a new include file and fixing bugs as we find them. Advantages to this method: One patch, and we don't have to deal with include file renaming. Disadvantages to this method: It is not known what pages will break because of the new versions of jQuery and jQueryUI. Jonathan please correct me if I have mis-characterized your proposal. What does everyone think? Should I bring this up for a vote at the next dev meeting? -- Owen -- Web Developer Athens County Public Libraries http://www.myacpl.org
jQuery 1.12 seems to be the last release of the 1.x branch. What's next ? Should we upgrade to 2.x ? 3.x ? I have a preference for the "upgrade all at once / fix as it breaks" method. With the other method I think we will end up with several versions of jQuery and doc-head-close-* Moreover, the upgrade path from 1.7 to 1.12 seems not too hard, according to https://jquery.com/upgrade-guide/1.9 and we can use the jQuery Migrate plugin. Le 07/04/2016 18:02, Owen Leonard a écrit :
I have filed a new bug with a plan for how to move forward on an upgrade of jQuery in the staff client.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883
This is stuck, so I need to ask for suggestions on how to proceed. Jonathan and I have two different proposals. Mine:
- Create a new include file which uses new version of jQuery and jQueryUI. Name that include file according to the version of jQuery it includes ("doc-head-close-jquery-1.12.0.inc").
- Gradually (page by page or in batches) submit patches which add use of the new include file while making any changes to the affected page(s) to update relevant JavaScript to work with the new versions.
Advantages to this method: Small manageable patches, nothing breaks without warning. Disadvantages to this method: We introduce duplicate versions of doc-head-close.inc which must be kept in sync. There could end up being many many patches.
Jonathan suggests that we update jQuery and jQueryUI without creating a new include file and fixing bugs as we find them.
Advantages to this method: One patch, and we don't have to deal with include file renaming. Disadvantages to this method: It is not known what pages will break because of the new versions of jQuery and jQueryUI.
Jonathan please correct me if I have mis-characterized your proposal.
What does everyone think? Should I bring this up for a vote at the next dev meeting?
-- Owen
-- Julian Maurice <julian.maurice@biblibre.com> BibLibre
At 09:23 PM 4/7/2016 +0200, Julian Maurice wrote:
jQuery 1.12 seems to be the last release of the 1.x branch. What's next ? Should we upgrade to 2.x ? 3.x ?
I have a preference for the "upgrade all at once / fix as it breaks" method. With the other method I think we will end up with several versions of jQuery and doc-head-close-* Moreover, the upgrade path from 1.7 to 1.12 seems not too hard, according to https://jquery.com/upgrade-guide/1.9 and we can use the jQuery Migrate plugin.
I used the "migrate plugin" for another project and had no problems. Best -- Paul
Le 07/04/2016 18:02, Owen Leonard a écrit :
I have filed a new bug with a plan for how to move forward on an upgrade of jQuery in the staff client.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883
This is stuck, so I need to ask for suggestions on how to proceed. Jonathan and I have two different proposals. Mine:
- Create a new include file which uses new version of jQuery and jQueryUI. Name that include file according to the version of jQuery it includes ("doc-head-close-jquery-1.12.0.inc").
- Gradually (page by page or in batches) submit patches which add use of the new include file while making any changes to the affected page(s) to update relevant JavaScript to work with the new versions.
Advantages to this method: Small manageable patches, nothing breaks without warning. Disadvantages to this method: We introduce duplicate versions of doc-head-close.inc which must be kept in sync. There could end up being many many patches.
Jonathan suggests that we update jQuery and jQueryUI without creating a new include file and fixing bugs as we find them.
Advantages to this method: One patch, and we don't have to deal with include file renaming. Disadvantages to this method: It is not known what pages will break because of the new versions of jQuery and jQueryUI.
Jonathan please correct me if I have mis-characterized your proposal.
What does everyone think? Should I bring this up for a vote at the next dev meeting?
-- Owen
-- Julian Maurice <julian.maurice@biblibre.com> BibLibre _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
--- Maritime heritage and history, preservation and conservation, research and education through the written word and the arts. <http://NavalMarineArchive.com> and <http://UltraMarine.ca>
On Thu, Apr 7, 2016 at 3:23 PM, Julian Maurice <julian.maurice@biblibre.com> wrote:
jQuery 1.12 seems to be the last release of the 1.x branch. What's next ? Should we upgrade to 2.x ? 3.x ?
We can assume that we will upgrade it to something. I don't think we should complicate this conversation by talking about what the next version will be. If we do this right the next upgrade might be not so complicated.
I have a preference for the "upgrade all at once / fix as it breaks" method. With the other method I think we will end up with several versions of jQuery and doc-head-close-*
I realize having several versions of doc-head-close-*.inc is complicated because we have to keep them in sync. Is there another reason to avoid it? It's certainly not something the user will care about.
Moreover, the upgrade path from 1.7 to 1.12 seems not too hard, according to https://jquery.com/upgrade-guide/1.9 and we can use the jQuery Migrate plugin.
I think it would be nice to not add another JS dependency. -- Owen -- Web Developer Athens County Public Libraries http://www.myacpl.org
participants (3)
-
Julian Maurice -
Owen Leonard -
Paul A