jQuery 1.12 seems to be the last release of the 1.x branch. What's next ? Should we upgrade to 2.x ? 3.x ? I have a preference for the "upgrade all at once / fix as it breaks" method. With the other method I think we will end up with several versions of jQuery and doc-head-close-* Moreover, the upgrade path from 1.7 to 1.12 seems not too hard, according to https://jquery.com/upgrade-guide/1.9 and we can use the jQuery Migrate plugin. Le 07/04/2016 18:02, Owen Leonard a écrit :
I have filed a new bug with a plan for how to move forward on an upgrade of jQuery in the staff client.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883
This is stuck, so I need to ask for suggestions on how to proceed. Jonathan and I have two different proposals. Mine:
- Create a new include file which uses new version of jQuery and jQueryUI. Name that include file according to the version of jQuery it includes ("doc-head-close-jquery-1.12.0.inc").
- Gradually (page by page or in batches) submit patches which add use of the new include file while making any changes to the affected page(s) to update relevant JavaScript to work with the new versions.
Advantages to this method: Small manageable patches, nothing breaks without warning. Disadvantages to this method: We introduce duplicate versions of doc-head-close.inc which must be kept in sync. There could end up being many many patches.
Jonathan suggests that we update jQuery and jQueryUI without creating a new include file and fixing bugs as we find them.
Advantages to this method: One patch, and we don't have to deal with include file renaming. Disadvantages to this method: It is not known what pages will break because of the new versions of jQuery and jQueryUI.
Jonathan please correct me if I have mis-characterized your proposal.
What does everyone think? Should I bring this up for a vote at the next dev meeting?
-- Owen
-- Julian Maurice <julian.maurice@biblibre.com> BibLibre