ARG! It really is isnt. It is not a typo.
Greetings, $ koha-qa.pl –v 2 –c 4 ... FAIL t/db_dependent/Filter_MARC_ViewPolicy.t OK critic OK forbidden patterns OK pod FAIL spelling isnt ==> isn't OK valid ... $ grep isnt t/db_dependent/Filter_MARC_ViewPolicy.t isnt( $unfiltered_record->field('020'), undef, isnt( $unfiltered_record->field('008'), undef, isnt( $filtered_record->field('020'), undef, isnt( $unfiltered_record->field('020'), undef, isnt( $filtered_record->field('008'), undef, isnt( $unfiltered_record->field('008'), undef, Spelling checks should exclude “isnt(“, right? GPML, Mark Tompsett
You could send a patch/pull request to codespell if you wanted Or you could ignore it, because we don't run that script over the t/ dir Chris On 8 March 2016 at 17:14, Mark Tompsett <mtompset@hotmail.com> wrote:
Greetings,
$ koha-qa.pl –v 2 –c 4 ... FAIL t/db_dependent/Filter_MARC_ViewPolicy.t OK critic OK forbidden patterns OK pod FAIL spelling isnt ==> isn't OK valid ...
$ grep isnt t/db_dependent/Filter_MARC_ViewPolicy.t isnt( $unfiltered_record->field('020'), undef, isnt( $unfiltered_record->field('008'), undef, isnt( $filtered_record->field('020'), undef, isnt( $unfiltered_record->field('020'), undef, isnt( $filtered_record->field('008'), undef, isnt( $unfiltered_record->field('008'), undef,
Spelling checks should exclude “isnt(“, right?
GPML, Mark Tompsett
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Greetings, I went with a patch to add a spelling test exclusion parameter to the test tools. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16003 GPML, Mark Tompsett -----Original Message----- From: Chris Cormack Sent: Monday, March 07, 2016 11:30 PM To: Mark Tompsett Cc: koha-devel@lists.koha-community.org Subject: Re: [Koha-devel] ARG! It really is isnt. It is not a typo. You could send a patch/pull request to codespell if you wanted Or you could ignore it, because we don't run that script over the t/ dir Chris On 8 March 2016 at 17:14, Mark Tompsett <mtompset@hotmail.com> wrote:
Greetings,
$ koha-qa.pl –v 2 –c 4 ... FAIL t/db_dependent/Filter_MARC_ViewPolicy.t OK critic OK forbidden patterns OK pod FAIL spelling isnt ==> isn't OK valid ...
$ grep isnt t/db_dependent/Filter_MARC_ViewPolicy.t isnt( $unfiltered_record->field('020'), undef, isnt( $unfiltered_record->field('008'), undef, isnt( $filtered_record->field('020'), undef, isnt( $unfiltered_record->field('020'), undef, isnt( $filtered_record->field('008'), undef, isnt( $unfiltered_record->field('008'), undef,
Spelling checks should exclude “isnt(“, right?
GPML, Mark Tompsett
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Is there a way to disable the dbuser's ability to login? Since changing the db password is usually fraught with unexpected results, I'd like to be able to just block this access. I figured maybe a preference already exists for that but couldn't find it. Any Koha issue that might arise from doing that? (beside the database upgrade, which I never want the users to face anyway). Thanks
participants (3)
-
Chris Cormack -
Mark Tompsett -
Philippe Blouin