QA Re: FIX in qa-tools
On 2012-10-25, at 1:40 AM, Jonathan Druart wrote:
Hi Mason,
I did not rebase my qa-tools repo and I found a bug in the check of perlcritic. So I fixed it and ... I was not able to push, I was not up-to-date :)
In fact you already tried to fix it in the commit "fixed perlcritic test". But It is not the good way: # If the tested file is deleted in the commit, we return 0 return 0 unless -e $self->path;
# If the tested file is newly created int the commit, (ie: nothing existing to compare too), we call Perl::Critic, not Test::Perl::Critic::Progressive unless (-e $self->path) {
if the path does not exist, the routine returns 0 and does not execute the second unless statement. (and print a warning launching tests: An error occured : Can't use string ("0") as an ARRAY ref while "strict refs" in use at t/Perl.t line 72.).
I think my last commit ("add a new flag "new_file" to mark a file if it is a newly created") fixes correctly the problem but... be careful :)
Jonathan
heya Jonathan thanks for this, ill do some testing then push your changes up to the kc.rg github repo https://github.com/Koha-Community/koha-qa-tools
thanks for this, ill do some testing then push your changes up to the kc.rg github repo https://github.com/Koha-Community/koha-qa-tools
Can we get Galen to set up a repo at the official Koha community git repo (git.koha-community.org) and have these tools there too? github is nice for a backup, but would be nice to have them at the main site too. Thanks Chris
Le 25/10/2012 04:58, Chris Cormack a écrit :
thanks for this, ill do some testing then push your changes up to the kc.rg github repo https://github.com/Koha-Community/koha-qa-tools
Can we get Galen to set up a repo at the official Koha community git repo (git.koha-community.org) and have these tools there too?
github is nice for a backup, but would be nice to have them at the main site too. Agreed. I suggested to have qa tools on contribs/global, but I've nothing against having a completely separate repo.
Who could push ? Anyone from the QA team having push permission ? On the long term, I think we could even automate running this tool when a patch is submitted ! -- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc Tel : (33) 4 91 81 35 08
On 2012-10-25, at 7:45 PM, Paul Poulain wrote:
Le 25/10/2012 04:58, Chris Cormack a écrit :
thanks for this, ill do some testing then push your changes up to the kc.rg github repo https://github.com/Koha-Community/koha-qa-tools
Can we get Galen to set up a repo at the official Koha community git repo (git.koha-community.org) and have these tools there too?
github is nice for a backup, but would be nice to have them at the main site too. Agreed. I suggested to have qa tools on contribs/global, but I've nothing against having a completely separate repo.
+1 either is OK for me
Who could push ? Anyone from the QA team having push permission ?
+1
On the long term, I think we could even automate running this tool when a patch is submitted !
+1 awesome idea also, do we use bugzilla to track patches to this repo (like the koha-manual repo), or not? and slightly off-topic... i think we should rename this tool/repo to something else, as Chris.C has already created another koha-qa-tools repo -> https://gitorious.org/koha-qa-tools sorry to pinch your repo name Chris, i suggest we rename this tool/repo to 'koha-qa-test'
On 2012-10-25, at 3:56 PM, Mason James wrote:
heya Jonathan
thanks for this, ill do some testing then push your changes up to the kc.org github repo
fyi: I've done this, and changed the repo name as promised its now 'koha-qa-test', not 'koha-qa-tool' -> https://github.com/Koha-Community/koha-qa-test I've also added a patch to ignore the many 'Subroutine $FOO redefined' warnings in Koha, that have been causing some false-postive QA fails i think this is the best thing to do, until we fix these warnings... https://github.com/Koha-Community/koha-qa-test/commit/17175212b3b06fac63f881... bug 8559 is a good example of a patch ?incorrectly? failing, due to this warning type -> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559 are people ok with this patch?, or is there a better way?
There is now a repository on git.koha-community.org too http://git.koha-community.org/gitweb/?p=qa-test-tools.git;a=summary Chris -- Chris Cormack Catalyst IT Ltd. +64 4 803 2238 PO Box 11-053, Manners St, Wellington 6142, New Zealand
On 2012-11-2, at 8:15 AM, Chris Cormack wrote:
There is now a repository on git.koha-community.org too
http://git.koha-community.org/gitweb/?p=qa-test-tools.git;a=summary
Chris
thanks Chris, i'll start pushing to there, from today (i;ll probably leave the github/kc.org repo up, as a synced backup)
Hi! Looks good to me in the principle. But are you sure there is a space at the end of the following string? + s/^Subroutine .* redefined $// for @errors; I still don't see the point in using Smart::Comments. For me it is just debug messages and it is not intended to be in the master branch. Perhaps could we use a log module if we want these kind of information to be displayed? For discussion, Jonathan 2012/11/1 Mason James <mtj@kohaaloha.com>
On 2012-10-25, at 3:56 PM, Mason James wrote:
heya Jonathan
thanks for this, ill do some testing then push your changes up to the
kc.org github repo
fyi: I've done this, and changed the repo name as promised
its now 'koha-qa-test', not 'koha-qa-tool' -> https://github.com/Koha-Community/koha-qa-test
I've also added a patch to ignore the many 'Subroutine $FOO redefined' warnings in Koha, that have been causing some false-postive QA fails i think this is the best thing to do, until we fix these warnings...
https://github.com/Koha-Community/koha-qa-test/commit/17175212b3b06fac63f881...
bug 8559 is a good example of a patch ?incorrectly? failing, due to this warning type -> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559
are people ok with this patch?, or is there a better way?
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
On 2012-11-2, at 10:34 PM, Jonathan Druart wrote:
Hi!
Looks good to me in the principle.
But are you sure there is a space at the end of the following string? + s/^Subroutine .* redefined $// for @errors;
yes, there is a trailing space
I still don't see the point in using Smart::Comments. For me it is just debug messages and it is not intended to be in the master branch.
currently, any debug messages can be deleted, none are important
Perhaps could we use a log module if we want these kind of information to be displayed?
ok great, please use a log module to display/log any info you want but, please leave the 'use Smart::Comments' statements, i need these to continue to debug using S::C
participants (5)
-
Chris Cormack -
Chris Cormack -
Jonathan Druart -
Mason James -
Paul Poulain