Hacker's corner, week 19
Hello, Sorry for staying silent for 4 weeks, but after the hackfest, I've been AFK for one week, then needed 2 weeks not to be late anymore on my daily stuff... So, here it is: Last week, 220 messages have been sent to the bugs mailing list (reminder, each change on a bug means a mail) Patches to sign-off =========== After the hackfest, there were 112 bugs waiting for sign-off. Today, this number has increased again: 139 bugs are waiting for you ! Some are related to CRItical bugs, so they're really worth a signature: 6292 Overdue notices have a bug when multiple overdues exist <http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6292> 5860Adding duplicate stocknumber will fail silently <http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5860> 5683 link_bibs_to_authorities.pl can corrupt records <http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5683> 5379import_borrowers.pl fails with db insert/update errors <http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5379> 4993 ldap search always anonymous when using auth_by_bind <http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4993> 3652XSS vulnerabilities <http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3652> 2246 Label printing doesn't work with Unicode characters <http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2246> All other are worth a signature though. Patches signed-off =========== 19 patches have been signed-off. Almost 10 different individuals have signed-off something. Congrats to Nicole, that is "sign-off of the week" ! Shame on all other developers (including me) that have signed-off nothing last week... Patches pushed ========= Chris has pushed only 4 patches last week. It means there is now 18 patches that can be pushed and will probably be soon. -- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc Tel : (33) 4 91 81 35 08
On 10 May 2011 03:25, Paul Poulain <paul.poulain@biblibre.com> wrote:
Hello,
Sorry for staying silent for 4 weeks, but after the hackfest, I've been AFK for one week, then needed 2 weeks not to be late anymore on my daily stuff...
So, here it is: Last week, 220 messages have been sent to the bugs mailing list (reminder, each change on a bug means a mail)
Patches to sign-off =========== After the hackfest, there were 112 bugs waiting for sign-off. Today, this number has increased again: 139 bugs are waiting for you ! Some are related to CRItical bugs, so they're really worth a signature: 6292 Overdue notices have a bug when multiple overdues exist <http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6292> 5860Adding duplicate stocknumber will fail silently <http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5860> 5683 link_bibs_to_authorities.pl can corrupt records <http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5683> 5379import_borrowers.pl fails with db insert/update errors <http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5379> 4993 ldap search always anonymous when using auth_by_bind <http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4993> 3652XSS vulnerabilities <http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3652> 2246 Label printing doesn't work with Unicode characters <http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2246> All other are worth a signature though.
Patches signed-off =========== 19 patches have been signed-off. Almost 10 different individuals have signed-off something. Congrats to Nicole, that is "sign-off of the week" ! Shame on all other developers (including me) that have signed-off nothing last week...
Patches pushed ========= Chris has pushed only 4 patches last week. It means there is now 18 patches that can be pushed and will probably be soon.
Actually for 3.6.x the workflow has changed slightly. http://wiki.koha-community.org/wiki/Bug-enhancement-patch_Workflow Step 5 has been added, so in the next few days Ian will be setting those signed off bugs to passed qa, I will do a final test, then merge to master. I then make a note for Chris N, whether I think they are suitable for 3.4.x. We have a wiki page for this http://wiki.koha-community.org/wiki/Commits_to_cherry-pick_for_3.4 And then he makes the final decision on what to pull in. There is another link (should be on the bottom of the bugzilla page) or at http://koha-releasemanagement.branchable.com/ for a list of bugs that are sitting at passed qa. This frees me up to do some signoffs on patches too, and get them to the signed off state, as someone else (Ian) will still look at them too. And having me do the final sign off affords Ian the opportunity to. It means we can both sign off on patches without the risk of either of us being the only sign off. So every patch gets at least 2 sign offs, most 3, and we have a rock solid 3.4.x and 3.6.0 :) Chris
On Tue, May 10, 2011 at 06:43:11AM +1200, Chris Cormack wrote:
Actually for 3.6.x the workflow has changed slightly.
http://wiki.koha-community.org/wiki/Bug-enhancement-patch_Workflow
Excuse me, but I don't quote understand how my batch of LDAP fixes (Koha bugs 4993, 4994 and 6022) will get into bug/enhancement? Would it help to merge all LDAP changes in single bug and submit that? I have been using this code for years, and it seems that only few users use LDAP with auth_by_bind in Koha. I was recently contacted by one library which had problem with it, so there is interest other than my own library needs. -- Dobrica Pavlinusic 2share!2flame dpavlin@rot13.org Unix addict. Internet consultant. http://www.rot13.org/~dpavlin
Le 09/05/2011 20:43, Chris Cormack a écrit :
Actually for 3.6.x the workflow has changed slightly.
http://wiki.koha-community.org/wiki/Bug-enhancement-patch_Workflow oups, I missed this change. When has it been discussed/decided/announced ?
-- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc Tel : (33) 4 91 81 35 08
Did not see it either until now.. I would say that at least a discussion on irc or meeting could go together with asking input on dev list? Or maybe I missed that one. ________________________________________ Van: koha-devel-bounces@lists.koha-community.org [koha-devel-bounces@lists.koha-community.org] namens Paul Poulain [paul.poulain@biblibre.com] Verzonden: dinsdag 10 mei 2011 18:55 Aan: koha-devel@lists.koha-community.org Onderwerp: Re: [Koha-devel] Hacker's corner, week 19 Le 09/05/2011 20:43, Chris Cormack a écrit :
Actually for 3.6.x the workflow has changed slightly.
http://wiki.koha-community.org/wiki/Bug-enhancement-patch_Workflow oups, I missed this change. When has it been discussed/decided/announced ?
-- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc Tel : (33) 4 91 81 35 08 _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
* Marcel de Rooy (M.de.Rooy@rijksmuseum.nl) wrote:
Did not see it either until now.. I would say that at least a discussion on irc or meeting could go together with asking input on dev list? Or maybe I missed that one.
It's not a new thing http://wiki.koha-community.org/wiki/Roadmap_to_3.4 "All patches should have at least 1 signoff before the Release Manager looks at them, (exceptions will be made for trivial patches). Preferably 2 signoffs, 1 from the QA manager and 1 from someone else. Although 1 from the QA manager will suffice." And here http://lists.koha-community.org/pipermail/koha-devel/2010-November/034655.ht... And in fact the idea goes back all the way to the first QA manager. We didn't manage to pull it off for 3.4, (we sort of did for 3.0), 3.2 we didnt have a QA manager http://koha.1045719.n5.nabble.com/Summary-of-community-meeting-on-koha-td305.... We are trying again for 3.6. So its not a new idea, all that is new is clarifying the procedure (on what is a relatively new wiki page). Chris -- Chris Cormack Catalyst IT Ltd. +64 4 803 2238 PO Box 11-053, Manners St, Wellington 6142, New Zealand
participants (5)
-
Chris Cormack -
Chris Cormack -
Dobrica Pavlinusic -
Marcel de Rooy -
Paul Poulain