Hie, With plack when some code fails, there is always in log a reference to circ/returns.pl o_O at start of stack trace. I found that there is in this page : use Carp 'verbose'; $SIG{ __DIE__ } = sub { Carp::confess( @_ ) }; Added by commit bb6277ffcc593685554112d770ac273c9efeda33 Bug 14464: Add ability to cancel waiting holds from checkin screen Is this for debug purpopse only ? Why only this page ? Should it be moved to plack.psgi ? Regards, -- Fridolin SOMERS <fridolin.somers@biblibre.com> BibLibre - software and system maintainer
We need to get rid of that. El jue., 30 de nov. de 2017 7:05 a. m., Francesco Rivetti <oha@oha.it> escribió:
On 30. nov. 2017 09:57, Fridolin SOMERS wrote:
use Carp 'verbose'; $SIG{ __DIE__ } = sub { Carp::confess( @_ ) };
I think it will be applied to all pages (and everything) _AFTER_ this is run the first time on that forked process
F _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
-- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/>) ✆ +54 9351 3513384 GPG: B2F3C15F
Looks like debug code to me. I’ve used things like that before in development, but I don’t know why you’d have it in production code… David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595 From: koha-devel-bounces@lists.koha-community.org [mailto:koha-devel-bounces@lists.koha-community.org] On Behalf Of Tomas Cohen Arazi Sent: Thursday, 30 November 2017 9:20 PM To: Francesco Rivetti <oha@oha.it> Cc: koha-devel@lists.koha-community.org Subject: Re: [Koha-devel] SIG DIE in returns.pl We need to get rid of that. El jue., 30 de nov. de 2017 7:05 a. m., Francesco Rivetti <oha@oha.it <mailto:oha@oha.it> > escribió: On 30. nov. 2017 09:57, Fridolin SOMERS wrote:
use Carp 'verbose'; $SIG{ __DIE__ } = sub { Carp::confess( @_ ) };
I think it will be applied to all pages (and everything) _AFTER_ this is run the first time on that forked process F _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ -- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/> ) ✆ +54 9351 3513384 GPG: B2F3C15F
See bug 19746, please SO+QA On Thu, 30 Nov 2017 at 05:57 Fridolin SOMERS <fridolin.somers@biblibre.com> wrote:
Hie,
With plack when some code fails, there is always in log a reference to circ/returns.pl o_O at start of stack trace.
I found that there is in this page :
use Carp 'verbose'; $SIG{ __DIE__ } = sub { Carp::confess( @_ ) };
Added by commit bb6277ffcc593685554112d770ac273c9efeda33 Bug 14464: Add ability to cancel waiting holds from checkin screen
Is this for debug purpopse only ? Why only this page ? Should it be moved to plack.psgi ?
Regards,
-- Fridolin SOMERS <fridolin.somers@biblibre.com> BibLibre - software and system maintainer _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Cool, thanks for creating the post on bugzilla. I see it is Passed QA Le 04/12/2017 à 20:09, Jonathan Druart a écrit :
See bug 19746, please SO+QA
On Thu, 30 Nov 2017 at 05:57 Fridolin SOMERS <fridolin.somers@biblibre.com> wrote:
Hie,
With plack when some code fails, there is always in log a reference to circ/returns.pl o_O at start of stack trace.
I found that there is in this page :
use Carp 'verbose'; $SIG{ __DIE__ } = sub { Carp::confess( @_ ) };
Added by commit bb6277ffcc593685554112d770ac273c9efeda33 Bug 14464: Add ability to cancel waiting holds from checkin screen
Is this for debug purpopse only ? Why only this page ? Should it be moved to plack.psgi ?
Regards,
-- Fridolin SOMERS <fridolin.somers@biblibre.com> BibLibre - software and system maintainer _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
-- Fridolin SOMERS <fridolin.somers@biblibre.com> BibLibre - software and system maintainer
Just to confirm, that was added as a debugging aid and I forgot to take it out when I was done. Thanks for catching it! 2017-12-11 1:31 GMT-07:00 Fridolin SOMERS <fridolin.somers@biblibre.com>:
Cool, thanks for creating the post on bugzilla. I see it is Passed QA
Le 04/12/2017 à 20:09, Jonathan Druart a écrit :
See bug 19746, please SO+QA
On Thu, 30 Nov 2017 at 05:57 Fridolin SOMERS < fridolin.somers@biblibre.com> wrote:
Hie,
With plack when some code fails, there is always in log a reference to circ/returns.pl o_O at start of stack trace.
I found that there is in this page :
use Carp 'verbose'; $SIG{ __DIE__ } = sub { Carp::confess( @_ ) };
Added by commit bb6277ffcc593685554112d770ac273c9efeda33 Bug 14464: Add ability to cancel waiting holds from checkin screen
Is this for debug purpopse only ? Why only this page ? Should it be moved to plack.psgi ?
Regards,
-- Fridolin SOMERS <fridolin.somers@biblibre.com> BibLibre - software and system maintainer _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
-- Fridolin SOMERS <fridolin.somers@biblibre.com> BibLibre - software and system maintainer _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
-- Jesse Weaver
participants (6)
-
David Cook -
Francesco Rivetti -
Fridolin SOMERS -
Jesse -
Jonathan Druart -
Tomas Cohen Arazi