Hi all, I am wondering whether this is good or not but in the directory of the includes there appeared a css file with hard coded path of .koha { text-align:center; background-image:url("/intranet-tmpl/default/en/images/background-mem.gif"); } Now if the whole idea by introducing templates was to separate the code from the design then this behavior does not stick to the rules. A person who tries to maintain a given translation needs to visually inspect every aspect of code in order not to overlook those kind of changes. An example: a file in .default/en directory changes. The modification includes a language string and a path to a perl file ON THE SAME LINE OF CODE. Not all diff software packages will show both but rather the whole line will be highlighted as having been modified. For a translator that means visual inspection of the code. Translators are NOT programmers. They may overlook a lot of such little modifications. I have voiced this over and over again that there is something wrong about the way koha chose to internationalize. Before koha-1.2.3 all the language strings where in the perl scripts. Now they are found in the template files. I wonder whether there exists a method of still going back to a flavor of GETTEXT to take care of translations? Benedict
On 2003-10-27 10:19:03 +0000 Benedykt <kb2qzv@poczta.wp.pl> wrote:
background-image:url("/intranet-tmpl/default/en/images/background-mem.gif");
What should this be, in your opinion?
Not all diff software packages will show both but rather the whole line will be highlighted as having been modified. For a translator that means visual inspection of the code. Translators are NOT programmers. They may overlook a lot of such little modifications.
Shouldn't the translator look at the changed lines anyway? I'm probably not understanding what you mean here.
Before koha-1.2.3 all the language strings where in the perl scripts. Now they are found in the template files. I wonder whether there exists a method of still going back to a flavor of GETTEXT to take care of translations?
Gettext has its own problems, I hear from someone working on Indian translations. It is a step forwards from us now, though. I thjnk it would not be too difficult to do, but time-consuming. What is the opinion of the release manager about translations? Can we put localisation and internationalisation fixes into 2.0, must we have them, or should we wait? -- MJR/slef My Opinion Only and possibly not of any group I know. Please http://remember.to/edit_messages on lists to be sure I read http://mjr.towers.org.uk/ gopher://g.towers.org.uk/ slef@jabber.at Creative copyleft computing services via http://www.ttllp.co.uk/
On 27 Oct 2003 at 10:35, MJ Ray wrote:
On 2003-10-27 10:19:03 +0000 Benedykt <kb2qzv@poczta.wp.pl> wrote:
background-image:url("/intranet-tmpl/default/en/images/background-mem.gif");
What should this be, in your opinion? I think that perhaps it should be, say url("themelang/images/background-mem.gif"); But I am not sure.
Benedict
Benedykt wrote:
On 27 Oct 2003 at 10:35, MJ Ray wrote:
On 2003-10-27 10:19:03 +0000 Benedykt <kb2qzv@poczta.wp.pl> wrote:
background-image:url("/intranet-tmpl/default/en/images/background-mem.gif");
What should this be, in your opinion?
I think that perhaps it should be, say url("themelang/images/background-mem.gif"); But I am not sure.
It should be : url("<TMPL_VAR name="themelang">/images/back..."); We tried this... Then we discovered that HTMPL::Template can't support it, as the url() is in an included file : &nd included files are NOT parsed. they are included as it. Too bad, and too late discovery. that's why we have "hardcoded" directory... (note it's a language independant image, so it's not a big problem : english is always installed, as it's used when the chosen language is not found) -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)
On 2003-11-03 13:41:58 +0000 paul POULAIN <paul.poulain@free.fr> wrote:
Then we discovered that HTMPL::Template can't support it, as the url() is in an included file : &nd included files are NOT parsed. they are included as it.
This is because the url() part is in a css file not a template? Is there a known problem with moving it into an inline stylesheet in the template, or shall I try it? -- MJR/slef My Opinion Only and possibly not of any group I know. Please http://remember.to/edit_messages on lists to be sure I read http://mjr.towers.org.uk/ gopher://g.towers.org.uk/ slef@jabber.at Creative copyleft computing services via http://www.ttllp.co.uk/
MJ Ray wrote:
On 2003-11-03 13:41:58 +0000 paul POULAIN <paul.poulain@free.fr> wrote:
Then we discovered that HTMPL::Template can't support it, as the url() is in an included file : &nd included files are NOT parsed. they are included as it.
This is because the url() part is in a css file not a template? Is there a known problem with moving it into an inline stylesheet in the template, or shall I try it?
You're right, and I was wrong. No problem i think, except for traffic increase (i agree it's a little problem). -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)
On 2003-10-27 10:46:37 +0000 Benedykt <kb2qzv@poczta.wp.pl> wrote:
background-image:url("/intranet-tmpl/default/en/images/background-mem.gif"); What should this be, in your opinion? I think that perhaps it should be, say url("themelang/images/background-mem.gif"); But I am not sure.
Actually, it looks to me like it should work as-is. Doesn't it? -- MJR/slef My Opinion Only and possibly not of any group I know. Please http://remember.to/edit_messages on lists to be sure I read http://mjr.towers.org.uk/ gopher://g.towers.org.uk/ slef@jabber.at Creative copyleft computing services via http://www.ttllp.co.uk/
participants (3)
-
Benedykt -
MJ Ray -
paul POULAIN