Re: [Koha-devel] [Koha-patches] [PATCH] Replace TMPL_ELSIF with TMPL_ELSE and TMPL_IF in label-manager.tmpl;
On 2008/08/27, at 3:34 PM, Joe Atzberger wrote:
On Tue, Aug 26, 2008 at 7:00 PM, MJ Ray <mjr@phonecoop.coop> wrote: Mason James <mason.loves.sushi@gmail.com> wrote:
On 2008/07/29, at 11:37 PM, MJ Ray wrote:
Consider this the first, then! http://rt.cpan.org/Ticket/Display.html?id=38013 [...] I've just built HTML-Template-Pro-0.70 fine on my OSX 10.4 box, 1st go even. MJR, This may well be an issue with your specific system alone?,
I don't see why. The then-current H:T:P built fine for me too on the same system under 10.4, but fails under 10.5. The maintainer hasn't yet suggested that it's a local configuration error and it's hard to see how it could be - I've changed very few settings. It might be a problem with fink or perl on 10.5, but I probably won't be the only user of those versions.
See the Known Problems section of the perlmacos perldoc:
If you have installed extra libraries such as GDBM through Fink (in other words, you have libraries under /sw/lib), or libdlcompat to / usr/local/lib, you may need to be extra careful when running Configure to not to confuse Configure and Perl about which libraries to use.
Sounds like a likely vector.
I think we do need to properly prove that H:T:P's ELSIF's are buggy before we remove them, as they make the template logic a lot saner
IF ... ELSIF ... /IF isn't much saner than IF ... ELSE IF ... /IF /IF
It is saner. And as you increase the depth, it is exceedingly saner.
<!-- TMPL_IF NAME="var1" --> <!-- TMPL_ELSE --> <!-- TMPL_IF NAME="var2" --> <!-- TMPL_ELSE --> <!-- TMPL_IF NAME="var3" --> <!-- TMPL_ELSE --> <!-- TMPL_IF NAME="var4" --> <!-- /TMPL_IF --> <!-- /TMPL_IF --> <!-- /TMPL_IF --> <!-- /TMPL_IF -->
vs.
<!-- TMPL_IF NAME="var1" --> <!-- TMPL_ELSIF NAME="var2" --> <!-- TMPL_ELSIF NAME="var3" --> <!-- TMPL_ELSIF NAME="var4" --> <!-- /TMPL_IF -->
Hi Guys, Yeah, its those examples that make my eyes water too!! ;) Ok so we are at a bit of a stalemate for now... I'm gonna ping walter@katipo and see if he can compile H:T:P on his OSX-10.5 boxes MJR: can you replicate it easily on another 10.5 box? PS: they (read: OSX boxes) can be tricky to set up LAMP/WAMP? stuff on for new admins, I got veeeery close to getting a koha3 running on my OSX after a few weeks of futzing (Ryan says it can be done ;), but gave into a deb VM instead. On a final note, I think some of the newer features in H:T:P are (when proven stable) going to really help bring the templates to a level of cleanliness and readability that most of the other areas of code are now looking (thanks everyone) Anyone else on the list have a 10.5 box to have a go at this? $ cpan HTML::Template::Pro Mason.
Mason James wrote:
PS: they (read: OSX boxes) can be tricky to set up LAMP/WAMP? stuff on for new admins, I got veeeery close to getting a koha3 running on my OSX after a few weeks of futzing (Ryan says it can be done ;), but gave into a deb VM instead.
I don't have an Intel Mac yet. Once I do, can I presume that it will run Linux in Parallels? That would be g-r-e-a-t!
On a final note, I think some of the newer features in H:T:P are (when proven stable) going to really help bring the templates to a level of cleanliness and readability that most of the other areas of code are now looking (thanks everyone)
Anyone else on the list have a 10.5 box to have a go at this?
$ cpan HTML::Template::Pro
I gave it a go on Leopardo. One error during the make test: *** test_expr8.out 2008-04-04 04:51:05.000000000 +1100 --- test_expr8.raw 2008-08-27 23:36:50.000000000 +1000 *************** *** 6,12 **** <b>70</b> <b>70</b> ! <b>200001000000</b> <b>70</b> <b>70</b> <b>1</b> --- 6,12 ---- <b>70</b> <b>70</b> ! <b>-1862462912</b> <b>70</b> <b>70</b> <b>1</b> # Failed test 15 in t/HTML-Template-Expr.t at line 87 fail #8 I've left it at that since I do not intend to install Koha or any more perl stuff on my Mac. Apple stuffed up Perl pretty bad in Leopard, IMHO. I'm transitioning to python for all scripting anyway, so I'm saying bye to perl on Macs. I'll leave Perl to sane environs like Linux. (Yeah, yeah, I *could* trash perl and reinstall from scratch, but life is too short!) Hey, now that's an idea! pyKoha! Any takers? cheers rickw -- ________________________________________________________________ Rick Welykochy || Praxis Services || Internet Driving Instructor The problem with adults is that they are contaminated by experience. -- Kumi Naidoo, General Secretary and CEO of CIVICUS
Hi, On Wed, Aug 27, 2008 at 8:41 AM, Rick Welykochy <rick@praxis.com.au> wrote:
Hey, now that's an idea! pyKoha! Any takers?
Heh. I'm surprised that nobody (that I'm aware of) has started a Python-based ILS yet. Regards, Galen -- Galen Charlton VP, Research & Development, LibLime galen.charlton@liblime.com p: 1-888-564-2457 x709 skype: gmcharlt
Galen Charlton wrote:
Hi,
On Wed, Aug 27, 2008 at 8:41 AM, Rick Welykochy <rick@praxis.com.au> wrote:
Hey, now that's an idea! pyKoha! Any takers?
Heh. I'm surprised that nobody (that I'm aware of) has started a Python-based ILS yet.
Regards,
Galen
I've been telling people that python is perl with a sane syntax (ducks for cover ;-). A quick google for "python call perl" indicates that it should work to migrate perl code to python incrementally, calling the existing perl functions and libraries until (if) the function/library gets migrated to python. <http://www.google.com/search?q=python+call+perl&ie=utf-8&oe=utf-8&aq=t&rls=org.mozilla:en-US:official&client=firefox-a> A quick scan makes these look like good starting points: <http://search.cpan.org/~gaas/pyperl-1.0/perlmodule.pod> <http://wiki.python.org/moin/PyPerl> I would love to tackle this to help my knowledge of koha, perl, and because I like python better than perl, but I'm overcommited on volunteer projects already. :-( Best regards, gvb
participants (4)
-
Galen Charlton -
JerryVanBaren -
Mason James -
Rick Welykochy