CVS: koha/acqui.simple addbookslccn.pl,1.1,1.2
Update of /cvsroot/koha/koha/acqui.simple In directory usw-pr-cvs1:/tmp/cvs-serv9617 Modified Files: addbookslccn.pl Log Message: Fixing branches Index: addbookslccn.pl =================================================================== RCS file: /cvsroot/koha/koha/acqui.simple/addbookslccn.pl,v retrieving revision 1.1 retrieving revision 1.2 diff -C2 -r1.1 -r1.2 *** addbookslccn.pl 6 Nov 2001 18:15:00 -0000 1.1 --- addbookslccn.pl 31 Mar 2002 02:48:18 -0000 1.2 *************** *** 12,16 **** use C4::Acquisitions; use C4::Output; ! my $input = new CGI; --- 12,16 ---- use C4::Acquisitions; use C4::Output; ! use C4::Circulation::Circ2; my $input = new CGI; *************** *** 311,315 **** <input type=hidden name=biblioitemnumber value=$biblioitemnumber> <table> ! <tr><td>BARCODE</td><td><input name=barcode size=10 value=$maxbarcode> Home Branch: <select name=homebranch><option value='STWE'>Stewart Elementary<option value='MEZ'>Meziadin Elementary</select></td></tr> </tr><td colspan=2>Replacement Price: <input name=replacementprice size=10></td></tr> <tr><td>Notes</td><td><textarea name=notes rows=4 cols=40 --- 311,322 ---- <input type=hidden name=biblioitemnumber value=$biblioitemnumber> <table> ! <tr><td>BARCODE</td><td><input name=barcode size=10 value=$maxbarcode> Home Branch: <select name=homebranch> ! EOF ! my $branches=getbranches(); ! foreach my $key (sort(keys %$branches)) { ! print "<option value=\"$key\">$branches->{$key}->{'branchname'}</option>"; ! } ! print << "EOF"; ! </select></td></tr> </tr><td colspan=2>Replacement Price: <input name=replacementprice size=10></td></tr> <tr><td>Notes</td><td><textarea name=notes rows=4 cols=40
Chris Cormack wrote:
Update of /cvsroot/koha/koha/acqui.simple
There seem to be some lingering addbooks.pl problems with my implementation: When I click on "Enter book with no ISBN" I get this in http error log: DBD::mysql::st execute failed: You have an error in your SQL syntax near '' at line 2 at /var/www/cgi-bin/koha/acqui.simple/addbooks.pl line 280. DBD::mysql::st fetchrow failed: fetch() without execute() at /var/www/cgi-bin/koha/acqui.simple/addbooks.pl line 281. If I change this from: biblioitems where bibiloitemnumber=$biblioitemnumber (around line number 275) ...to a valid hard-coded value, say: biblioitems where bibiloitemnumber=8 then I get no error... and an extra table: "Existing Items with ISBN NULL" appears in the web page (which I assume signifies correct completion - I have not previously seen that table appear :-) I was wondering if someone (who understands perl better than I do) could have a look at the logic there and see if it's suspect? Thanks, R.
On Sun, Mar 31, 2002 at 01:35:50PM +1000, Roger Buck said:
Chris Cormack wrote:
Update of /cvsroot/koha/koha/acqui.simple
There seem to be some lingering addbooks.pl problems with my implementation:
When I click on "Enter book with no ISBN" I get this in http error log:
DBD::mysql::st execute failed: You have an error in your SQL syntax near '' at line 2 at /var/www/cgi-bin/koha/acqui.simple/addbooks.pl line 280. DBD::mysql::st fetchrow failed: fetch() without execute() at /var/www/cgi-bin/koha/acqui.simple/addbooks.pl line 281.
If I change this from:
biblioitems where bibiloitemnumber=$biblioitemnumber
(around line number 275)
...to a valid hard-coded value, say:
biblioitems where bibiloitemnumber=8
then I get no error... and an extra table:
"Existing Items with ISBN NULL"
appears in the web page (which I assume signifies correct completion - I have not previously seen that table appear :-)
I was wondering if someone (who understands perl better than I do) could have a look at the logic there and see if it's suspect?
Looks suspect to me. Im the problem is $biblioitemnumber is empty ... im not sure what is supposed to happen but that query is never going to work from that link. Chris -- Chris Cormack Programmer 025 500 789 Katipo Communications Ltd chris@katipo.co.nz www.katipo.co.nz
Chris Cormack wrote:
Update of /cvsroot/koha/koha/acqui.simple
I think addbooks.pl and addbookslccn.pl do not appear to add the selected branch information to the db from the drop-down options. Im also pretty sure that the biblioitemnumber routine is broken when adding a new item using NULL value for ISBN and /or LCCN I've spent a long time playing around with various options but have come to a dead end. R.
On Sun, Mar 31, 2002 at 04:06:07PM +1000, Roger Buck said:
Chris Cormack wrote:
Update of /cvsroot/koha/koha/acqui.simple
I think addbooks.pl and addbookslccn.pl do not appear to add the selected branch information to the db from the drop-down options.
Im also pretty sure that the biblioitemnumber routine is broken when adding a new item using NULL value for ISBN and /or LCCN
Yep working on them now. Bear in mind the cvs files are in the cvs not the tarball release just yet since lots of them arent deemed stable enuff for release. So its good to go through testing them now, before we do a relase. Chris -- Chris Cormack Programmer 025 500 789 Katipo Communications Ltd chris@katipo.co.nz www.katipo.co.nz
participants (3)
-
Chris Cormack -
Chris Cormack -
Roger Buck