Re: [Koha-devel] items.wthdrawn
Repeating spelling errors only complicates coding and requires excessive attention to past mistakes. Joshua Ferraro had agreed with me when we discussed that point two or three months ago. The arrangement which I made with Joshua over spelling errors in column names which were used in the MARC frameworks was that I would correct spelling errors in the frameworks and he would ensure that the spelling errors were corrected in the rest of the code. Fixing the spelling errors throughout the code should require only a simple script. Leaving spelling errors is only likely to promote future errors in coding as uncorrected spelling errors accumulate. Eventually, a special dictionary of Koha would be required if errors go uncorrected. Thomas Dukleth Agogme 109 E 9th Street, 3D New York, NY 10003 USA http://www.agogme.com 212-674-3783 On Tue, November 27, 2007 4:19 pm, Galen Charlton wrote:
Hi,
Alas, the withdrawn status column in the items table is called 'wthdrawn', not 'withdrawn'. This is observed in most places in the code except for (as I discovered) some of the MARC 21 framework initialization SQL.
I'm going to replace references to 'items.withdrawn' with 'items.wthdrawn'. While I would prefer to spell the column correctly, sticking with 'wthdrawn' for now affects rather fewer files. I'll wait for 3.2 to rename the column.
Regards,
Galen -- Galen Charlton Koha Application Developer LibLime galen.charlton@liblime.com p: 1-888-564-2457 x709
_______________________________________________ Koha-devel mailing list Koha-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/koha-devel
Hi, On 11/27/07, Thomas Dukleth <kohadevel@agogme.com> wrote:
The arrangement which I made with Joshua over spelling errors in column names which were used in the MARC frameworks was that I would correct spelling errors in the frameworks and he would ensure that the spelling errors were corrected in the rest of the code.
The issue is that having the discrepancy breaks the functionality of editing the items withdrawn status field.
Fixing the spelling errors throughout the code should require only a simple script. Leaving spelling errors is only likely to promote future errors in coding as uncorrected spelling errors accumulate. Eventually, a special dictionary of Koha would be required if errors go uncorrected.
I would be more than happy to submit a patch to change 'wthdrawn' to 'withdrawn' once and for all. However, even as mechanical a change as that requires testing to ensure that no functionality is broken and that there are no instances in the code where a column name is being constructed in an unusual fashion. My question is this: do we do such a change now in 3.0 pre-beta, or push it to the next unstable version (i.e., 3.1/3.2)? Regards, Galen -- Galen Charlton Koha Application Developer LibLime galen.charlton@liblime.com p: 1-888-564-2457 x709
Galen Charlton a écrit :
My question is this: do we do such a change now in 3.0 pre-beta, or push it to the next unstable version (i.e., 3.1/3.2)?
I vote NO for doing it nowe. definetly. -- Paul POULAIN BibLibre SARL Expert en Logiciels Libres pour l'info-doc Tel : 04 91 31 45 19
participants (3)
-
Galen Charlton -
Paul POULAIN -
Thomas Dukleth