Hi all, I'm curious to know why is Koha's cardnumber field in borrowers table is historically set to VARCHAR(16) rather than say VARCHAR(255)? Especially since we now have the CardnumberLength syspref which we could use to drive the length rather than hardcode it down at 16. The background of this question: Schools in Nigeria use a matriculation number which is often larger than 16, as their cardnumber. Zeno did mention to me in a FB post that ExtendedPatronAttribute would equally do the job. Thoughts? -indranil -- Indranil Das Gupta L2C2 Technologies Phone : +91-98300-20971 Blog : http://blog.l2c2.co.in IRC : indradg on irc://irc.freenode.net Twitter : indradg
Hi Indranil, I do not think there is any valid reason, I guess 16 looked enough at the time. If you want to extend it, feel free to submit a patch. Cheers, Jonathan 2016-09-14 0:15 GMT+01:00 Indranil Das Gupta <indradg@gmail.com>:
Hi all,
I'm curious to know why is Koha's cardnumber field in borrowers table is historically set to VARCHAR(16) rather than say VARCHAR(255)? Especially since we now have the CardnumberLength syspref which we could use to drive the length rather than hardcode it down at 16.
The background of this question: Schools in Nigeria use a matriculation number which is often larger than 16, as their cardnumber. Zeno did mention to me in a FB post that ExtendedPatronAttribute would equally do the job.
Thoughts?
-indranil
-- Indranil Das Gupta L2C2 Technologies
Phone : +91-98300-20971 Blog : http://blog.l2c2.co.in IRC : indradg on irc://irc.freenode.net Twitter : indradg _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
+1 I've seen this become a pain point before; I definitely support extending it. On Wed, Sep 14, 2016 at 3:25 AM, Jonathan Druart < jonathan.druart@bugs.koha-community.org> wrote:
Hi Indranil,
I do not think there is any valid reason, I guess 16 looked enough at the time. If you want to extend it, feel free to submit a patch.
Cheers, Jonathan
2016-09-14 0:15 GMT+01:00 Indranil Das Gupta <indradg@gmail.com>:
Hi all,
I'm curious to know why is Koha's cardnumber field in borrowers table is historically set to VARCHAR(16) rather than say VARCHAR(255)? Especially since we now have the CardnumberLength syspref which we could use to drive the length rather than hardcode it down at 16.
The background of this question: Schools in Nigeria use a matriculation number which is often larger than 16, as their cardnumber. Zeno did mention to me in a FB post that ExtendedPatronAttribute would equally do the job.
Thoughts?
-indranil
-- Indranil Das Gupta L2C2 Technologies
Phone : +91-98300-20971 Blog : http://blog.l2c2.co.in IRC : indradg on irc://irc.freenode.net Twitter : indradg _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
+1 For a related bug see: Bug 15690 - Unconstrained CardnumberLength preference conflicts with table column limit of 16 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15690 Marc Am 14.09.2016 um 14:58 schrieb Barton Chittenden:
+1
I've seen this become a pain point before; I definitely support extending it.
On Wed, Sep 14, 2016 at 3:25 AM, Jonathan Druart <jonathan.druart@bugs.koha-community.org <mailto:jonathan.druart@bugs.koha-community.org>> wrote:
Hi Indranil,
I do not think there is any valid reason, I guess 16 looked enough at the time. If you want to extend it, feel free to submit a patch.
Cheers, Jonathan
2016-09-14 0:15 GMT+01:00 Indranil Das Gupta <indradg@gmail.com <mailto:indradg@gmail.com>>: > Hi all, > > I'm curious to know why is Koha's cardnumber field in borrowers table > is historically set to VARCHAR(16) rather than say VARCHAR(255)? > Especially since we now have the CardnumberLength syspref which we > could use to drive the length rather than hardcode it down at 16. > > The background of this question: Schools in Nigeria use a > matriculation number which is often larger than 16, as their > cardnumber. Zeno did mention to me in a FB post that > ExtendedPatronAttribute would equally do the job. > > Thoughts? > > -indranil > > -- > Indranil Das Gupta > L2C2 Technologies > > Phone : +91-98300-20971 > Blog : http://blog.l2c2.co.in > IRC : indradg on irc://irc.freenode.net <http://irc.freenode.net> > Twitter : indradg > _______________________________________________ > Koha-devel mailing list > Koha-devel@lists.koha-community.org <mailto:Koha-devel@lists.koha-community.org> > http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel <http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel> > website : http://www.koha-community.org/ > git : http://git.koha-community.org/ > bugs : http://bugs.koha-community.org/ <http://bugs.koha-community.org/> _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org <mailto:Koha-devel@lists.koha-community.org> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel <http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel> website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ <http://bugs.koha-community.org/>
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
Greetings, Thanks, Marc V. for the bugzilla link. I’ve added an amendment to that bug which should make a separate “resize the cardnumber” bug very simple (Yes, +1 to the idea of increasing its size). Feel free to test bug 15690. Look at a preference and run a prove. Not very hard. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15690 GPML, Mark Tompsett
I agree that 16 was chosen "because 16 was chosen", so no real explanation. I agree that we could extend it. Extending it to 255 seems a little bit overkill to me : the larger the patron DB row is, the worst it is (comment related to biblioitems embedding marclxml, see an thread I've started here a few months ago) Le 15/09/2016 à 01:33, Mark Tompsett a écrit :
Greetings, Thanks, Marc V. for the bugzilla link. I’ve added an amendment to that bug which should make a separate “resize the cardnumber” bug very simple (Yes, +1 to the idea of increasing its size). Feel free to test bug 15690. Look at a preference and run a prove. Not very hard. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15690 GPML, Mark Tompsett
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
-- Paul Poulain, Associé-gérant / co-owner BibLibre, Services en logiciels libres pour les bibliothèques BibLibre, Open Source software and services for libraries
participants (6)
-
Barton Chittenden -
Indranil Das Gupta -
Jonathan Druart -
Marc Véron -
Mark Tompsett -
Paul Poulain