Updating SCSS lint process to use stylelint
Hi all, Back when we switched from LESS to SCSS in the OPAC (Bug 20427) I added a linting configuration, .scss-lint.yml. I've always configured my editor to automatically lint SCSS using this configuration. I don't know if anyone else does this too. In VS Code I was using scss-lint for this, but it's now deprecated. They suggest stylelint instead: https://stylelint.io. I'd like to propose replacing .scss-lint.yml with .stylelintrc.json, transferring most of the same rules. It could be left up to the individual to install the dependencies, or I could update package.json. One nice thing about stylelint is that it has a "--fix" feature for some simple rules. This could be build into our gulp tasks. Has anyone else been linting SCSS? If so, does anyone have opinions about how our current rule set is working? -- Owen -- Web Developer Athens County Public Libraries (740) 737-6006 https://www.myacpl.org
For what it's worth, I don't touch the SCSS. I try to avoid it wherever possible and leave it up to people who know it better than me. Curious to hear about others... David Cook Senior Software Engineer Prosentient Systems Suite 7.03 6a Glen St Milsons Point NSW 2061 Australia Office: 02 9212 0899 Online: 02 8005 0595 -----Original Message----- From: Koha-devel <koha-devel-bounces@lists.koha-community.org> On Behalf Of Owen Leonard Sent: Tuesday, 19 July 2022 12:33 AM To: Koha Devel <koha-devel@lists.koha-community.org> Subject: [Koha-devel] Updating SCSS lint process to use stylelint Hi all, Back when we switched from LESS to SCSS in the OPAC (Bug 20427) I added a linting configuration, .scss-lint.yml. I've always configured my editor to automatically lint SCSS using this configuration. I don't know if anyone else does this too. In VS Code I was using scss-lint for this, but it's now deprecated. They suggest stylelint instead: https://stylelint.io. I'd like to propose replacing .scss-lint.yml with .stylelintrc.json, transferring most of the same rules. It could be left up to the individual to install the dependencies, or I could update package.json. One nice thing about stylelint is that it has a "--fix" feature for some simple rules. This could be build into our gulp tasks. Has anyone else been linting SCSS? If so, does anyone have opinions about how our current rule set is working? -- Owen -- Web Developer Athens County Public Libraries (740) 737-6006 https://www.myacpl.org _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
Hi Owen, I recently played around with the SCSS to create a more minimalist version of the bootstrap OPAC for LMSCloud. I used the predefined rules and I think they’re reasonable choices (Although I didn’t cross every rule for sure). Looking forward to stylint in Koha which I already use for some projects where I use stylus instead of SCSS. It’s a great tool. Kind regards Paul -- LMSCloud GmbH Paul Derscheid - Software Engineer Konrad-Zuse-Platz 8 - D-81829 München m +49 174 2436308 e paul.derscheid@lmscloud.de w www.lmscloud.de
On 18. Jul 2022, at 16:32, Owen Leonard <oleonard@myacpl.org> wrote:
Hi all,
Back when we switched from LESS to SCSS in the OPAC (Bug 20427) I added a linting configuration, .scss-lint.yml. I've always configured my editor to automatically lint SCSS using this configuration. I don't know if anyone else does this too.
In VS Code I was using scss-lint for this, but it's now deprecated. They suggest stylelint instead: https://stylelint.io. I'd like to propose replacing .scss-lint.yml with .stylelintrc.json, transferring most of the same rules.
It could be left up to the individual to install the dependencies, or I could update package.json. One nice thing about stylelint is that it has a "--fix" feature for some simple rules. This could be build into our gulp tasks.
Has anyone else been linting SCSS? If so, does anyone have opinions about how our current rule set is working?
-- Owen
-- Web Developer Athens County Public Libraries (740) 737-6006 https://www.myacpl.org _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
What exactly is stylelint? Is this what you get after washing clothes too many times? You know the laundry lint builds up so much it cramps your style! Wendy Sharkey Head of Circulation/ Cataloging and IT Bennington Free Library 101 Silver Street Bennington, VT 05201 (802) 442-9051 On Tue, Jul 19, 2022 at 4:29 AM Paul Derscheid <paul.derscheid@lmscloud.de> wrote:
Hi Owen,
I recently played around with the SCSS to create a more minimalist version of the bootstrap OPAC for LMSCloud. I used the predefined rules and I think they’re reasonable choices (Although I didn’t cross every rule for sure).
Looking forward to stylint in Koha which I already use for some projects where I use stylus instead of SCSS. It’s a great tool.
Kind regards
Paul
-- LMSCloud GmbH Paul Derscheid - Software Engineer Konrad-Zuse-Platz 8 - D-81829 München m +49 174 2436308 e paul.derscheid@lmscloud.de w www.lmscloud.de
On 18. Jul 2022, at 16:32, Owen Leonard <oleonard@myacpl.org> wrote:
Hi all,
Back when we switched from LESS to SCSS in the OPAC (Bug 20427) I added a linting configuration, .scss-lint.yml. I've always configured my editor to automatically lint SCSS using this configuration. I don't know if anyone else does this too.
In VS Code I was using scss-lint for this, but it's now deprecated. They suggest stylelint instead: https://stylelint.io. I'd like to propose replacing .scss-lint.yml with .stylelintrc.json, transferring most of the same rules.
It could be left up to the individual to install the dependencies, or I could update package.json. One nice thing about stylelint is that it has a "--fix" feature for some simple rules. This could be build into our gulp tasks.
Has anyone else been linting SCSS? If so, does anyone have opinions about how our current rule set is working?
-- Owen
-- Web Developer Athens County Public Libraries (740) 737-6006 https://www.myacpl.org _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
I'm in a similar camp to David, though I have touched it a few times here and there.. I wasn't aware of a linter, but would take your lead Owen, I like linters and tidies in general.. having consistent code is clearer code in my book. On Tue, 19 Jul 2022, 4:36 pm BFL Catalog, <catalog@bfli.org> wrote:
What exactly is stylelint? Is this what you get after washing clothes too many times? You know the laundry lint builds up so much it cramps your style!
Wendy Sharkey Head of Circulation/ Cataloging and IT Bennington Free Library 101 Silver Street Bennington, VT 05201 (802) 442-9051
On Tue, Jul 19, 2022 at 4:29 AM Paul Derscheid <paul.derscheid@lmscloud.de> wrote:
Hi Owen,
I recently played around with the SCSS to create a more minimalist version of the bootstrap OPAC for LMSCloud. I used the predefined rules and I think they’re reasonable choices (Although I didn’t cross every rule for sure).
Looking forward to stylint in Koha which I already use for some projects where I use stylus instead of SCSS. It’s a great tool.
Kind regards
Paul
-- LMSCloud GmbH Paul Derscheid - Software Engineer Konrad-Zuse-Platz 8 - D-81829 München m +49 174 2436308 e paul.derscheid@lmscloud.de w www.lmscloud.de
On 18. Jul 2022, at 16:32, Owen Leonard <oleonard@myacpl.org> wrote:
Hi all,
Back when we switched from LESS to SCSS in the OPAC (Bug 20427) I added a linting configuration, .scss-lint.yml. I've always configured my editor to automatically lint SCSS using this configuration. I don't know if anyone else does this too.
In VS Code I was using scss-lint for this, but it's now deprecated. They suggest stylelint instead: https://stylelint.io. I'd like to propose replacing .scss-lint.yml with .stylelintrc.json, transferring most of the same rules.
It could be left up to the individual to install the dependencies, or I could update package.json. One nice thing about stylelint is that it has a "--fix" feature for some simple rules. This could be build into our gulp tasks.
Has anyone else been linting SCSS? If so, does anyone have opinions about how our current rule set is working?
-- Owen
-- Web Developer Athens County Public Libraries (740) 737-6006 https://www.myacpl.org _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
Hi Owen! If the tool is deprecated, let's find another one. I'll follow your lead on this matter. El mié, 20 jul 2022 7:34, Renvoize, Martin <martin.renvoize@ptfs-europe.com> escribió:
I'm in a similar camp to David, though I have touched it a few times here and there.. I wasn't aware of a linter, but would take your lead Owen, I like linters and tidies in general.. having consistent code is clearer code in my book.
On Tue, 19 Jul 2022, 4:36 pm BFL Catalog, <catalog@bfli.org> wrote:
What exactly is stylelint? Is this what you get after washing clothes too many times? You know the laundry lint builds up so much it cramps your style!
Wendy Sharkey Head of Circulation/ Cataloging and IT Bennington Free Library 101 Silver Street Bennington, VT 05201 (802) 442-9051
On Tue, Jul 19, 2022 at 4:29 AM Paul Derscheid < paul.derscheid@lmscloud.de> wrote:
Hi Owen,
I recently played around with the SCSS to create a more minimalist version of the bootstrap OPAC for LMSCloud. I used the predefined rules and I think they’re reasonable choices (Although I didn’t cross every rule for sure).
Looking forward to stylint in Koha which I already use for some projects where I use stylus instead of SCSS. It’s a great tool.
Kind regards
Paul
-- LMSCloud GmbH Paul Derscheid - Software Engineer Konrad-Zuse-Platz 8 - D-81829 München m +49 174 2436308 e paul.derscheid@lmscloud.de w www.lmscloud.de
On 18. Jul 2022, at 16:32, Owen Leonard <oleonard@myacpl.org> wrote:
Hi all,
Back when we switched from LESS to SCSS in the OPAC (Bug 20427) I added a linting configuration, .scss-lint.yml. I've always configured my editor to automatically lint SCSS using this configuration. I don't know if anyone else does this too.
In VS Code I was using scss-lint for this, but it's now deprecated. They suggest stylelint instead: https://stylelint.io. I'd like to propose replacing .scss-lint.yml with .stylelintrc.json, transferring most of the same rules.
It could be left up to the individual to install the dependencies, or I could update package.json. One nice thing about stylelint is that it has a "--fix" feature for some simple rules. This could be build into our gulp tasks.
Has anyone else been linting SCSS? If so, does anyone have opinions about how our current rule set is working?
-- Owen
-- Web Developer Athens County Public Libraries (740) 737-6006 https://www.myacpl.org _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : https://www.koha-community.org/ git : https://git.koha-community.org/ bugs : https://bugs.koha-community.org/
participants (6)
-
BFL Catalog -
dcook＠prosentient.com.au -
Owen Leonard -
Paul Derscheid -
Renvoize, Martin -
Tomas Cohen Arazi